)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"46fbc4e4e1fc6d4dccfe1b131da7405067c1c128","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2aaba3b7_8cd3fad0","updated":"2024-11-08 09:43:00.000000000","message":"recheck","commit_id":"599fb4b64affdfd662fa0a6822d2ee270715e3fa"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4ea2114674e1efbe0f32828466603733889bbb7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"99e0e4d4_fe67defb","updated":"2024-11-07 14:49:27.000000000","message":"recheck","commit_id":"599fb4b64affdfd662fa0a6822d2ee270715e3fa"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eb325a3c373aad4fcae9496bc207302dd85f46a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eec8a4f2_6ad35c7a","updated":"2024-11-07 17:17:44.000000000","message":"recheck","commit_id":"599fb4b64affdfd662fa0a6822d2ee270715e3fa"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"dd614cb7b25fb1a7d2bd295aab6929c4540863dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5273a002_7c825b94","updated":"2024-11-07 23:21:37.000000000","message":"recheck migration tests POST_FAILURE with no logs","commit_id":"599fb4b64affdfd662fa0a6822d2ee270715e3fa"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e68e24131fca864bc558b5fcc90533babd6a0e38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"81159a77_ad7acaeb","updated":"2024-11-08 13:11:53.000000000","message":"recheck the 4k job is pretty unstable, it seems","commit_id":"599fb4b64affdfd662fa0a6822d2ee270715e3fa"}],"ironic/drivers/modules/redfish/power.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5a0b6d6a58bba22cf51328befc8ef5ac9481765c","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    system.reset_system(SET_POWER_STATE_MAP.get(power_state))"},{"line_number":66,"context_line":"    target_state \u003d TARGET_STATE_MAP.get(power_state, power_state)"},{"line_number":67,"context_line":"    if power_state \u003d\u003d states.REBOOT:"},{"line_number":68,"context_line":"        LOG.debug(\u0027Waiting 15 seconds to give the node %s a chance to power \u0027"},{"line_number":69,"context_line":"                  \u0027off before checking its power state\u0027, task.node.uuid)"},{"line_number":70,"context_line":"        time.sleep(15)"},{"line_number":71,"context_line":"    cond_utils.node_wait_for_power_state(task, target_state,"}],"source_content_type":"text/x-python","patch_set":2,"id":"03df5458_d0ed0c80","line":68,"updated":"2024-11-04 20:08:55.000000000","message":"Can you help me understand why this is needed given we\u0027re not calling _set_power_state in the disable_power_off case on line 149?","commit_id":"599fb4b64affdfd662fa0a6822d2ee270715e3fa"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"09a3e786011c755adfe64b76aaec083cdd4c0fb2","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    system.reset_system(SET_POWER_STATE_MAP.get(power_state))"},{"line_number":66,"context_line":"    target_state \u003d TARGET_STATE_MAP.get(power_state, power_state)"},{"line_number":67,"context_line":"    if power_state \u003d\u003d states.REBOOT:"},{"line_number":68,"context_line":"        LOG.debug(\u0027Waiting 15 seconds to give the node %s a chance to power \u0027"},{"line_number":69,"context_line":"                  \u0027off before checking its power state\u0027, task.node.uuid)"},{"line_number":70,"context_line":"        time.sleep(15)"},{"line_number":71,"context_line":"    cond_utils.node_wait_for_power_state(task, target_state,"}],"source_content_type":"text/x-python","patch_set":2,"id":"f183c3eb_3aded55a","line":68,"in_reply_to":"03df5458_d0ed0c80","updated":"2024-11-05 14:30:36.000000000","message":"See below.","commit_id":"599fb4b64affdfd662fa0a6822d2ee270715e3fa"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5a0b6d6a58bba22cf51328befc8ef5ac9481765c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    if power_state \u003d\u003d states.REBOOT:"},{"line_number":68,"context_line":"        LOG.debug(\u0027Waiting 15 seconds to give the node %s a chance to power \u0027"},{"line_number":69,"context_line":"                  \u0027off before checking its power state\u0027, task.node.uuid)"},{"line_number":70,"context_line":"        time.sleep(15)"},{"line_number":71,"context_line":"    cond_utils.node_wait_for_power_state(task, target_state,"},{"line_number":72,"context_line":"                                         timeout\u003dtimeout)"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"92b71f5c_c867007c","line":70,"updated":"2024-11-04 20:08:55.000000000","message":"I checked, and we are guaranteed this will wait at least 15 seconds even though eventlet is wacky: https://eventlet.readthedocs.io/en/stable/reference/api/eventlet.html#eventlet.greenthread.sleep","commit_id":"599fb4b64affdfd662fa0a6822d2ee270715e3fa"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"09a3e786011c755adfe64b76aaec083cdd4c0fb2","unresolved":true,"context_lines":[{"line_number":122,"context_line":"            task.driver.management.restore_boot_device(task, system)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        try:"},{"line_number":125,"context_line":"            _set_power_state(task, system, power_state, timeout\u003dtimeout)"},{"line_number":126,"context_line":"        except sushy.exceptions.SushyError as e:"},{"line_number":127,"context_line":"            error_msg \u003d (_(\u0027Setting power state to %(state)s failed for node \u0027"},{"line_number":128,"context_line":"                           \u0027%(node)s. Error: %(error)s\u0027) %"}],"source_content_type":"text/x-python","patch_set":2,"id":"fc2b2e39_7eeb5be7","line":125,"updated":"2024-11-05 14:30:36.000000000","message":"Jay, this is where it\u0027s called. This is a weirdness of our driver API: we technically allow two ways to do a reboot.\n\nAlternatively, I can make it call reboot() here, but that would be a behavior change.","commit_id":"599fb4b64affdfd662fa0a6822d2ee270715e3fa"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"57e2fb73be9ae57cafeaf6c49d05f3bdfdcbe6ba","unresolved":true,"context_lines":[{"line_number":122,"context_line":"            task.driver.management.restore_boot_device(task, system)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        try:"},{"line_number":125,"context_line":"            _set_power_state(task, system, power_state, timeout\u003dtimeout)"},{"line_number":126,"context_line":"        except sushy.exceptions.SushyError as e:"},{"line_number":127,"context_line":"            error_msg \u003d (_(\u0027Setting power state to %(state)s failed for node \u0027"},{"line_number":128,"context_line":"                           \u0027%(node)s. Error: %(error)s\u0027) %"}],"source_content_type":"text/x-python","patch_set":2,"id":"a12ad6af_950160bf","line":125,"in_reply_to":"fc2b2e39_7eeb5be7","updated":"2024-11-05 21:57:55.000000000","message":"!! thanks","commit_id":"599fb4b64affdfd662fa0a6822d2ee270715e3fa"}]}