)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"4933b850c41e3f8630c6650b990703481eef53bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4c8e14ac_affe21e9","updated":"2024-10-24 14:59:57.000000000","message":"Alternatively we could just exit\nironic/drivers/modules/inspector/interface.py::tear_down_managed_boot \nearly instead, this would avoid remove_inspection_network getting called?, any thoughts on this?","commit_id":"8115fd74b7d6b2c3eec6f63f787e564d63293d18"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"d74a866bfc5dae5a5474c15b8261d518fd280473","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ac531ae9_64e68f96","updated":"2024-11-12 15:50:59.000000000","message":"@dtantsur@protonmail.com looks like you may have already fixed this here ? \nhttps://review.opendev.org/c/openstack/ironic/+/932720 \n\n@bertrand.lallau@gmail.com can you retry this with Dmitry\u0027s patch","commit_id":"f992049c7278253493123df3a1b4b97a4083bd21"},{"author":{"_account_id":8157,"name":"Bertrand LALLAU","email":"bertrand.lallau@gmail.com","username":"blallau"},"change_message_id":"03a79db371a9121324113154e5460e9dd8895de2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ba7db8c8_b8833002","updated":"2024-11-12 15:31:11.000000000","message":"Any updates on this patch?\nI already test it, it fix the issue ;)","commit_id":"f992049c7278253493123df3a1b4b97a4083bd21"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"675ab5cb49dd8187175bc5eaaa06424de3469ab5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e47957fa_b92e1003","updated":"2025-02-27 16:23:12.000000000","message":"Closing, possibly fixed based on comments above","commit_id":"f992049c7278253493123df3a1b4b97a4083bd21"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"573ae1133e7fe3d361354bb93f19cfd50358bc6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c0edafb8_4a03b01b","in_reply_to":"ac531ae9_64e68f96","updated":"2025-02-12 09:08:48.000000000","message":"@bertrand.lallau@gmail.com did you have any luck with Dmitry\u0027s patch?","commit_id":"f992049c7278253493123df3a1b4b97a4083bd21"}],"ironic/drivers/modules/inspector/interface.py":[{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"a23b5f283d12eadd98341eb20805604a2a44c666","unresolved":true,"context_lines":[{"line_number":78,"context_line":"            LOG.exception(\u0027Unable to clean up ramdisk boot for node %s\u0027,"},{"line_number":79,"context_line":"                          task.node.uuid)"},{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        with cond_utils.power_state_for_network_configuration(task):"},{"line_number":82,"context_line":"            task.driver.network.remove_inspection_network(task)"},{"line_number":83,"context_line":"    except Exception as exc:"},{"line_number":84,"context_line":"        errors.append(_(\u0027unable to remove inspection ports: %s\u0027) % exc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"b16a895a_19f9edbe","line":81,"updated":"2024-10-25 12:50:37.000000000","message":"Do we also need to guard against doing this?","commit_id":"f992049c7278253493123df3a1b4b97a4083bd21"}],"ironic/drivers/modules/redfish/boot.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2d7a6cf87eeb81899fa3565b896d0e19d29effa2","unresolved":true,"context_lines":[{"line_number":805,"context_line":"        :param task: A task from TaskManager."},{"line_number":806,"context_line":"        :returns: None"},{"line_number":807,"context_line":"        \"\"\""},{"line_number":808,"context_line":"        if CONF.inspector.power_off and not utils.fast_track_enabled(task.node):"},{"line_number":809,"context_line":"            LOG.debug(\"Cleaning up deploy boot for %(node)s\","},{"line_number":810,"context_line":"                {\u0027node\u0027: task.node.uuid})"},{"line_number":811,"context_line":"            self._eject_all(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"74ed8841_1431c061","line":808,"updated":"2024-10-24 15:10:15.000000000","message":"clean_up_ramdisk is not used only in inspector, it\u0027s also run on cleaning/deploy","commit_id":"8115fd74b7d6b2c3eec6f63f787e564d63293d18"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"51df3fda0de609a77eb368e95e10a11f76e1500f","unresolved":true,"context_lines":[{"line_number":805,"context_line":"        :param task: A task from TaskManager."},{"line_number":806,"context_line":"        :returns: None"},{"line_number":807,"context_line":"        \"\"\""},{"line_number":808,"context_line":"        if CONF.inspector.power_off and not utils.fast_track_enabled(task.node):"},{"line_number":809,"context_line":"            LOG.debug(\"Cleaning up deploy boot for %(node)s\","},{"line_number":810,"context_line":"                {\u0027node\u0027: task.node.uuid})"},{"line_number":811,"context_line":"            self._eject_all(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4d395cf8_a861297e","line":808,"in_reply_to":"74ed8841_1431c061","updated":"2024-10-25 15:24:37.000000000","message":"I\u0027ve moved the check into tear_down_managed_boot in inspector/interface.py","commit_id":"8115fd74b7d6b2c3eec6f63f787e564d63293d18"}]}