)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"cdd36ef507d9b602774702837d10447cf32883bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ff5dbf2b_fd3213ea","updated":"2024-11-09 14:51:26.000000000","message":"recheck","commit_id":"9b17005bbb964af93cbd37183b4dcddfb7418624"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"452872e704017d2c7d8b217d606d7c701b192d18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7a5c76bc_c1e9f1d8","updated":"2024-11-15 13:04:45.000000000","message":"recheck\n\nci issues seem non-relevant","commit_id":"aeff930b12aadf4affbb701fe95ea9dec3e1508c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"691533842c9c956035f8336763682df74dbeb705","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4651c889_a91f9453","updated":"2025-02-03 16:04:33.000000000","message":"recheck","commit_id":"89ed19a9d39edf15a62aa20e05c68698d548e2e2"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"ccc310e9ef6ded9f8c5a4efb10fa0f76b62bde96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c59b193c_85d78bdc","updated":"2025-02-05 13:32:54.000000000","message":"can you fix the typo in the title next upload?","commit_id":"85a48c1378c6340f7e6900ae45bcbe49f2b2bb1d"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"3128e6f053eb3e7c2c09792fd004bf8da235c2e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"45947ab5_156d8939","in_reply_to":"c59b193c_85d78bdc","updated":"2025-02-06 13:59:58.000000000","message":"Sure, but a bigger problem is that it seems the patch breaks CI which I think it shouldn\u0027t.","commit_id":"85a48c1378c6340f7e6900ae45bcbe49f2b2bb1d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"73386185e6f1e78e941fbbd416a255d144e3b889","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e2a72b0e_49c210fc","updated":"2025-04-08 18:33:00.000000000","message":"This was reviewed as part of the PTG review jam. It looks good, but need a level of attention that can\u0027t be done in a group review. Expect detailed reviews \"soon\".","commit_id":"bd8d8b85a255c5f2c7ae42a82c1855cb0432d127"}],"ironic/drivers/modules/network/flat.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a80b243f754e0ff6bafbe6fa9f3de5cfdb183fb7","unresolved":true,"context_lines":[{"line_number":99,"context_line":"        :raises: NetworkError when failed to set binding:host_id"},{"line_number":100,"context_line":"        \"\"\""},{"line_number":101,"context_line":"        return self._add_service_network("},{"line_number":102,"context_line":"            task, self.get_provisioning_network_uuid(task), \u0027provisioning\u0027)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def remove_provisioning_network(self, task):"},{"line_number":105,"context_line":"        \"\"\"Remove the provisioning network from a node."}],"source_content_type":"text/x-python","patch_set":5,"id":"7f25724e_eb0c2027","line":102,"updated":"2025-04-08 19:29:31.000000000","message":"The CI failures are legitimate:\n\nMar 26 15:18:42.310831 np0040278096 ironic-conductor[76212]: ERROR ironic.conductor.utils [None req-cd7d1134-928a-4481-9a27-1670ee80da17 None None] Error while preparing to deploy to node 357d6989-50b3-4530-be38-6bce1290dcc2: UUID or name of provisioning_network is not set in configuration or in node driver_info.: ironic.common.exception.MissingParameterValue: UUID or name of provisioning_network is not set in configuration or in node driver_info.\n\nI *think* the challenge here is the assumption is the base state is flat is always pre-wired. nothing else is really required, but in this case you\u0027ve found where it makes sense.\n\nI think the path here is to try this, and fallback to the prior method.","commit_id":"bd8d8b85a255c5f2c7ae42a82c1855cb0432d127"}],"releasenotes/notes/flat-network-provisioning-a1199c5bae345a03.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"14b13d5b4c83b462b23e84bc156741f7709a3b39","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes the issue that ironic configures the porgroups for provisioning"},{"line_number":5,"context_line":"    instead of physical ports which fails deployment."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"18a10728_6cae04de","line":4,"updated":"2025-02-03 18:43:12.000000000","message":"spelling: portgroups\n\nSince it\u0027s releasenotes for a backportable fix, please fix before it lands. Thanks!","commit_id":"89ed19a9d39edf15a62aa20e05c68698d548e2e2"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"7d41251277856bb9e5c9aef364320be18858a16e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes the issue that ironic configures the porgroups for provisioning"},{"line_number":5,"context_line":"    instead of physical ports which fails deployment."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8f87ded9_f4b206ca","line":4,"in_reply_to":"18a10728_6cae04de","updated":"2025-02-05 11:15:42.000000000","message":"Done","commit_id":"89ed19a9d39edf15a62aa20e05c68698d548e2e2"}]}