)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5e12cd80f8776e09984e32c43194936a2a04bd5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c59f7d96_e22ab937","updated":"2024-11-21 11:57:18.000000000","message":"\u003e I\u0027m generally curious if we have coverage for this code path in integration tests; especially since a soft power off failure would likely be covered up by the fallback to a hard power off.\n\nYeah, exactly. I\u0027m still pondering the best way to do it.\n\nThe release note is coming in https://review.opendev.org/c/openstack/ironic/+/934740","commit_id":"a0dddb19a6e94b2df64235eb229ca3fd9027c0fc"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"e0ff70edd4a6f813deaebbbc0d45d09e977e0a8f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a6794322_1b07244a","updated":"2024-11-20 18:29:54.000000000","message":"Do we need a release note (yet) at this point in the chain?","commit_id":"a0dddb19a6e94b2df64235eb229ca3fd9027c0fc"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"67e1f12d9e3bd8ff38879543497561e78b896cb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"62e0854a_f52bd608","updated":"2024-11-20 18:29:39.000000000","message":"Reviewing these really makes me feel like we need to enable this setting on a node for some of our tempest jobs. Are you planning on doing that or something similar?\n\nNot requiring it as I remember a discussion about implementing a real \"reboot\" in sushy-tools and friends being very hard.","commit_id":"a0dddb19a6e94b2df64235eb229ca3fd9027c0fc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"735a56c39c21f0d7a2a5d899382f3ad819b39e2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7539d174_1215e6b1","updated":"2024-11-22 14:24:55.000000000","message":"recheck","commit_id":"a0dddb19a6e94b2df64235eb229ca3fd9027c0fc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ff77c8ed98ba3c69b55029cfe73eaf94296a3ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"01373a99_1139a3da","updated":"2024-11-21 16:22:30.000000000","message":"recheck dependency merged","commit_id":"a0dddb19a6e94b2df64235eb229ca3fd9027c0fc"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e2e17b8cc6c416a56dc18e655ca3550e3b83d944","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c4a519b2_89561f2c","updated":"2024-11-22 09:47:56.000000000","message":"recheck metal3 job should be fixed now","commit_id":"a0dddb19a6e94b2df64235eb229ca3fd9027c0fc"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"9d6f4ebf007829866ceadbe0c6bf14e11eda7022","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e88133fc_ad957aeb","updated":"2024-11-25 14:31:54.000000000","message":"recheck ovn shenanigan?","commit_id":"a0dddb19a6e94b2df64235eb229ca3fd9027c0fc"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"67e1f12d9e3bd8ff38879543497561e78b896cb5","unresolved":true,"context_lines":[{"line_number":1659,"context_line":"        if (manager_utils.is_fast_track(task)"},{"line_number":1660,"context_line":"                and not task.node.disable_power_off):"},{"line_number":1661,"context_line":"            LOG.debug(\u0027Forcing power off on node %s for a clean reboot into \u0027"},{"line_number":1662,"context_line":"                      \u0027the agent image\u0027, task.node)"},{"line_number":1663,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":1664,"context_line":"        prepare_agent_boot(task)"},{"line_number":1665,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3cfb5147_9291b60e","line":1662,"updated":"2024-11-20 18:29:39.000000000","message":"This log is not printing if we have power_off disabled, but the gist of it still seems to apply (we are doing a clean reboot into the agent image, even if implementation is \"REBOOT\" not \"POWER_OFF/REBOOT\")","commit_id":"a0dddb19a6e94b2df64235eb229ca3fd9027c0fc"}]}