)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"863bded2f5a843a7e368eb5db57a9df5bfb9da91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a9f6f240_031cd2eb","updated":"2024-11-22 20:39:11.000000000","message":"Just a pile of questions. I know you\u0027re rewriting some of this in later series so I\u0027ll +2 it but just something to consider for your rewrites.","commit_id":"e02fa1591d9fade9a2d80e248082b9fff95a85c0"}],"doc/source/admin/networking.rst":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"863bded2f5a843a7e368eb5db57a9df5bfb9da91","unresolved":true,"context_lines":[{"line_number":29,"context_line":"-----------"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- ``vif`` or ``VIF`` - Virtual Interface which is best described as a Neutron"},{"line_number":32,"context_line":"  port. VIFs are always referred to utilizing the port ID value."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- ``ML2`` - ML2 is a plugin model for Neutron, the Networking service."},{"line_number":35,"context_line":"  Advanced networking interactions including 3rd party plugins are utilized"}],"source_content_type":"text/x-rst","patch_set":1,"id":"91da73cc_f6dfcdef","line":32,"updated":"2024-11-22 20:39:11.000000000","message":"port. VIFs are always referred to utilizing the Ironic? Neuron? port ID value.\n  \nI don\u0027t believe the two are the same value.","commit_id":"065686868a6e1ec56172af9a2cdeff9c1f03cd93"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e741e64a869792248eaff9c75648f7ee3a61792a","unresolved":true,"context_lines":[{"line_number":29,"context_line":"-----------"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- ``vif`` or ``VIF`` - Virtual Interface which is best described as a Neutron"},{"line_number":32,"context_line":"  port. VIFs are always referred to utilizing the port ID value."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- ``ML2`` - ML2 is a plugin model for Neutron, the Networking service."},{"line_number":35,"context_line":"  Advanced networking interactions including 3rd party plugins are utilized"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9c07f035_90bd69cc","line":32,"in_reply_to":"91da73cc_f6dfcdef","updated":"2024-11-22 21:44:09.000000000","message":"Sorry, Neutron port ID value. The field is called ID, but the value type is uuid.","commit_id":"065686868a6e1ec56172af9a2cdeff9c1f03cd93"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"76e8185d9c617526c9b7362187c9f5ba35d4db19","unresolved":true,"context_lines":[{"line_number":29,"context_line":"-----------"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- ``vif`` or ``VIF`` - Virtual Interface which is best described as a Neutron"},{"line_number":32,"context_line":"  port. VIFs are always referred to utilizing the port ID value."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- ``ML2`` - ML2 is a plugin model for Neutron, the Networking service."},{"line_number":35,"context_line":"  Advanced networking interactions including 3rd party plugins are utilized"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4930c0e4_1269b1ff","line":32,"in_reply_to":"9c07f035_90bd69cc","updated":"2024-11-25 14:55:02.000000000","message":"Clarified in the final pass patch.","commit_id":"065686868a6e1ec56172af9a2cdeff9c1f03cd93"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"863bded2f5a843a7e368eb5db57a9df5bfb9da91","unresolved":true,"context_lines":[{"line_number":86,"context_line":"-------------------"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"When creating a VIF, the action occurs against the Neutron Networking Service,"},{"line_number":89,"context_line":"such as by using the ``openstack port create`` command, and then the port UUID"},{"line_number":90,"context_line":"is submitted to Ironic to facilitate a VIF attachment."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df16d755_d86403cd","line":89,"updated":"2024-11-22 20:39:11.000000000","message":"So this says \"port UUID\" while above you said \"port ID\". Should probably use the same phrasing. In this case this is the Neutron port ID as well.","commit_id":"065686868a6e1ec56172af9a2cdeff9c1f03cd93"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"76e8185d9c617526c9b7362187c9f5ba35d4db19","unresolved":true,"context_lines":[{"line_number":86,"context_line":"-------------------"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"When creating a VIF, the action occurs against the Neutron Networking Service,"},{"line_number":89,"context_line":"such as by using the ``openstack port create`` command, and then the port UUID"},{"line_number":90,"context_line":"is submitted to Ironic to facilitate a VIF attachment."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3e8cb165_d7ca4c31","line":89,"in_reply_to":"df16d755_d86403cd","updated":"2024-11-25 14:55:02.000000000","message":"Yes, it is. Addressing in the follow-up patch.","commit_id":"065686868a6e1ec56172af9a2cdeff9c1f03cd93"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"545129aa18387992fa8527bde011b33d154f07f0","unresolved":true,"context_lines":[{"line_number":102,"context_line":"unattached port or port group:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* Require ports or port groups to not have a physical network or to have a"},{"line_number":105,"context_line":"  physical network that matches one of the VIF\u0027s allowed physical networks."},{"line_number":106,"context_line":"* Prefer ports and port groups that have a physical network to ports and"},{"line_number":107,"context_line":"  port groups that do not have a physical network."},{"line_number":108,"context_line":"* Prefer port groups to ports, prefer ports with PXE enabled."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7cf120df_e831ae1f","line":105,"updated":"2024-11-22 22:04:21.000000000","message":"This is where the wording made me say \"a VIF can have multiple physical networks?!\". There\u0027s a good definition of physical networks lower down in the doc. Maybe we end up moving it up?","commit_id":"065686868a6e1ec56172af9a2cdeff9c1f03cd93"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"76e8185d9c617526c9b7362187c9f5ba35d4db19","unresolved":true,"context_lines":[{"line_number":102,"context_line":"unattached port or port group:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* Require ports or port groups to not have a physical network or to have a"},{"line_number":105,"context_line":"  physical network that matches one of the VIF\u0027s allowed physical networks."},{"line_number":106,"context_line":"* Prefer ports and port groups that have a physical network to ports and"},{"line_number":107,"context_line":"  port groups that do not have a physical network."},{"line_number":108,"context_line":"* Prefer port groups to ports, prefer ports with PXE enabled."}],"source_content_type":"text/x-rst","patch_set":1,"id":"e8f36a1d_a317fa73","line":105,"in_reply_to":"7cf120df_e831ae1f","updated":"2024-11-25 14:55:02.000000000","message":"So I looked at that and its not really the best. I went ahead and added an entry in the follow-up patch.","commit_id":"065686868a6e1ec56172af9a2cdeff9c1f03cd93"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"863bded2f5a843a7e368eb5db57a9df5bfb9da91","unresolved":true,"context_lines":[{"line_number":101,"context_line":"Ironic API, the following ordered criteria are used to select a suitable"},{"line_number":102,"context_line":"unattached port or port group:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* Require ports or port groups to not have a physical network or to have a"},{"line_number":105,"context_line":"  physical network that matches one of the VIF\u0027s allowed physical networks."},{"line_number":106,"context_line":"* Prefer ports and port groups that have a physical network to ports and"},{"line_number":107,"context_line":"  port groups that do not have a physical network."},{"line_number":108,"context_line":"* Prefer port groups to ports, prefer ports with PXE enabled."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2593de40_ee10fe8a","line":107,"range":{"start_line":104,"start_character":1,"end_line":107,"end_character":3},"updated":"2024-11-22 20:39:11.000000000","message":"```suggestion\n* Require ports or port groups to not have a physical network or to have a\n  physical network that matches one of the VIF\u0027s allowed physical networks.\n* Prefer ports and port groups that have a physical network to ports and\n  port groups that do not have a physical network.\n```\n\nI dunno yet but these two are a bit hard to parse not sure the best way. Maybe break up to say the requirements and then the selection flow?","commit_id":"065686868a6e1ec56172af9a2cdeff9c1f03cd93"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e741e64a869792248eaff9c75648f7ee3a61792a","unresolved":true,"context_lines":[{"line_number":101,"context_line":"Ironic API, the following ordered criteria are used to select a suitable"},{"line_number":102,"context_line":"unattached port or port group:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* Require ports or port groups to not have a physical network or to have a"},{"line_number":105,"context_line":"  physical network that matches one of the VIF\u0027s allowed physical networks."},{"line_number":106,"context_line":"* Prefer ports and port groups that have a physical network to ports and"},{"line_number":107,"context_line":"  port groups that do not have a physical network."},{"line_number":108,"context_line":"* Prefer port groups to ports, prefer ports with PXE enabled."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2d5f6849_6801c8ef","line":107,"range":{"start_line":104,"start_character":1,"end_line":107,"end_character":3},"in_reply_to":"2593de40_ee10fe8a","updated":"2024-11-22 21:44:09.000000000","message":"hmm, perhaps. It is a bit condensed...","commit_id":"065686868a6e1ec56172af9a2cdeff9c1f03cd93"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"76e8185d9c617526c9b7362187c9f5ba35d4db19","unresolved":true,"context_lines":[{"line_number":101,"context_line":"Ironic API, the following ordered criteria are used to select a suitable"},{"line_number":102,"context_line":"unattached port or port group:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* Require ports or port groups to not have a physical network or to have a"},{"line_number":105,"context_line":"  physical network that matches one of the VIF\u0027s allowed physical networks."},{"line_number":106,"context_line":"* Prefer ports and port groups that have a physical network to ports and"},{"line_number":107,"context_line":"  port groups that do not have a physical network."},{"line_number":108,"context_line":"* Prefer port groups to ports, prefer ports with PXE enabled."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"23173532_7d90aff7","line":107,"range":{"start_line":104,"start_character":1,"end_line":107,"end_character":3},"in_reply_to":"2d5f6849_6801c8ef","updated":"2024-11-25 14:55:02.000000000","message":"Hmm, we over-use that in this as well which likely doesn\u0027t help. Putting some changes in to the follow-up patch.","commit_id":"065686868a6e1ec56172af9a2cdeff9c1f03cd93"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"863bded2f5a843a7e368eb5db57a9df5bfb9da91","unresolved":true,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"When provisioning, Ironic will attempt to attach all PXE enabled"},{"line_number":140,"context_line":"ports to the `provisioning network`. A modifier for this behavior is the"},{"line_number":141,"context_line":"``[neutron]add_all_ports`` option."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"After provisioning work has been completed, and prior to the node being"},{"line_number":144,"context_line":"moved to the ``ACTIVE`` `provision_state`, the previously attached ports"}],"source_content_type":"text/x-rst","patch_set":1,"id":"34dc4a8e_ed629207","line":141,"updated":"2024-11-22 20:39:11.000000000","message":"Might be worth mentioning what that modifier is? How is the port selected in that case?\n\nIs there a better syntax to the config?","commit_id":"065686868a6e1ec56172af9a2cdeff9c1f03cd93"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e741e64a869792248eaff9c75648f7ee3a61792a","unresolved":true,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"When provisioning, Ironic will attempt to attach all PXE enabled"},{"line_number":140,"context_line":"ports to the `provisioning network`. A modifier for this behavior is the"},{"line_number":141,"context_line":"``[neutron]add_all_ports`` option."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"After provisioning work has been completed, and prior to the node being"},{"line_number":144,"context_line":"moved to the ``ACTIVE`` `provision_state`, the previously attached ports"}],"source_content_type":"text/x-rst","patch_set":1,"id":"97c4a214_13861a24","line":141,"in_reply_to":"34dc4a8e_ed629207","updated":"2024-11-22 21:44:09.000000000","message":"oh, yeah, add all ports instead of just the pxe_enabled ports to the bindings. Specificlaly just for the service networks.","commit_id":"065686868a6e1ec56172af9a2cdeff9c1f03cd93"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"76e8185d9c617526c9b7362187c9f5ba35d4db19","unresolved":true,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"When provisioning, Ironic will attempt to attach all PXE enabled"},{"line_number":140,"context_line":"ports to the `provisioning network`. A modifier for this behavior is the"},{"line_number":141,"context_line":"``[neutron]add_all_ports`` option."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"After provisioning work has been completed, and prior to the node being"},{"line_number":144,"context_line":"moved to the ``ACTIVE`` `provision_state`, the previously attached ports"}],"source_content_type":"text/x-rst","patch_set":1,"id":"65710a4b_fcc601b3","line":141,"in_reply_to":"97c4a214_13861a24","updated":"2024-11-25 14:55:02.000000000","message":"Addressing in the follow-up patch at the end of the series. There is likely better syntax for the config as well, just not quite there yet. 😊","commit_id":"065686868a6e1ec56172af9a2cdeff9c1f03cd93"}]}