)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ed3ba792487397c826f5a630d46707a02fa90d37","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ddf11c41_e44eb85e","updated":"2024-12-04 17:22:13.000000000","message":"We need to raise the minimum required version in requirements.txt to oslo.utils to the one that contains this version -- if that oslo.utils hasn\u0027t been released yet, it must be before this change can merge.\n\nIronic does mid-cycle releases so we cannot rely on any unreleased oslo features.","commit_id":"615cb2b6300719f1669e76625435377b809dd793"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"749c99358761e4f0084786f461ec230a94eedd0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ce374a61_cc389dfc","updated":"2024-12-09 10:58:06.000000000","message":"recheck since we now have newer oslo.utils available","commit_id":"615cb2b6300719f1669e76625435377b809dd793"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"ac1c22a6ed6adcf23799bc2e38d22e15266397e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b4944882_f53b7279","in_reply_to":"ddf11c41_e44eb85e","updated":"2024-12-10 10:13:10.000000000","message":"Done","commit_id":"615cb2b6300719f1669e76625435377b809dd793"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5f928db018a8cdcccaa26d4a95fa2483dbf6da2b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b7433276_cfb7e49a","updated":"2024-12-10 16:33:08.000000000","message":"I\u0027ve prepared a different change to replace crypt here, which I believe more complete now. https://review.opendev.org/c/openstack/ironic/+/937173\n\nI wonder if we can merge that one instead and discuss the change in default password algorithm separately.","commit_id":"26e4fe96f083c9ff29077a0dfe80dabee54ffbf5"}],"ironic/conf/conductor.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c97a213e5d1da5a658cd2c4b62c6ef81cfbcdea5","unresolved":true,"context_lines":[{"line_number":259,"context_line":"                help\u003d_(\u0027A dictionary of key-value pairs of each architecture \u0027"},{"line_number":260,"context_line":"                       \u0027with the Glance ID, http:// or file:// URL of the \u0027"},{"line_number":261,"context_line":"                       \u0027initramfs of the default rescue image.\u0027)),"},{"line_number":262,"context_line":"    cfg.StrOpt(\u0027rescue_password_hash_algorithm\u0027,"},{"line_number":263,"context_line":"               default\u003d\u0027sha256\u0027,"},{"line_number":264,"context_line":"               choices\u003d[\u0027sha256\u0027, \u0027sha512\u0027],"},{"line_number":265,"context_line":"               mutable\u003dTrue,"},{"line_number":266,"context_line":"               help\u003d_(\u0027Password hash algorithm to be used for the rescue \u0027"},{"line_number":267,"context_line":"                      \u0027password.\u0027)),"},{"line_number":268,"context_line":"    cfg.BoolOpt(\u0027require_rescue_password_hashed\u0027,"},{"line_number":269,"context_line":"                default\u003dTrue,"},{"line_number":270,"context_line":"                mutable\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3b9f8093_b329cd82","side":"PARENT","line":267,"range":{"start_line":262,"start_character":0,"end_line":267,"end_character":36},"updated":"2024-12-05 12:58:53.000000000","message":"Why are we removing this option ? Even if we do, we should not directly remove it without any deprecation.","commit_id":"20f7e5a5173ae1634ad753b44b6fa5bf9ff28e63"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a943fb4f522e6a016502f7b07eb31e8a39b6e175","unresolved":true,"context_lines":[{"line_number":259,"context_line":"                help\u003d_(\u0027A dictionary of key-value pairs of each architecture \u0027"},{"line_number":260,"context_line":"                       \u0027with the Glance ID, http:// or file:// URL of the \u0027"},{"line_number":261,"context_line":"                       \u0027initramfs of the default rescue image.\u0027)),"},{"line_number":262,"context_line":"    cfg.StrOpt(\u0027rescue_password_hash_algorithm\u0027,"},{"line_number":263,"context_line":"               default\u003d\u0027sha256\u0027,"},{"line_number":264,"context_line":"               choices\u003d[\u0027sha256\u0027, \u0027sha512\u0027],"},{"line_number":265,"context_line":"               mutable\u003dTrue,"},{"line_number":266,"context_line":"               help\u003d_(\u0027Password hash algorithm to be used for the rescue \u0027"},{"line_number":267,"context_line":"                      \u0027password.\u0027)),"},{"line_number":268,"context_line":"    cfg.BoolOpt(\u0027require_rescue_password_hashed\u0027,"},{"line_number":269,"context_line":"                default\u003dTrue,"},{"line_number":270,"context_line":"                mutable\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9803e714_7ddc105d","side":"PARENT","line":267,"range":{"start_line":262,"start_character":0,"end_line":267,"end_character":36},"in_reply_to":"3a104422_28fc99c3","updated":"2024-12-10 16:08:45.000000000","message":"This change requires a deprecation period, I believe. Doesn\u0027t this require the rescue ramdisk to be using a distribution that supports SHA512 in /etc/shadow?","commit_id":"20f7e5a5173ae1634ad753b44b6fa5bf9ff28e63"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"f73cee734ee6274b2dbd507bab12de511518bd1a","unresolved":true,"context_lines":[{"line_number":259,"context_line":"                help\u003d_(\u0027A dictionary of key-value pairs of each architecture \u0027"},{"line_number":260,"context_line":"                       \u0027with the Glance ID, http:// or file:// URL of the \u0027"},{"line_number":261,"context_line":"                       \u0027initramfs of the default rescue image.\u0027)),"},{"line_number":262,"context_line":"    cfg.StrOpt(\u0027rescue_password_hash_algorithm\u0027,"},{"line_number":263,"context_line":"               default\u003d\u0027sha256\u0027,"},{"line_number":264,"context_line":"               choices\u003d[\u0027sha256\u0027, \u0027sha512\u0027],"},{"line_number":265,"context_line":"               mutable\u003dTrue,"},{"line_number":266,"context_line":"               help\u003d_(\u0027Password hash algorithm to be used for the rescue \u0027"},{"line_number":267,"context_line":"                      \u0027password.\u0027)),"},{"line_number":268,"context_line":"    cfg.BoolOpt(\u0027require_rescue_password_hashed\u0027,"},{"line_number":269,"context_line":"                default\u003dTrue,"},{"line_number":270,"context_line":"                mutable\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a104422_28fc99c3","side":"PARENT","line":267,"range":{"start_line":262,"start_character":0,"end_line":267,"end_character":36},"in_reply_to":"3b9f8093_b329cd82","updated":"2024-12-10 10:20:39.000000000","message":"Instead of removing it, I\u0027ve just changed the default. Hopefully, that will be enough.","commit_id":"20f7e5a5173ae1634ad753b44b6fa5bf9ff28e63"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5f928db018a8cdcccaa26d4a95fa2483dbf6da2b","unresolved":true,"context_lines":[{"line_number":259,"context_line":"                help\u003d_(\u0027A dictionary of key-value pairs of each architecture \u0027"},{"line_number":260,"context_line":"                       \u0027with the Glance ID, http:// or file:// URL of the \u0027"},{"line_number":261,"context_line":"                       \u0027initramfs of the default rescue image.\u0027)),"},{"line_number":262,"context_line":"    cfg.StrOpt(\u0027rescue_password_hash_algorithm\u0027,"},{"line_number":263,"context_line":"               default\u003d\u0027sha256\u0027,"},{"line_number":264,"context_line":"               choices\u003d[\u0027sha256\u0027, \u0027sha512\u0027],"},{"line_number":265,"context_line":"               mutable\u003dTrue,"},{"line_number":266,"context_line":"               help\u003d_(\u0027Password hash algorithm to be used for the rescue \u0027"},{"line_number":267,"context_line":"                      \u0027password.\u0027)),"},{"line_number":268,"context_line":"    cfg.BoolOpt(\u0027require_rescue_password_hashed\u0027,"},{"line_number":269,"context_line":"                default\u003dTrue,"},{"line_number":270,"context_line":"                mutable\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"859c7bcb_94c416e7","side":"PARENT","line":267,"range":{"start_line":262,"start_character":0,"end_line":267,"end_character":36},"in_reply_to":"9803e714_7ddc105d","updated":"2024-12-10 16:33:08.000000000","message":"This change itself is not required to be part of this switch. I\u0027d suggest separating this default change to a different change.","commit_id":"20f7e5a5173ae1634ad753b44b6fa5bf9ff28e63"}],"requirements.txt":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5f928db018a8cdcccaa26d4a95fa2483dbf6da2b","unresolved":true,"context_lines":[{"line_number":23,"context_line":"oslo.serialization\u003e\u003d2.25.0 # Apache-2.0"},{"line_number":24,"context_line":"oslo.service\u003e\u003d1.24.0 # Apache-2.0"},{"line_number":25,"context_line":"oslo.upgradecheck\u003e\u003d1.3.0 # Apache-2.0"},{"line_number":26,"context_line":"oslo.utils\u003e\u003d7.3.0 # Apache-2.0"},{"line_number":27,"context_line":"oslo.utils\u003e\u003d8.0.0 # Apache-2.0"},{"line_number":28,"context_line":"osprofiler\u003e\u003d1.5.0 # Apache-2.0"},{"line_number":29,"context_line":"os-traits\u003e\u003d0.4.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":5,"id":"e0f3bf7a_d56e71c2","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":30},"updated":"2024-12-10 16:33:08.000000000","message":"This line should be replaced.","commit_id":"26e4fe96f083c9ff29077a0dfe80dabee54ffbf5"}]}