)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"58deae19699eda8ec7bc6b44d81d171b2df58ab4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ec99546d_f2ed629c","updated":"2025-01-28 20:38:16.000000000","message":"Can\u0027t decide if [agent]/inspector_hooks would be better. I feel like \"default_hooks\" is just an awkward way for us to set defaults but kept it.","commit_id":"0d8c51e1e17060f2dd0216160941a503a78dc906"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f1ab48b6167959ef836a44740fa14ccf3b289fa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75f7f845_c3863360","updated":"2025-02-03 14:46:04.000000000","message":"Sorry, I don\u0027t quite agree with the deprecation. Although I see your line of reasoning, I think it makes things more confusing for people without enough context. I\u0027d rather see [inspector]hooks stay, then [redfish]hooks added and so on.","commit_id":"0d8c51e1e17060f2dd0216160941a503a78dc906"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"062e004438f31af97403549e995a061e9e596f5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8e14b057_0b1b2dba","in_reply_to":"ec99546d_f2ed629c","updated":"2025-02-15 05:16:00.000000000","message":"Done","commit_id":"0d8c51e1e17060f2dd0216160941a503a78dc906"}],"ironic/conf/inspector.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f1ab48b6167959ef836a44740fa14ccf3b289fa2","unresolved":true,"context_lines":[{"line_number":87,"context_line":"                       \u0027according to the inspection data.\u0027)),"},{"line_number":88,"context_line":"    cfg.StrOpt(\u0027default_hooks\u0027,"},{"line_number":89,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":90,"context_line":"               deprecated_reason\u003d_(\"Use agent_default_hooks instead\"),"},{"line_number":91,"context_line":"               default\u003d\u0027ramdisk-error,validate-interfaces,ports,architecture\u0027,"},{"line_number":92,"context_line":"               help\u003d_(\u0027A comma-separated lists of inspection hooks that are \u0027"},{"line_number":93,"context_line":"                      \u0027run by default. In most cases, the operators will not \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"53a2a4d7_fb94339d","line":90,"updated":"2025-02-03 14:46:04.000000000","message":"I\u0027d prefer to avoid this deprecation. \"agent hooks\" is not a valid concept even. Hooks for other drivers should live under the same name in their respective configuration sections.","commit_id":"0d8c51e1e17060f2dd0216160941a503a78dc906"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"08306b2bfb7a7d6709e9dee5055e9e8cd923d21e","unresolved":true,"context_lines":[{"line_number":87,"context_line":"                       \u0027according to the inspection data.\u0027)),"},{"line_number":88,"context_line":"    cfg.StrOpt(\u0027default_hooks\u0027,"},{"line_number":89,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":90,"context_line":"               deprecated_reason\u003d_(\"Use agent_default_hooks instead\"),"},{"line_number":91,"context_line":"               default\u003d\u0027ramdisk-error,validate-interfaces,ports,architecture\u0027,"},{"line_number":92,"context_line":"               help\u003d_(\u0027A comma-separated lists of inspection hooks that are \u0027"},{"line_number":93,"context_line":"                      \u0027run by default. In most cases, the operators will not \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"91286c31_83714d80","line":90,"in_reply_to":"53a2a4d7_fb94339d","updated":"2025-02-06 22:12:37.000000000","message":"It\u0027s just such an awkward tangle today. In the prior patch / change, you mentioned the storing of logs. That configuration knob is [agent].deploy_logs_collect even though its for the inspection logs. Just looking for consistency. You\u0027re saying hooks for other drivers should live in their respective configuration section but the [agent] section is what\u0027s used for configuring things associated with the IPA.","commit_id":"0d8c51e1e17060f2dd0216160941a503a78dc906"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a3971dedb31cec52709a9df5e94b2480df27814","unresolved":true,"context_lines":[{"line_number":87,"context_line":"                       \u0027according to the inspection data.\u0027)),"},{"line_number":88,"context_line":"    cfg.StrOpt(\u0027default_hooks\u0027,"},{"line_number":89,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":90,"context_line":"               deprecated_reason\u003d_(\"Use agent_default_hooks instead\"),"},{"line_number":91,"context_line":"               default\u003d\u0027ramdisk-error,validate-interfaces,ports,architecture\u0027,"},{"line_number":92,"context_line":"               help\u003d_(\u0027A comma-separated lists of inspection hooks that are \u0027"},{"line_number":93,"context_line":"                      \u0027run by default. In most cases, the operators will not \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"94845eb5_a2758914","line":90,"in_reply_to":"91286c31_83714d80","updated":"2025-02-10 15:45:48.000000000","message":"\u003e [agent].deploy_logs_collect\n\nExisted before the inspection implementation :(","commit_id":"0d8c51e1e17060f2dd0216160941a503a78dc906"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"062e004438f31af97403549e995a061e9e596f5b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                       \u0027according to the inspection data.\u0027)),"},{"line_number":88,"context_line":"    cfg.StrOpt(\u0027default_hooks\u0027,"},{"line_number":89,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":90,"context_line":"               deprecated_reason\u003d_(\"Use agent_default_hooks instead\"),"},{"line_number":91,"context_line":"               default\u003d\u0027ramdisk-error,validate-interfaces,ports,architecture\u0027,"},{"line_number":92,"context_line":"               help\u003d_(\u0027A comma-separated lists of inspection hooks that are \u0027"},{"line_number":93,"context_line":"                      \u0027run by default. In most cases, the operators will not \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"2b223ed5_d1ea6e38","line":90,"in_reply_to":"94845eb5_a2758914","updated":"2025-02-15 05:16:00.000000000","message":"Done","commit_id":"0d8c51e1e17060f2dd0216160941a503a78dc906"}]}