)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1944667cfb5f32f3eb777ead770fdfaf896ef78e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0d60dac9_ce95e2be","updated":"2025-01-30 19:48:06.000000000","message":"As this is a backportable fix, we need a release note -- you don\u0027t have to file a launchpad bug, just make sure the release note indicates the issue you fixed. I\u0027m happy to update this with a release note for you if you want; just ask.","commit_id":"d9054f017d4d1099dc472bc3c1887ab84eeacc42"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"49936d93725d3c25ea71b09b5fe64077f898a0f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"54da0bc8_963f27e3","updated":"2025-01-30 10:07:25.000000000","message":"thanks! one comment inline","commit_id":"d9054f017d4d1099dc472bc3c1887ab84eeacc42"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"d8b4858e99ed05ccb728c35eacf07c3bcf1584e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"36e90139_a09bc1bc","updated":"2025-01-30 13:55:41.000000000","message":"this seems good. we’d want to back port it as well.","commit_id":"d9054f017d4d1099dc472bc3c1887ab84eeacc42"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"880d795e674a899da22014ea1c12d30a67e572d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9bf067d1_f24045e9","updated":"2025-01-30 20:18:00.000000000","message":"Carrying over Doug\u0027s +2 since the only change this patchset was a release note.","commit_id":"91b656d31cac77817db8c865d68471d546903314"}],"ironic/drivers/modules/redfish/utils.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"49936d93725d3c25ea71b09b5fe64077f898a0f6","unresolved":true,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    sushy_params \u003d {\u0027address\u0027: address,"},{"line_number":187,"context_line":"                    \u0027system_id\u0027: redfish_system_id,"},{"line_number":188,"context_line":"                    \u0027username\u0027: driver_info.get(\u0027redfish_username\u0027),"},{"line_number":189,"context_line":"                    \u0027password\u0027: driver_info.get(\u0027redfish_password\u0027),"},{"line_number":190,"context_line":"                    \u0027verify_ca\u0027: verify_ca,"},{"line_number":191,"context_line":"                    \u0027auth_type\u0027: auth_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"36506fdd_64fa6438","line":188,"updated":"2025-01-30 10:07:25.000000000","message":"I guess you could also specify a default value of \u0027\u0027 for get here","commit_id":"d9054f017d4d1099dc472bc3c1887ab84eeacc42"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c8e6f7ee2372ef626012ac9dc711709eba8ac6b6","unresolved":true,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    sushy_params \u003d {\u0027address\u0027: address,"},{"line_number":187,"context_line":"                    \u0027system_id\u0027: redfish_system_id,"},{"line_number":188,"context_line":"                    \u0027username\u0027: driver_info.get(\u0027redfish_username\u0027),"},{"line_number":189,"context_line":"                    \u0027password\u0027: driver_info.get(\u0027redfish_password\u0027),"},{"line_number":190,"context_line":"                    \u0027verify_ca\u0027: verify_ca,"},{"line_number":191,"context_line":"                    \u0027auth_type\u0027: auth_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"55bbf7ab_1b47f62a","line":188,"in_reply_to":"36506fdd_64fa6438","updated":"2025-01-30 13:40:44.000000000","message":"You mean on the line below? I considered that, but wasn\u0027t sure whether that might have other side effects, like sending an empty password for authentication instead of sending none at all, which might lead to issues? so I chose the option that seemed safer to me, only changing the location where the broken usage is happening","commit_id":"d9054f017d4d1099dc472bc3c1887ab84eeacc42"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"d8b4858e99ed05ccb728c35eacf07c3bcf1584e9","unresolved":true,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    sushy_params \u003d {\u0027address\u0027: address,"},{"line_number":187,"context_line":"                    \u0027system_id\u0027: redfish_system_id,"},{"line_number":188,"context_line":"                    \u0027username\u0027: driver_info.get(\u0027redfish_username\u0027),"},{"line_number":189,"context_line":"                    \u0027password\u0027: driver_info.get(\u0027redfish_password\u0027),"},{"line_number":190,"context_line":"                    \u0027verify_ca\u0027: verify_ca,"},{"line_number":191,"context_line":"                    \u0027auth_type\u0027: auth_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"81a556cf_cb591fc7","line":188,"in_reply_to":"55bbf7ab_1b47f62a","updated":"2025-01-30 13:55:41.000000000","message":"I think the approach in the cache module seems reasonable instead of defaulting it generically.","commit_id":"d9054f017d4d1099dc472bc3c1887ab84eeacc42"}]}