)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e3a43048225dca70761f8ff7ae13e16737964189","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e858a2a8_430595e9","updated":"2025-02-04 14:38:56.000000000","message":"One item, otherwise LGTM","commit_id":"990b478ec0d96a0b40fe3e76ac1a8c028951f973"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"29f810578541a715b1752c7c770436d7c5ec4816","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4a383d40_7ccc941c","updated":"2025-02-04 08:10:06.000000000","message":"recheck - paramiko.ssh_exception.SSHException: No existing session","commit_id":"990b478ec0d96a0b40fe3e76ac1a8c028951f973"}],"ironic/drivers/modules/redfish/management.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"53d7f43cac792329a71a0bcca7442a2147188ebd","unresolved":true,"context_lines":[{"line_number":1174,"context_line":"            LOG.info(\"Defaulting to \u0027false\u0027. Secure boot request failed \""},{"line_number":1175,"context_line":"                     \"for node %(node)s: %(error)s\","},{"line_number":1176,"context_line":"                     {\u0027node\u0027: task.node.uuid, \u0027error\u0027: e})"},{"line_number":1177,"context_line":"            return False"},{"line_number":1178,"context_line":"        except sushy.exceptions.MissingAttributeError:"},{"line_number":1179,"context_line":"            raise exception.UnsupportedDriverExtension("},{"line_number":1180,"context_line":"                driver\u003dtask.node.driver, extension\u003d\u0027get_secure_boot_state\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"455c83e8_fbb043a1","line":1177,"updated":"2025-01-30 14:55:25.000000000","message":"I\u0027m not sure how this works internally, but in the case of the insufficient license, the call is repeated every couple of minutes or so, so I\u0027m wondering whether this is terminal enough or whether raising UnsupportedDriverExtension or even a dedicated InsufficientLicenseException would be better. but I admit that that would require being able to distinguish differen reasons for the AccessError, which may be non-trivial, too. if you think that the current patch should handle this fine, I can give it a test","commit_id":"a63e15ccf10d321cb6fe9638ecceaa3d4edb3fcd"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1da074fdc742617489e525afe193e1f990df6cb8","unresolved":true,"context_lines":[{"line_number":1174,"context_line":"            LOG.info(\"Defaulting to \u0027false\u0027. Secure boot request failed \""},{"line_number":1175,"context_line":"                     \"for node %(node)s: %(error)s\","},{"line_number":1176,"context_line":"                     {\u0027node\u0027: task.node.uuid, \u0027error\u0027: e})"},{"line_number":1177,"context_line":"            return False"},{"line_number":1178,"context_line":"        except sushy.exceptions.MissingAttributeError:"},{"line_number":1179,"context_line":"            raise exception.UnsupportedDriverExtension("},{"line_number":1180,"context_line":"                driver\u003dtask.node.driver, extension\u003d\u0027get_secure_boot_state\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"989c75ca_312a6aeb","line":1177,"in_reply_to":"455c83e8_fbb043a1","updated":"2025-01-30 19:46:42.000000000","message":"This is not idea to return False; basically you\u0027re saying \"I was able to successfully determine the secure boot status; secure boot is off\" by returning false here.\n\nMy only real thought is we can allow this to be manually set; e.g. node.driver_info.redfish_secure_boot_status_override\u003dFalse || True; then if that override is set just blindly use it instead of querying here.\n\nOther options would be to perhaps return a new exception class which is more gracefully handled by callers but I think this would technically be a change to the driver api itself which might not be ideal.","commit_id":"a63e15ccf10d321cb6fe9638ecceaa3d4edb3fcd"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1659265b3767e3256d66cc4a59834387aacfedb2","unresolved":true,"context_lines":[{"line_number":1175,"context_line":"                LOG.info(\"Defaulting to \u0027false\u0027. Secure boot status request \""},{"line_number":1176,"context_line":"                         \"through Redfish failed for node %(node)s: %(error)s\","},{"line_number":1177,"context_line":"                         {\u0027node\u0027: task.node.uuid, \u0027error\u0027: e})"},{"line_number":1178,"context_line":"                return False"},{"line_number":1179,"context_line":"            raise"},{"line_number":1180,"context_line":"        except sushy.exceptions.MissingAttributeError:"},{"line_number":1181,"context_line":"            raise exception.UnsupportedDriverExtension("}],"source_content_type":"text/x-python","patch_set":3,"id":"9eb3a38d_6f86248f","line":1178,"updated":"2025-01-30 23:03:38.000000000","message":"This still is telling a lie to the caller: it\u0027s saying \"secure boot is disabled\" when we don\u0027t know if it\u0027s enabled or disabled. I\u0027m not sure if this is a sane default... \n\nLooking at conductor utils, one place where this is called, secure_boot is set to None if the UnsupportedDriverExtension is thrown; perhaps we can just return None in this case? I haven\u0027t checked all callers...","commit_id":"145b64dc42f3253ec065cb9941883a9d57d356d9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e3a43048225dca70761f8ff7ae13e16737964189","unresolved":true,"context_lines":[{"line_number":1171,"context_line":"        try:"},{"line_number":1172,"context_line":"            return system.secure_boot.enabled"},{"line_number":1173,"context_line":"        except sushy.exceptions.AccessError as e:"},{"line_number":1174,"context_line":"            if \u0027OemLicenseNotPassed\u0027 in str(e):"},{"line_number":1175,"context_line":"                LOG.info(\"Secure boot status request through Redfish failed \""},{"line_number":1176,"context_line":"                         \"for node %(node)s: %(error)s\","},{"line_number":1177,"context_line":"                         {\u0027node\u0027: task.node.uuid, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73b6d_be87cca1","line":1174,"updated":"2025-02-04 14:38:56.000000000","message":"Lets add a note to explicitly record, just in the code, this is supermicro gear.","commit_id":"990b478ec0d96a0b40fe3e76ac1a8c028951f973"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"ad70bf914a7a9eb33be3916d6f10e3058ae48a22","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"        try:"},{"line_number":1172,"context_line":"            return system.secure_boot.enabled"},{"line_number":1173,"context_line":"        except sushy.exceptions.AccessError as e:"},{"line_number":1174,"context_line":"            if \u0027OemLicenseNotPassed\u0027 in str(e):"},{"line_number":1175,"context_line":"                LOG.info(\"Secure boot status request through Redfish failed \""},{"line_number":1176,"context_line":"                         \"for node %(node)s: %(error)s\","},{"line_number":1177,"context_line":"                         {\u0027node\u0027: task.node.uuid, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":4,"id":"bc07d8e3_38cb7ab1","line":1174,"in_reply_to":"5ff73b6d_be87cca1","updated":"2025-02-06 13:18:27.000000000","message":"Acknowledged","commit_id":"990b478ec0d96a0b40fe3e76ac1a8c028951f973"}]}