)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6ba81975168554e5fa527e7c8fc77fe3569a70de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dc10572f_9641061a","updated":"2025-01-31 14:16:29.000000000","message":"I like the idea of adding the feature, but I think the change to sort by ID seems wrong since the intent was always to provide entries in order of events, not by ID. The ID\u0027s really are just transitory for our data model anyhow since we auto-purge the entries by default.","commit_id":"d6a89eb4aa9f3e945d081bb223723b73df716344"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6ba81975168554e5fa527e7c8fc77fe3569a70de","unresolved":true,"context_lines":[{"line_number":2129,"context_line":"    @method.expose()"},{"line_number":2130,"context_line":"    @args.validate(detail\u003dargs.boolean, marker\u003dargs.uuid, limit\u003dargs.integer,"},{"line_number":2131,"context_line":"                   sort_key\u003dargs.string, sort_dir\u003dargs.string)"},{"line_number":2132,"context_line":"    def get_all(self, detail\u003dFalse, marker\u003dNone, limit\u003dNone, sort_key\u003d\u0027id\u0027,"},{"line_number":2133,"context_line":"                sort_dir\u003d\u0027asc\u0027):"},{"line_number":2134,"context_line":"        \"\"\"List node history.\"\"\""},{"line_number":2135,"context_line":"        node \u003d api_utils.check_node_policy_and_retrieve("}],"source_content_type":"text/x-python","patch_set":1,"id":"a44ff10c_20a88a44","line":2132,"range":{"start_line":2132,"start_character":61,"end_line":2132,"end_character":74},"updated":"2025-01-31 14:16:29.000000000","message":"I think this changes the behavior since the records should be returned in time sequence order, not by ID.","commit_id":"d6a89eb4aa9f3e945d081bb223723b73df716344"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"2ff05da4d894a992e3bb4a2d2fcd169d6e848ef6","unresolved":false,"context_lines":[{"line_number":2129,"context_line":"    @method.expose()"},{"line_number":2130,"context_line":"    @args.validate(detail\u003dargs.boolean, marker\u003dargs.uuid, limit\u003dargs.integer,"},{"line_number":2131,"context_line":"                   sort_key\u003dargs.string, sort_dir\u003dargs.string)"},{"line_number":2132,"context_line":"    def get_all(self, detail\u003dFalse, marker\u003dNone, limit\u003dNone, sort_key\u003d\u0027id\u0027,"},{"line_number":2133,"context_line":"                sort_dir\u003d\u0027asc\u0027):"},{"line_number":2134,"context_line":"        \"\"\"List node history.\"\"\""},{"line_number":2135,"context_line":"        node \u003d api_utils.check_node_policy_and_retrieve("}],"source_content_type":"text/x-python","patch_set":1,"id":"8852f111_2f50ab23","line":2132,"range":{"start_line":2132,"start_character":61,"end_line":2132,"end_character":74},"in_reply_to":"524bb068_77ed7b9c","updated":"2025-02-01 07:33:53.000000000","message":"Done","commit_id":"d6a89eb4aa9f3e945d081bb223723b73df716344"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"58895044917dab26713461071a29f4cc194bf26d","unresolved":false,"context_lines":[{"line_number":2129,"context_line":"    @method.expose()"},{"line_number":2130,"context_line":"    @args.validate(detail\u003dargs.boolean, marker\u003dargs.uuid, limit\u003dargs.integer,"},{"line_number":2131,"context_line":"                   sort_key\u003dargs.string, sort_dir\u003dargs.string)"},{"line_number":2132,"context_line":"    def get_all(self, detail\u003dFalse, marker\u003dNone, limit\u003dNone, sort_key\u003d\u0027id\u0027,"},{"line_number":2133,"context_line":"                sort_dir\u003d\u0027asc\u0027):"},{"line_number":2134,"context_line":"        \"\"\"List node history.\"\"\""},{"line_number":2135,"context_line":"        node \u003d api_utils.check_node_policy_and_retrieve("}],"source_content_type":"text/x-python","patch_set":1,"id":"ac51599c_553da973","line":2132,"range":{"start_line":2132,"start_character":61,"end_line":2132,"end_character":74},"in_reply_to":"8852f111_2f50ab23","updated":"2025-02-03 15:49:22.000000000","message":"Yeah, the DB navigates that rotation but the user data can\u0027t, but it could be jarring. Although, I suspect some may never notice unless they are forever holding the records which would be a bad idea.","commit_id":"d6a89eb4aa9f3e945d081bb223723b73df716344"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"15b303769905bc09257547c3b02df3853b2fac9e","unresolved":true,"context_lines":[{"line_number":2129,"context_line":"    @method.expose()"},{"line_number":2130,"context_line":"    @args.validate(detail\u003dargs.boolean, marker\u003dargs.uuid, limit\u003dargs.integer,"},{"line_number":2131,"context_line":"                   sort_key\u003dargs.string, sort_dir\u003dargs.string)"},{"line_number":2132,"context_line":"    def get_all(self, detail\u003dFalse, marker\u003dNone, limit\u003dNone, sort_key\u003d\u0027id\u0027,"},{"line_number":2133,"context_line":"                sort_dir\u003d\u0027asc\u0027):"},{"line_number":2134,"context_line":"        \"\"\"List node history.\"\"\""},{"line_number":2135,"context_line":"        node \u003d api_utils.check_node_policy_and_retrieve("}],"source_content_type":"text/x-python","patch_set":1,"id":"524bb068_77ed7b9c","line":2132,"range":{"start_line":2132,"start_character":61,"end_line":2132,"end_character":74},"in_reply_to":"a44ff10c_20a88a44","updated":"2025-01-31 15:23:32.000000000","message":"id is a primary key in an incremental way, so I guess the result is the same of ascending by created_at (if we don\u0027t consider the overflow, could it be? I am not sure)\nAnyway created_at is fine as a default key.","commit_id":"d6a89eb4aa9f3e945d081bb223723b73df716344"}]}
