)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"bc36e4435b8705fcd660422074a67da98c081f59","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5ce32ff7_6d37e44d","updated":"2025-02-10 19:46:10.000000000","message":"Curious to see if CI passes; I suspect we might need to ensure ipmi driver enablement is hooked up for ipmi tests.","commit_id":"d36a1ea2bbb544d5e2e23e7a8a362e22019103d5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"e2bc4c10fa99bb80291c1cffd2bd351b6b7bbf36","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2e408e4c_4500d9df","in_reply_to":"0d953f4e_c4670033","updated":"2025-02-11 16:44:06.000000000","message":"CI ran and passed in Zuul, that means you should be good as far as defaults and working CI.","commit_id":"d36a1ea2bbb544d5e2e23e7a8a362e22019103d5"},{"author":{"_account_id":37707,"name":"Satoshi Shirosaka","display_name":"Satoshi S.","email":"satoss1108@gmail.com","username":"satoshi-sh"},"change_message_id":"155ad8e10068c57635e609d4a71161b28d64ff5f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0d953f4e_c4670033","in_reply_to":"5ce32ff7_6d37e44d","updated":"2025-02-10 20:37:49.000000000","message":"Yes, it failed. If I want to run the CI test, do I need a VM with devstack installed? \n\nI just tried Testing your changes locally. I will spend some time reading the testing document to understand better.","commit_id":"d36a1ea2bbb544d5e2e23e7a8a362e22019103d5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d3acedfdde6e9b6661f85a6f9d881e5804621082","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"92c0d836_5b042c09","updated":"2025-02-12 15:03:39.000000000","message":"Overall, I\u0027m good with the change.\n\nMy concern: ipmitool is mentioned in our docs and has been historically framed as \"this is required\". I think it makes sense to scrub the docs and add appropriate notes and update any text which relates to ipmitool explicitly to call out it is no longer required.","commit_id":"1ef8c61812ed2ed95482147c5ea22d8f90cac853"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"25f996dc46d2402e039a441eeb6a7b1e6015ec86","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8f59269b_1c3d4a43","updated":"2025-02-14 21:29:45.000000000","message":"This may be a situation where the change isn\u0027t worth the friction (yet), but I\u0027m still in favor.","commit_id":"1ef8c61812ed2ed95482147c5ea22d8f90cac853"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b229f938841f0b54aa615d8a013a3a253f55ef65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"98302364_e41ab727","updated":"2025-02-13 13:47:36.000000000","message":"ipmi is still popular, and redfish is not feature alignment. As we require ipmitool to be available for the ipmi driver configured, instead of dropping from the list, why we don\u0027t do a check while loading drivers?","commit_id":"1ef8c61812ed2ed95482147c5ea22d8f90cac853"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e6276dd71e5c0a0d1b1989e2056a926eb67f49cc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"71c419d3_8fe27219","in_reply_to":"8f59269b_1c3d4a43","updated":"2025-02-17 17:38:23.000000000","message":"I\u0027m in favor as long as we appropriately guard and detail.","commit_id":"1ef8c61812ed2ed95482147c5ea22d8f90cac853"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"25f996dc46d2402e039a441eeb6a7b1e6015ec86","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c8517eee_a687425a","in_reply_to":"92c0d836_5b042c09","updated":"2025-02-14 21:29:45.000000000","message":"We need to also ensure this default-change doesn\u0027t invalidate any CI on ironic-adjacent projects, and that it doesn\u0027t break our devstack configs.","commit_id":"1ef8c61812ed2ed95482147c5ea22d8f90cac853"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"25f996dc46d2402e039a441eeb6a7b1e6015ec86","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b1cf1e22_fdab5858","in_reply_to":"98302364_e41ab727","updated":"2025-02-14 21:29:45.000000000","message":"So this is only changing default enabled drivers. Checking at load time in IPMI driver for ipmitool has a couple of issues, mainly around communicating the failure.\n\nYou can either:\n- completely crash the conductor and make it refuse to start\n- do not load the ipmi-based interfaces if ipmitool isn\u0027t there\n\nBoth cases are really not ideal.","commit_id":"1ef8c61812ed2ed95482147c5ea22d8f90cac853"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e6276dd71e5c0a0d1b1989e2056a926eb67f49cc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cb694925_27debdfa","in_reply_to":"b1cf1e22_fdab5858","updated":"2025-02-17 17:38:23.000000000","message":"The other issue which exists: Some of the drivers drivers also have casing where they will attempt to invoke ipmitool, which means a lack of ipmitool itself is a bigger problem for Ironic in general.","commit_id":"1ef8c61812ed2ed95482147c5ea22d8f90cac853"}]}