)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"4a2d3766c467a3d43dc9da4c5f639d3530fd7b11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"22d0cdcc_a35caa7c","updated":"2025-02-13 22:56:23.000000000","message":"I am working on a larger follow-up change to make the ilo/redfish drivers use the pxe_utils code as much as it can; but I made this as simple as possible for backporting.","commit_id":"437d7d1db85f73678f8b320559430eb35bebd78d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4606ea0d2e4f7dcd4da4c07969809b5af9bda867","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fda14382_3a055ea7","updated":"2025-07-07 16:32:29.000000000","message":"A few comments inline, I\u0027d be happy with a follow-up.","commit_id":"a786974621d4737543eb2713ac0060ad133d6a30"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c454f7f2ca8c5f5f666d602e2939e6b146b00595","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4f8a6746_d09ae4cf","updated":"2025-06-13 22:31:18.000000000","message":"I should take a look with a fresh brain to make sure I\u0027m not missing yet-another-helper that does this but a little different somewhere else 😐","commit_id":"a786974621d4737543eb2713ac0060ad133d6a30"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"542e3a0e92725167ed8fab52cef73ea91795f4f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1992940a_15e5b589","updated":"2025-06-17 19:20:55.000000000","message":"recheck failures are unrelated","commit_id":"a786974621d4737543eb2713ac0060ad133d6a30"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d6dc5aecc73904dc1ccac28b86ef280e8093c2ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5b6af5ce_110e30d0","updated":"2025-06-18 16:47:02.000000000","message":"recheck post_failures from yesterday\u0027s infra issue","commit_id":"a786974621d4737543eb2713ac0060ad133d6a30"}],"ironic/drivers/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4606ea0d2e4f7dcd4da4c07969809b5af9bda867","unresolved":true,"context_lines":[{"line_number":491,"context_line":"    if not kernel or not ramdisk:"},{"line_number":492,"context_line":"        if ramdisk or kernel:"},{"line_number":493,"context_line":"            solo \u003d \u0027unknown\u0027"},{"line_number":494,"context_line":"            missing \u003d \u0027unknown\u0027"},{"line_number":495,"context_line":"            if kernel:"},{"line_number":496,"context_line":"                solo \u003d kernel_name"},{"line_number":497,"context_line":"                missing \u003d ramdisk_name"}],"source_content_type":"text/x-python","patch_set":3,"id":"9bf1ce95_6c702376","line":494,"updated":"2025-07-07 16:32:29.000000000","message":"nit: these two values cannot be used","commit_id":"a786974621d4737543eb2713ac0060ad133d6a30"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4606ea0d2e4f7dcd4da4c07969809b5af9bda867","unresolved":true,"context_lines":[{"line_number":508,"context_line":"    return {kernel_name: kernel, ramdisk_name: ramdisk}"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"def _get_kernel_ramdisk_by_arch(node, mode\u003d\u0027deploy\u0027, deprecated_prefix\u003dNone):"},{"line_number":512,"context_line":"    kernel_name \u003d f\u0027{mode}_kernel\u0027"},{"line_number":513,"context_line":"    ramdisk_name \u003d f\u0027{mode}_ramdisk\u0027"},{"line_number":514,"context_line":"    kernel_dict_param_name \u003d f\u0027{mode}_kernel_by_arch\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"256b6193_066a53de","line":511,"updated":"2025-07-07 16:32:29.000000000","message":"deprecated_prefix is not used here","commit_id":"a786974621d4737543eb2713ac0060ad133d6a30"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4606ea0d2e4f7dcd4da4c07969809b5af9bda867","unresolved":true,"context_lines":[{"line_number":520,"context_line":"    ramdisk \u003d ramdisk_dict.get(cpu_arch) if cpu_arch else None"},{"line_number":521,"context_line":"    if not kernel or not ramdisk:"},{"line_number":522,"context_line":"        solo \u003d \u0027unknown\u0027"},{"line_number":523,"context_line":"        missing \u003d \u0027unknown\u0027"},{"line_number":524,"context_line":"        if ramdisk or kernel:"},{"line_number":525,"context_line":"            if kernel:"},{"line_number":526,"context_line":"                solo \u003d kernel_dict_param_name"}],"source_content_type":"text/x-python","patch_set":3,"id":"6ac3a207_d91dc849","line":523,"updated":"2025-07-07 16:32:29.000000000","message":"same","commit_id":"a786974621d4737543eb2713ac0060ad133d6a30"}],"ironic/tests/unit/command/test_conductor.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4606ea0d2e4f7dcd4da4c07969809b5af9bda867","unresolved":true,"context_lines":[{"line_number":74,"context_line":"                              {\u0027x86_64\u0027: \u0027rramdisk1\u0027},"},{"line_number":75,"context_line":"                              \u0027conductor\u0027)"},{"line_number":76,"context_line":"        conductor.warn_about_inconsistent_kernel_ramdisk(cfg.CONF)"},{"line_number":77,"context_line":"        self.assertFalse(log_mock.warning.called)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @mock.patch.object(conductor, \u0027LOG\u0027, autospec\u003dTrue)"},{"line_number":80,"context_line":"    def test_warn_about_inconsistent_kernel_ramdisk_kernel_only(self,"}],"source_content_type":"text/x-python","patch_set":3,"id":"26ba775c_264e0d39","line":77,"updated":"2025-07-07 16:32:29.000000000","message":"nit: assert_not_called() exists in all supported versions nowadays","commit_id":"a786974621d4737543eb2713ac0060ad133d6a30"}],"ironic/tests/unit/common/test_pxe_utils.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"85f4a6c30cdf69d87b477760adc960f6f18255cc","unresolved":true,"context_lines":[{"line_number":1375,"context_line":"    def test_parse_driver_info_mixed_source_rescue(self):"},{"line_number":1376,"context_line":"        self.config(rescue_kernel\u003d\u0027file:///image\u0027,"},{"line_number":1377,"context_line":"                    rescue_ramdisk\u003d\u0027file:///image\u0027,"},{"line_number":1378,"context_line":"                    group\u003d\u0027conductor\u0027)"},{"line_number":1379,"context_line":"        self._test_parse_driver_info_missing_ramdisk(mode\u003d\u0027rescue\u0027)"},{"line_number":1380,"context_line":""},{"line_number":1381,"context_line":"    @mock.patch.object(deploy_utils, \u0027get_boot_option\u0027, lambda node: \u0027ramdisk\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1e212284_8096419d","side":"PARENT","line":1378,"updated":"2025-02-13 23:00:40.000000000","message":"I\u0027m going to be honest, I\u0027m not sure why these ever passed before and how I broke them. I\u0027d like to understand before this merges.","commit_id":"814384f2cf5e7f70b797b5e08e73f4bc423b33fc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ef72f3c523f5bc1e3c029f72f5e3b566b8e9982d","unresolved":false,"context_lines":[{"line_number":1361,"context_line":"        self._test_parse_driver_info_from_conf(mode\u003d\u0027rescue\u0027, by_arch\u003dTrue)"},{"line_number":1362,"context_line":""},{"line_number":1363,"context_line":"    def test_parse_driver_info_mixed_source_deploy(self):"},{"line_number":1364,"context_line":"        self.config(deploy_kernel\u003d\u0027file:///image\u0027,"},{"line_number":1365,"context_line":"                    group\u003d\u0027conductor\u0027)"},{"line_number":1366,"context_line":"        self._test_parse_driver_info_missing_ramdisk()"},{"line_number":1367,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"cf2cbb14_ed6a3976","line":1364,"updated":"2025-03-13 16:29:44.000000000","message":"What these tests were verifying is the situation where you have a kernel in driver_info but ramdisk in ironic.conf. Back in the days, I made the decision to avoid such mix-and-match situations - see the comment you\u0027re deleting in pxe_utils. Your patch may be allowing it.","commit_id":"437d7d1db85f73678f8b320559430eb35bebd78d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d852f1d0c62f8ba6851073c9604508095dd00417","unresolved":true,"context_lines":[{"line_number":1361,"context_line":"        self._test_parse_driver_info_from_conf(mode\u003d\u0027rescue\u0027, by_arch\u003dTrue)"},{"line_number":1362,"context_line":""},{"line_number":1363,"context_line":"    def test_parse_driver_info_mixed_source_deploy(self):"},{"line_number":1364,"context_line":"        self.config(deploy_kernel\u003d\u0027file:///image\u0027,"},{"line_number":1365,"context_line":"                    group\u003d\u0027conductor\u0027)"},{"line_number":1366,"context_line":"        self._test_parse_driver_info_missing_ramdisk()"},{"line_number":1367,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e33b497c_e7578ccc","line":1364,"in_reply_to":"cf2cbb14_ed6a3976","updated":"2025-06-11 15:17:55.000000000","message":"ah, your comment in the driver_utils method claims to have implemented this with the same logic; but if you think these tests are failing because it\u0027s bugged, I\u0027ll have a look...","commit_id":"437d7d1db85f73678f8b320559430eb35bebd78d"}],"releasenotes/notes/consistent-ramdisk-configs-6a37ef69bf73cd2e.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4606ea0d2e4f7dcd4da4c07969809b5af9bda867","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    set this option to ``True``, but should first review their configurations"},{"line_number":36,"context_line":"    to ensure consistency across all node ``driver_info`` entries and"},{"line_number":37,"context_line":"    architecture-specific configuration options. Ironic expects to enable"},{"line_number":38,"context_line":"    strict validation of these values in a future release."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"42cc4ee8_6b397495","line":38,"updated":"2025-07-07 16:32:29.000000000","message":"I wonder if we want a deprecation note as well.","commit_id":"a786974621d4737543eb2713ac0060ad133d6a30"}]}