)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7e7e80d1e57b058ff6dee60754c4d1f771bffa26","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Ironic doesn\u0027t update local_link_connection when changed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With ironic-inspector merged with ironic, overwrite_existing is not"},{"line_number":10,"context_line":"feature aligned. If an introspected node changed switch port and"},{"line_number":11,"context_line":"trigger a re-introspection, the hook just bypassed the new information."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I63f5581b767747186d3a57964ac9db62c541af70"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc4aeae_6c5b8de8","line":10,"updated":"2025-03-13 16:36:25.000000000","message":"It was intention btw","commit_id":"5f61469bf413c68237d42c4cd3ffc8d42089d9d5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"34a462a31ab1b8a30aad9ae009833c0513fc5119","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"52191268_b780b0b3","updated":"2025-03-08 13:19:49.000000000","message":"recheck","commit_id":"5f61469bf413c68237d42c4cd3ffc8d42089d9d5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2cfbb7abb85f1cfc180858b5343c465951fb6187","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"902d48a6_97656a2d","updated":"2025-03-11 21:48:22.000000000","message":"recheck post_failure apache restart failure","commit_id":"5f61469bf413c68237d42c4cd3ffc8d42089d9d5"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"90dac298a573df1f45a37b6eaa9edf03afbcbbc4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e2c0534a_9c331490","updated":"2025-11-22 19:00:04.000000000","message":"so I think for us we would want to throw an error when this changes. so maybe this requires a toggle.","commit_id":"5f61469bf413c68237d42c4cd3ffc8d42089d9d5"}],"ironic/conf/inspector.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5e1696c1ef7410363ca3cd907f767c82b3903244","unresolved":true,"context_lines":[{"line_number":146,"context_line":"    cfg.BoolOpt(\u0027overwrite_existing\u0027,"},{"line_number":147,"context_line":"                default\u003dTrue,"},{"line_number":148,"context_line":"                help\u003d_(\u0027Whether to overwrite existing values in node \u0027"},{"line_number":149,"context_line":"                       \u0027database. Disable this option to make \u0027"},{"line_number":150,"context_line":"                       \u0027introspection a non-destructive operation.\u0027)),"},{"line_number":151,"context_line":"]"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8612e2ab_08ed2522","line":149,"range":{"start_line":149,"start_character":34,"end_line":149,"end_character":61},"updated":"2025-03-05 23:54:13.000000000","message":"perhaps:\n\nDisabling this option causes introspection operations to be non-destructive, meaning updates may not be identified or recorded.\n\n?","commit_id":"39a12b11b479cfb05898b50d2f637a6bdeda2a68"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"d6c63b8faff0fb819749994ad893ea3010777b94","unresolved":true,"context_lines":[{"line_number":146,"context_line":"    cfg.BoolOpt(\u0027overwrite_existing\u0027,"},{"line_number":147,"context_line":"                default\u003dTrue,"},{"line_number":148,"context_line":"                help\u003d_(\u0027Whether to overwrite existing values in node \u0027"},{"line_number":149,"context_line":"                       \u0027database. Disable this option to make \u0027"},{"line_number":150,"context_line":"                       \u0027introspection a non-destructive operation.\u0027)),"},{"line_number":151,"context_line":"]"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a602142_f2db3ad3","line":149,"range":{"start_line":149,"start_character":34,"end_line":149,"end_character":61},"in_reply_to":"8612e2ab_08ed2522","updated":"2025-03-06 14:07:55.000000000","message":"This piece is copied from ironic-inspector, update as commented :)","commit_id":"39a12b11b479cfb05898b50d2f637a6bdeda2a68"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7e7e80d1e57b058ff6dee60754c4d1f771bffa26","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                help\u003d_(\u0027Whether to overwrite existing values in node \u0027"},{"line_number":149,"context_line":"                       \u0027database. Disabling this option causes introspection \u0027"},{"line_number":150,"context_line":"                       \u0027operations to be non-destructive, meaning updates \u0027"},{"line_number":151,"context_line":"                       \u0027may not be identified or recorded.\u0027)),"},{"line_number":152,"context_line":"]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"discovery_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"6aed82f6_3993c541","line":151,"updated":"2025-03-13 16:36:25.000000000","message":"This is not true for the migrated feature: you only apply it to local_link_connection. It should be named and described accordingly.\n\nUnfortunately, I don\u0027t remember why we used to skip the local_link_connection fields. Do we have any reasons to not just overwrite them by default?","commit_id":"5f61469bf413c68237d42c4cd3ffc8d42089d9d5"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"904c9500ba4720367e0a29e934130197c41be594","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                help\u003d_(\u0027Whether to overwrite existing values in node \u0027"},{"line_number":149,"context_line":"                       \u0027database. Disabling this option causes introspection \u0027"},{"line_number":150,"context_line":"                       \u0027operations to be non-destructive, meaning updates \u0027"},{"line_number":151,"context_line":"                       \u0027may not be identified or recorded.\u0027)),"},{"line_number":152,"context_line":"]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"discovery_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"1d4680e3_72e81093","line":151,"in_reply_to":"6aed82f6_3993c541","updated":"2025-03-14 12:58:42.000000000","message":"Well, after some git digging, it seems like a historical reason and revised soon:\noriginally false by default: https://review.opendev.org/c/openstack/ironic-inspector/+/143124\nchanged to true: then https://review.opendev.org/c/openstack/ironic-inspector/+/162160\nIn theory it should be true by default as i understand it, except any reason beyond my knowledge, that\u0027s why the patch change the behavior without backwards compatibility.\n\nOriginally there were three plugins affected by this configuration option: local link connection, physical network, local_gb, and it seems that only local_link_connection lost the default behavior after migration. So probably there is no need to introduce migrate the configuration option, thoughts?","commit_id":"5f61469bf413c68237d42c4cd3ffc8d42089d9d5"}],"releasenotes/notes/local-link-connection-overwrite-717c5ddb19e917be.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"86e619f10a5690bb76bc2057813d834131932bf8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Fixes the issue that if port\u0027s local link connection changed, ironic"},{"line_number":5,"context_line":"    does not update the connection information after introspection. This"},{"line_number":6,"context_line":"    behavior can be changed by configuring ``[inspector]overwrite_existing``"},{"line_number":7,"context_line":"    which is aligned with ironic-inspector."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"265c062f_3e3e0b60","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":43},"updated":"2025-03-05 23:55:35.000000000","message":"I think this should be re-phrased. Perhaps something indicating \"to align with the prior behavior of the legacy ironic-inspector service.\" ?","commit_id":"39a12b11b479cfb05898b50d2f637a6bdeda2a68"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"d6c63b8faff0fb819749994ad893ea3010777b94","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Fixes the issue that if port\u0027s local link connection changed, ironic"},{"line_number":5,"context_line":"    does not update the connection information after introspection. This"},{"line_number":6,"context_line":"    behavior can be changed by configuring ``[inspector]overwrite_existing``"},{"line_number":7,"context_line":"    which is aligned with ironic-inspector."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"037434c9_4bcece4f","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":43},"in_reply_to":"265c062f_3e3e0b60","updated":"2025-03-06 14:07:55.000000000","message":"Done","commit_id":"39a12b11b479cfb05898b50d2f637a6bdeda2a68"}]}