)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8e137e2dd1573d96e372e6d026325c617d035035","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"51083362_b0388699","updated":"2025-05-29 13:08:20.000000000","message":"recheck odd failure","commit_id":"1c5f7e66e3deaf22d42ac8560f1a1c488201266c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"42f4dcc174bbab1675bace308d11296734c37455","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b3505cd2_f9e16ded","updated":"2025-06-02 13:11:44.000000000","message":"recheck metal3 job appears to have had an internal timeout -- no usable logs aside from job console which shows no real detail.","commit_id":"65c0f2727f914286c1a6cf319e739d4ef6165594"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5fc2cd6392a7696fc2662c809cddef7cef35cab6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a69672b2_5abb1dc9","updated":"2025-06-10 18:37:07.000000000","message":"recheck sushy-tools failure?!?","commit_id":"6fbe630c8a36a238272a07d22b927216484bdc52"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"29750cf72bfacee8d5e097adaac4d152f33a1303","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c0de8758_0c36d21f","updated":"2025-06-12 16:59:51.000000000","message":"Reapplying approvals after a trivial rebase.","commit_id":"c33f12329cd273b88817abdcc015114f5b7b97da"}],"ironic/conductor/configdrive_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e32be0cc76b94fab032dd2eed36be8c85ff6b1f9","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            and (len(network_data.get(\u0027services\u0027, [])) \u003d\u003d 0)):"},{"line_number":55,"context_line":"            return True"},{"line_number":56,"context_line":"        if not CONF.conductor.disable_metadata_mtu_check:"},{"line_number":57,"context_line":"            for link in network_data.get(\u0027links\u0027, []):"},{"line_number":58,"context_line":"                if link.get(\u0027mtu\u0027) is None:"},{"line_number":59,"context_line":"                    return True"},{"line_number":60,"context_line":"    except AttributeError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"f689cc9d_684ce792","line":57,"updated":"2025-06-05 15:59:35.000000000","message":"I should add a note, but I\u0027ll do it in follow-up at this point unless I need to revise:\n\nThe *schema* permits this to be null. The reality is clouds are largely designed around DHCP and that does tend to almost always includes MTU. The issue with Ironic and baremetal is *often* folks are not using dhcp OR have constrained MTUs in the integrated context, and we realistically need to at least convey/signal that constraint across in case the MTU is 1430 in the networking fabric, because depending on the network architecture (which can be an unknown), packets may end up getting dropped which is a bad user experience when the default link mtu might end up as 1500 for the baremetal node.","commit_id":"65c0f2727f914286c1a6cf319e739d4ef6165594"}],"ironic/conductor/utils.py":[{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"67b03c3f3a58e5aa0ab2b26d657f9358dd8f28ac","unresolved":true,"context_lines":[{"line_number":1226,"context_line":"    \"\"\""},{"line_number":1227,"context_line":"    invalid_meta \u003d False"},{"line_number":1228,"context_line":"    # By default, assume supplied metadata is not invalid."},{"line_number":1229,"context_line":"    try:"},{"line_number":1230,"context_line":"        # FIXME(TheJulia): Another possible issue is Nova can send"},{"line_number":1231,"context_line":"        # the MTU on links as \"null\" values. That seems super problematic"},{"line_number":1232,"context_line":"        # for jumbo frame users or constrained environments. We should"}],"source_content_type":"text/x-python","patch_set":3,"id":"dd1020f4_7f9bae98","line":1229,"range":{"start_line":1229,"start_character":0,"end_line":1229,"end_character":8},"updated":"2025-05-19 13:48:03.000000000","message":"nit: We can return at the first moment invalid_meta becomes true, including in the loop.","commit_id":"55fe6fb826b951e2aba049404ef2bb8e4961cdb4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4c569861bcc83c1d1d480f8d9fc88623d60dc593","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"    \"\"\""},{"line_number":1227,"context_line":"    invalid_meta \u003d False"},{"line_number":1228,"context_line":"    # By default, assume supplied metadata is not invalid."},{"line_number":1229,"context_line":"    try:"},{"line_number":1230,"context_line":"        # FIXME(TheJulia): Another possible issue is Nova can send"},{"line_number":1231,"context_line":"        # the MTU on links as \"null\" values. That seems super problematic"},{"line_number":1232,"context_line":"        # for jumbo frame users or constrained environments. We should"}],"source_content_type":"text/x-python","patch_set":3,"id":"fb9c7e48_a9c31873","line":1229,"range":{"start_line":1229,"start_character":0,"end_line":1229,"end_character":8},"in_reply_to":"dd1020f4_7f9bae98","updated":"2025-05-28 17:49:30.000000000","message":"Done","commit_id":"55fe6fb826b951e2aba049404ef2bb8e4961cdb4"}],"ironic/conf/conductor.py":[{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"00e938615786e40390d57331fb4b7358b877482f","unresolved":true,"context_lines":[{"line_number":557,"context_line":"                       \u0027this option to True will disable this \u0027"},{"line_number":558,"context_line":"                       \u0027functionality.\u0027)),"},{"line_number":559,"context_line":"    cfg.BoolOpt(\u0027disable_metadata_mtu_check\u0027,"},{"line_number":560,"context_line":"                default\u003dFalse,"},{"line_number":561,"context_line":"                mutable\u003dTrue,"},{"line_number":562,"context_line":"                help\u003d_(\u0027Option to disable consideration of supplied \u0027"},{"line_number":563,"context_line":"                       \u0027network_data.json link MTU values as basis to \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"6f1b150d_b59c6097","line":560,"range":{"start_line":560,"start_character":0,"end_line":560,"end_character":30},"updated":"2025-05-30 15:13:21.000000000","message":"Unless I\u0027m misunderstanding it, this default still reads `False`.","commit_id":"65c0f2727f914286c1a6cf319e739d4ef6165594"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"9dd0f37b2120429bfdda1fa95a3ffd6512f62006","unresolved":true,"context_lines":[{"line_number":557,"context_line":"                       \u0027this option to True will disable this \u0027"},{"line_number":558,"context_line":"                       \u0027functionality.\u0027)),"},{"line_number":559,"context_line":"    cfg.BoolOpt(\u0027disable_metadata_mtu_check\u0027,"},{"line_number":560,"context_line":"                default\u003dFalse,"},{"line_number":561,"context_line":"                mutable\u003dTrue,"},{"line_number":562,"context_line":"                help\u003d_(\u0027Option to disable consideration of supplied \u0027"},{"line_number":563,"context_line":"                       \u0027network_data.json link MTU values as basis to \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1eeedb7a_3aad494d","line":560,"range":{"start_line":560,"start_character":0,"end_line":560,"end_character":30},"in_reply_to":"4283b2e7_468aa640","updated":"2025-05-30 15:37:04.000000000","message":"++","commit_id":"65c0f2727f914286c1a6cf319e739d4ef6165594"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"eae93c80adb71d53540cbd0568355a944858f0d7","unresolved":true,"context_lines":[{"line_number":557,"context_line":"                       \u0027this option to True will disable this \u0027"},{"line_number":558,"context_line":"                       \u0027functionality.\u0027)),"},{"line_number":559,"context_line":"    cfg.BoolOpt(\u0027disable_metadata_mtu_check\u0027,"},{"line_number":560,"context_line":"                default\u003dFalse,"},{"line_number":561,"context_line":"                mutable\u003dTrue,"},{"line_number":562,"context_line":"                help\u003d_(\u0027Option to disable consideration of supplied \u0027"},{"line_number":563,"context_line":"                       \u0027network_data.json link MTU values as basis to \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"4283b2e7_468aa640","line":560,"range":{"start_line":560,"start_character":0,"end_line":560,"end_character":30},"in_reply_to":"6f1b150d_b59c6097","updated":"2025-05-30 15:34:47.000000000","message":"I think it all looks right to me? When set to true, we disable the mtu check -- if you need to succeed even with MTUs missing, you need to disable the check by setting this to true.","commit_id":"65c0f2727f914286c1a6cf319e739d4ef6165594"}],"releasenotes/notes/consider-null-mtu-invalid-7fb35b7e85c8fc74.yaml":[{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"67b03c3f3a58e5aa0ab2b26d657f9358dd8f28ac","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue where a \"null\" or missing MTU value for network_data.json"},{"line_number":5,"context_line":"    payloads in configuration drives forces a regeneration of the configuration"},{"line_number":6,"context_line":"    drive. This option is enabled by default, and can be disabled by using the"},{"line_number":7,"context_line":"    ``[conductor]disable_metadata_mtu_check`` configuration option."},{"line_number":8,"context_line":"    For more information, see"},{"line_number":9,"context_line":"    `bug 2110322 \u003chttps://bugs.launchpad.net/ironic/+bug/2110322\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e7011ece_ccc63f86","line":6,"range":{"start_line":6,"start_character":11,"end_line":6,"end_character":44},"updated":"2025-05-19 13:48:03.000000000","message":"The default for the config seems to be `False`","commit_id":"55fe6fb826b951e2aba049404ef2bb8e4961cdb4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5108d9c8dc09d88cea82fba94c732f937d02e61e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue where a \"null\" or missing MTU value for network_data.json"},{"line_number":5,"context_line":"    payloads in configuration drives forces a regeneration of the configuration"},{"line_number":6,"context_line":"    drive. This option is enabled by default, and can be disabled by using the"},{"line_number":7,"context_line":"    ``[conductor]disable_metadata_mtu_check`` configuration option."},{"line_number":8,"context_line":"    For more information, see"},{"line_number":9,"context_line":"    `bug 2110322 \u003chttps://bugs.launchpad.net/ironic/+bug/2110322\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0180a146_7b189128","line":6,"range":{"start_line":6,"start_character":11,"end_line":6,"end_character":44},"in_reply_to":"e7011ece_ccc63f86","updated":"2025-05-30 15:07:14.000000000","message":"Done","commit_id":"55fe6fb826b951e2aba049404ef2bb8e4961cdb4"}]}