)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ae9e9a0166aebdb48c5f26fb6df59f25ae5ab379","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1b5dbaec_e2c7dc73","updated":"2025-05-13 21:04:41.000000000","message":"Do we know if this is breaky for separate-inspector installations? We still have to keep those working for another release, right?","commit_id":"f9ae1b001b75859e1228b48ce422cac0edc7ac50"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"64b4b1aba2fc3f240c715aeee50d4cf55a5b3fff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"29d4f9f7_81634aa3","in_reply_to":"1b5dbaec_e2c7dc73","updated":"2025-05-19 23:53:29.000000000","message":"Erm. So, it seems maybe breaking compatibility here: `/v1/continue_inspection` vs `/v1/continue`. \n\nI think all we actually need to do is to override the base URL alone, Ironic and Inspector both already handle appending the path component internally, it seems.\n\nFWIW: Ironic also supports both /v1/continue and a newer /v1/continue_inspection endpoint.\n\nHmmm","commit_id":"f9ae1b001b75859e1228b48ce422cac0edc7ac50"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"810003f98c15eb38eddd6ce57eec11a9a9783afc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c65f14d8_45cbb74a","updated":"2025-10-09 09:21:43.000000000","message":"recheck","commit_id":"dac926c02df263defc7ca06ace79d40afa04d471"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f6557d86e792bfe38485e99739c38401b8d6537a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cca3249d_c5cffb8f","updated":"2025-10-09 14:29:03.000000000","message":"recheck node failure!","commit_id":"dac926c02df263defc7ca06ace79d40afa04d471"}],"ironic/drivers/modules/image_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1641962bcb01e3d23a2c08c3499ea402c92c8062","unresolved":true,"context_lines":[{"line_number":189,"context_line":"    override_callback_url \u003d CONF.deploy.external_callback_url.rstrip(\u0027/\u0027)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    params[deploy_utils.IPA_URL_PARAM_NAME] \u003d override_callback_url"},{"line_number":192,"context_line":"    params[\u0027ipa-inspection-callback-url\u0027] \u003d override_callback_url"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    return params"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"64b4ee3f_29210073","line":192,"updated":"2025-05-28 09:57:33.000000000","message":"This is not a full callback URL, see https://opendev.org/openstack/ironic/src/branch/master/ironic/drivers/modules/inspector/agent.py#L50-L54","commit_id":"2452969fe1315fdca0a097eb7a2ebb18606d6c63"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8bbbcbf7c7c55754757662f24b973106f74b2379","unresolved":true,"context_lines":[{"line_number":189,"context_line":"    override_callback_url \u003d CONF.deploy.external_callback_url.rstrip(\u0027/\u0027)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    params[deploy_utils.IPA_URL_PARAM_NAME] \u003d override_callback_url"},{"line_number":192,"context_line":"    params[\u0027ipa-inspection-callback-url\u0027] \u003d override_callback_url"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    return params"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"6d0be0fa_60dbceef","line":192,"in_reply_to":"64b4ee3f_29210073","updated":"2025-10-08 16:31:28.000000000","message":"In fact, since https://opendev.org/openstack/ironic-python-agent/commit/6cd36a750f27d65a3f24a47fff0ebde9e21b57f6 you can just remove this callback URL. But maybe it will become less backportable.. So probably better to take the URL from params and update its host.","commit_id":"2452969fe1315fdca0a097eb7a2ebb18606d6c63"}]}
