)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b3fa2d5be004edef71002c84c864063176526271","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"90977631_23a5179d","updated":"2025-05-13 21:00:16.000000000","message":"I\u0027ll note: this is overall better, but we\u0027ll have to do a second pass later to remove time.sleep(0) once eventlet is removed.","commit_id":"312451ced20930443c4dee09a957fdbbbdc6bb1e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"01c3fc80c53223c1e1c1cf4419a1a67b23fff4e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dcf4f310_719f4e01","in_reply_to":"90977631_23a5179d","updated":"2025-05-20 13:43:12.000000000","message":"Absolutely! Each sleep will need to be evaluated and be removed. Keeping it as-is otherwise *does* also keep us from changing the overall behavior vefire we work on removing eventlet.","commit_id":"312451ced20930443c4dee09a957fdbbbdc6bb1e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"4ff5243f03e950d38dbece409566c13b0768a039","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e597dd77_51f25130","updated":"2025-05-22 20:58:03.000000000","message":"LGTM I\u0027m approving since Jay is also ok with the current approach \u003d)","commit_id":"5731f4fafcfc4cf19c46d70e2571205e650ece52"}],"ironic/drivers/modules/redfish/power.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b3fa2d5be004edef71002c84c864063176526271","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def _sleep_helper(seconds):"},{"line_number":55,"context_line":"    \"\"\"A wrapper around time.sleep to enable cleaner unit tests.\"\"\""},{"line_number":56,"context_line":"    time.sleep(seconds)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def _set_power_state(task, system, power_state, timeout\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"edd105e3_63015612","line":56,"updated":"2025-05-13 21:00:16.000000000","message":"Curious why we were able to mock time directly in other modules but not here","commit_id":"312451ced20930443c4dee09a957fdbbbdc6bb1e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ec64dbb20102d1ff8fb2f479fba06c2bf9190f05","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def _sleep_helper(seconds):"},{"line_number":55,"context_line":"    \"\"\"A wrapper around time.sleep to enable cleaner unit tests.\"\"\""},{"line_number":56,"context_line":"    time.sleep(seconds)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def _set_power_state(task, system, power_state, timeout\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"4e9e5026_04416e16","line":56,"in_reply_to":"edd105e3_63015612","updated":"2025-05-13 22:17:46.000000000","message":"So, this largely was a result of me trying to figure out why it was taking so long. We can likely nuke it form orbit.\n\nThis is a pattern you want to take if you want to evaluate the number of times it is called, but not for time.sleep directly. I\u0027ll drop it in a next revision.","commit_id":"312451ced20930443c4dee09a957fdbbbdc6bb1e"}]}
