)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cd970fbaf93d86c95e6705337e41b87aaa677646","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Syed Haseeb Ahmed \u003csyedhaseebahmed12@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-05-28 11:19:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This patch adds a condition [inspector]update_pxe_enabled"},{"line_number":8,"context_line":"to control whether to perform updates to pxe_enabled field of Port"},{"line_number":9,"context_line":"while performing inspection, defaults to True"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b9bad8ed_6f8d8108","line":7,"updated":"2025-05-28 14:10:41.000000000","message":"Please wrap your commit subject at ~50-60 characters, and then have a separate paragraph to explain why.","commit_id":"8119d92dd7c043fd4d816427e3f3180721cd3d57"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7a6c5c451eb8ca18c6968ef3f982042727d33d73","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Syed Haseeb Ahmed \u003csyedhaseebahmed12@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-05-28 11:19:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This patch adds a condition [inspector]update_pxe_enabled"},{"line_number":8,"context_line":"to control whether to perform updates to pxe_enabled field of Port"},{"line_number":9,"context_line":"while performing inspection, defaults to True"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d705541e_a331d1bc","line":7,"in_reply_to":"b9bad8ed_6f8d8108","updated":"2025-05-28 15:30:32.000000000","message":"++ https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure has more information than you could ever want on how we structure commits; although Julia has hit the primary point :D","commit_id":"8119d92dd7c043fd4d816427e3f3180721cd3d57"},{"author":{"_account_id":36720,"name":"Syed Haseeb Ahmed","display_name":"haseeb","email":"syedhaseebahmed12@gmail.com","username":"haseeb"},"change_message_id":"1469799dc7af6b71b83f5597de33b1197fa3ce39","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Syed Haseeb Ahmed \u003csyedhaseebahmed12@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-05-28 11:19:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This patch adds a condition [inspector]update_pxe_enabled"},{"line_number":8,"context_line":"to control whether to perform updates to pxe_enabled field of Port"},{"line_number":9,"context_line":"while performing inspection, defaults to True"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a2d797cb_22a69d9b","line":7,"in_reply_to":"d705541e_a331d1bc","updated":"2025-05-30 11:20:07.000000000","message":"Done","commit_id":"8119d92dd7c043fd4d816427e3f3180721cd3d57"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cd970fbaf93d86c95e6705337e41b87aaa677646","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f884eb4_5f76f27b","updated":"2025-05-28 14:10:41.000000000","message":"Also, please consider adding a release note. See: https://docs.openstack.org/reno/latest/","commit_id":"8119d92dd7c043fd4d816427e3f3180721cd3d57"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7a6c5c451eb8ca18c6968ef3f982042727d33d73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"240a6031_505c760a","updated":"2025-05-28 15:30:32.000000000","message":"Please also address the other comment about adding a unit test. Thanks!","commit_id":"917122faaeaedc8efe769e6b4fb19faed5583900"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2f857ff691969bdd53cf69c88804467ca47bdbce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"aaa2272e_c9db49ff","updated":"2025-05-30 15:12:05.000000000","message":"LGTM, Thanks!","commit_id":"5a9efa070cf7fae80cd53c506e3b370a55b4a501"}],"ironic/drivers/modules/redfish/inspect.py":[{"author":{"_account_id":36720,"name":"Syed Haseeb Ahmed","display_name":"haseeb","email":"syedhaseebahmed12@gmail.com","username":"haseeb"},"change_message_id":"1469799dc7af6b71b83f5597de33b1197fa3ce39","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from ironic.drivers.modules.redfish import utils as redfish_utils"},{"line_number":28,"context_line":"from ironic.drivers import utils as drivers_utils"},{"line_number":29,"context_line":"from ironic import objects"},{"line_number":30,"context_line":"from ironic.conf import CONF"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a9bdc8f_ed2fa6ca","line":30,"in_reply_to":"1c2e26d4_c0d00226","updated":"2025-05-30 11:20:07.000000000","message":"Done","commit_id":"8119d92dd7c043fd4d816427e3f3180721cd3d57"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cd970fbaf93d86c95e6705337e41b87aaa677646","unresolved":true,"context_lines":[{"line_number":27,"context_line":"from ironic.drivers.modules.redfish import utils as redfish_utils"},{"line_number":28,"context_line":"from ironic.drivers import utils as drivers_utils"},{"line_number":29,"context_line":"from ironic import objects"},{"line_number":30,"context_line":"from ironic.conf import CONF"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1c2e26d4_c0d00226","line":30,"in_reply_to":"2f86d0a5_298f4d60","updated":"2025-05-28 14:10:41.000000000","message":"\u003e pep8: H306: imports not in alphabetical order (ironic.objects, ironic.conf.conf)\n\nPlease fix.","commit_id":"8119d92dd7c043fd4d816427e3f3180721cd3d57"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cd970fbaf93d86c95e6705337e41b87aaa677646","unresolved":true,"context_lines":[{"line_number":184,"context_line":"        if pxe_port_macs is None:"},{"line_number":185,"context_line":"            LOG.warning(\"No PXE enabled NIC was found for node \""},{"line_number":186,"context_line":"                        \"%(node_uuid)s.\", {\u0027node_uuid\u0027: task.node.uuid})"},{"line_number":187,"context_line":"        elif CONF.inspector.update_pxe_enabled:"},{"line_number":188,"context_line":"            pxe_port_macs \u003d [macs.lower() for macs in pxe_port_macs]"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"            ports \u003d objects.Port.list_by_node_id(task.context, task.node.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0978b5ee_d9a574fe","line":187,"updated":"2025-05-28 14:10:41.000000000","message":"Greetings, please add a unit test for this option being toggled.","commit_id":"8119d92dd7c043fd4d816427e3f3180721cd3d57"},{"author":{"_account_id":36720,"name":"Syed Haseeb Ahmed","display_name":"haseeb","email":"syedhaseebahmed12@gmail.com","username":"haseeb"},"change_message_id":"1469799dc7af6b71b83f5597de33b1197fa3ce39","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        if pxe_port_macs is None:"},{"line_number":185,"context_line":"            LOG.warning(\"No PXE enabled NIC was found for node \""},{"line_number":186,"context_line":"                        \"%(node_uuid)s.\", {\u0027node_uuid\u0027: task.node.uuid})"},{"line_number":187,"context_line":"        elif CONF.inspector.update_pxe_enabled:"},{"line_number":188,"context_line":"            pxe_port_macs \u003d [macs.lower() for macs in pxe_port_macs]"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"            ports \u003d objects.Port.list_by_node_id(task.context, task.node.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"42157198_a177c3f9","line":187,"in_reply_to":"0978b5ee_d9a574fe","updated":"2025-05-30 11:20:07.000000000","message":"Done","commit_id":"8119d92dd7c043fd4d816427e3f3180721cd3d57"}],"ironic/tests/unit/drivers/modules/redfish/test_inspect.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2f857ff691969bdd53cf69c88804467ca47bdbce","unresolved":true,"context_lines":[{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":506,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":507,"context_line":"            task.driver.inspect._get_pxe_port_macs \u003d mock.Mock()"},{"line_number":508,"context_line":"            task.driver.inspect._get_pxe_port_macs.return_value \u003d \\"},{"line_number":509,"context_line":"                [\u002724:6E:96:70:49:00\u0027]"},{"line_number":510,"context_line":"            task.driver.inspect.inspect_hardware(task)"},{"line_number":511,"context_line":"            port \u003d mock_list_by_node_id.return_value"},{"line_number":512,"context_line":"            self.assertTrue(port[0].pxe_enabled)"}],"source_content_type":"text/x-python","patch_set":7,"id":"43a21d5b_25813800","line":509,"range":{"start_line":507,"start_character":54,"end_line":509,"end_character":37},"updated":"2025-05-30 15:12:05.000000000","message":"Not quite a typical pattern we take, but it works.","commit_id":"5a9efa070cf7fae80cd53c506e3b370a55b4a501"}]}