)]}'
{"ironic/drivers/modules/image_cache.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1c7439d0f33ed2bb3a474123d078d1d470858d3e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        if self._master_dir is None:"},{"line_number":79,"context_line":"            #NOTE(ghe): We don\u0027t share images between instances/hosts"},{"line_number":80,"context_line":"            if not CONF.parallel_image_downloads:"},{"line_number":81,"context_line":"                with lockutils.lock(\u0027download-image\u0027, \u0027ironic-\u0027):"},{"line_number":82,"context_line":"                    images.fetch_to_raw(ctx, uuid, dest_path,"},{"line_number":83,"context_line":"                                        self._image_service)"},{"line_number":84,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5adbc538_24d718c3","line":81,"updated":"2014-05-26 18:48:47.000000000","message":"lock name is a const string here, and it\u0027s duplicated on L94.\n\nI\u0027d rather see the constant string assigned to a variable only once, before its first use.","commit_id":"92c6dfaebc708a6f254ea543365675dcef410323"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"184fee999c1a21c77b7fef24c200a4558255cf88","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        master_path \u003d os.path.join(self._master_dir, master_file_name)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        img_download_lock_name \u003d \u0027download-image\u0027"},{"line_number":95,"context_line":"        if CONF.parallel_image_downloads:"},{"line_number":96,"context_line":"            img_download_lock_name \u003d \u0027download-image:%s\u0027 % master_file_name"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        # TODO(dtantsur): lock expiration time"}],"source_content_type":"text/x-python","patch_set":2,"id":"5adbc538_77b63d3f","line":95,"updated":"2014-05-26 12:02:13.000000000","message":"I think if-else syntax will be better here for readability.","commit_id":"92c6dfaebc708a6f254ea543365675dcef410323"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1c7439d0f33ed2bb3a474123d078d1d470858d3e","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        img_download_lock_name \u003d \u0027download-image\u0027"},{"line_number":95,"context_line":"        if CONF.parallel_image_downloads:"},{"line_number":96,"context_line":"            img_download_lock_name \u003d \u0027download-image:%s\u0027 % master_file_name"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        # TODO(dtantsur): lock expiration time"},{"line_number":99,"context_line":"        with lockutils.lock(img_download_lock_name, \u0027ironic-\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5adbc538_44db44ed","line":96,"updated":"2014-05-26 18:48:47.000000000","message":"I have no objection to the readability of the current code, but moving the definition of img_download_lock_name to eg. L78 would be better, IMO.","commit_id":"92c6dfaebc708a6f254ea543365675dcef410323"}]}