)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"bba6b6d1cb941c79555394e2cff45ca4075311bf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1873732c_9e7132f7","updated":"2025-07-03 03:00:41.000000000","message":"It seems that in limited locations in Ironics codebase, created_at and updated_at are not actually required fields for response.\n\nWhat it the correct course of action from here?","commit_id":"0fd304dc56ded9238c65d3c0ed398da95355d43c"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"b10c493fe0696d5d291024fa67ccadc177c149a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"06772dc3_4927a76b","in_reply_to":"1873732c_9e7132f7","updated":"2025-07-09 02:14:47.000000000","message":"Done","commit_id":"0fd304dc56ded9238c65d3c0ed398da95355d43c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eabcb712292b63af412a7dce422e35fd865c9036","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0aee47e7_fcc3160f","updated":"2025-07-21 15:47:16.000000000","message":"I wonder if it\u0027s actually a bug..","commit_id":"259cc23316e2b96b27a105cb709602e4eb588326"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"3c1cbfda2e957149692db6d6735ffef89b11bb1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cc2459b7_79612c30","updated":"2025-07-09 17:39:19.000000000","message":"recheck - tests fails look unrelated to my changes","commit_id":"259cc23316e2b96b27a105cb709602e4eb588326"}],"ironic/api/schemas/v1/firmware.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f73425e9573d9d01e1ee696b0821e8ea6df23658","unresolved":true,"context_lines":[{"line_number":47,"context_line":"        \u0027created_at\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027date-time\u0027},"},{"line_number":48,"context_line":"        \u0027updated_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027], \u0027format\u0027: \u0027date-time\u0027},"},{"line_number":49,"context_line":"    },"},{"line_number":50,"context_line":"    \u0027required\u0027: [\u0027created_at\u0027, \u0027updated_at\u0027],"},{"line_number":51,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":52,"context_line":"}"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e0088fd2_744778e3","line":50,"updated":"2025-07-03 12:14:51.000000000","message":"Could we get an updated note here indicating that these are always returned, regardless of the value of the \u0027fields\u0027 parameter?","commit_id":"0fd304dc56ded9238c65d3c0ed398da95355d43c"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"b10c493fe0696d5d291024fa67ccadc177c149a2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \u0027created_at\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027date-time\u0027},"},{"line_number":48,"context_line":"        \u0027updated_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027], \u0027format\u0027: \u0027date-time\u0027},"},{"line_number":49,"context_line":"    },"},{"line_number":50,"context_line":"    \u0027required\u0027: [\u0027created_at\u0027, \u0027updated_at\u0027],"},{"line_number":51,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":52,"context_line":"}"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f629d37_e5a1ef8d","line":50,"in_reply_to":"e0088fd2_744778e3","updated":"2025-07-09 02:14:47.000000000","message":"Done","commit_id":"0fd304dc56ded9238c65d3c0ed398da95355d43c"}],"ironic/api/schemas/v1/shard.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f73425e9573d9d01e1ee696b0821e8ea6df23658","unresolved":true,"context_lines":[{"line_number":34,"context_line":"            },"},{"line_number":35,"context_line":"        },"},{"line_number":36,"context_line":"    },"},{"line_number":37,"context_line":"    \u0027required\u0027: [\u0027shards\u0027, \u0027created_at\u0027, \u0027updated_at\u0027],"},{"line_number":38,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":39,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"f818341c_14961116","line":37,"updated":"2025-07-03 12:14:51.000000000","message":"Why are we adding these properties here? They\u0027re not part of the items schema (and if they were, you\u0027d want to put this on line 32 instead). Hallucination?","commit_id":"0fd304dc56ded9238c65d3c0ed398da95355d43c"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"b10c493fe0696d5d291024fa67ccadc177c149a2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            },"},{"line_number":35,"context_line":"        },"},{"line_number":36,"context_line":"    },"},{"line_number":37,"context_line":"    \u0027required\u0027: [\u0027shards\u0027, \u0027created_at\u0027, \u0027updated_at\u0027],"},{"line_number":38,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":39,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"d6537c0e_ca0d93e8","line":37,"in_reply_to":"ca8bb155_a4295dc7","updated":"2025-07-09 02:14:47.000000000","message":"Acknowledged","commit_id":"0fd304dc56ded9238c65d3c0ed398da95355d43c"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"6cfa49d2ef7bdcec86c356c2711ca12c7df907d4","unresolved":true,"context_lines":[{"line_number":34,"context_line":"            },"},{"line_number":35,"context_line":"        },"},{"line_number":36,"context_line":"    },"},{"line_number":37,"context_line":"    \u0027required\u0027: [\u0027shards\u0027, \u0027created_at\u0027, \u0027updated_at\u0027],"},{"line_number":38,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":39,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"ca8bb155_a4295dc7","line":37,"in_reply_to":"f818341c_14961116","updated":"2025-07-03 16:43:37.000000000","message":"Apologies, two things here:\n - I wanted to test if shards had the same problem as node firmware, where we make sure these fields are required. (From https://review.opendev.org/c/openstack/ironic/+/945943/comment/331980ed_beda4273/). Given the uncertainty for that, I didn\u0027t know it was a certainty it wasn\u0027t in the item schema.\n \n- I didn\u0027t pay attention to the difference in the schema, and put them in the wrong place. I will change.","commit_id":"0fd304dc56ded9238c65d3c0ed398da95355d43c"}]}