)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"24465ebfc8d1be15cdb717f249ed56cd261027b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0c7509dc_3df708a6","updated":"2025-06-26 03:07:37.000000000","message":"Finishing unit tests and testing with real hardware.","commit_id":"27e8762ea00c7289606d20aac81f3a5775e1ec29"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"962c8faa6f293773cc9060422c9dfd906f1e3c92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d6553cc3_1ad77096","updated":"2025-07-02 13:33:54.000000000","message":"Tested in R640\n| Component            | Initial Version | Current Version | Last Version Flashed | Created At                | Updated At                |\n| nic:NIC.Integrated.1 | 19.5.12         | 20.0.17         | 20.0.17              | 2025-06-26T01:33:13+00:00 | 2025-07-02T13:25:38+00:00 |","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c72eef727e81fbc6ff04ff039979cc61d8314491","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b14ce855_134c7f31","updated":"2025-07-07 17:41:20.000000000","message":"thanks Dmitry!","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"79ff665b884fe0044aecd80f595183724eae2aa8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"710f9bbc_b4b6b085","updated":"2025-07-07 23:28:45.000000000","message":"Pushed a new version, going to test things tomorrow to see if things are working as expected, but they should be","commit_id":"c04d568990aa1b35b89fff063b13047b5042ed3d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"fd2a6df2a04ad1067bab0bdd7a0da699b09467ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e4ddbe13_7ad8b3c6","updated":"2025-07-08 06:13:17.000000000","message":"recheck metal3 failed","commit_id":"c04d568990aa1b35b89fff063b13047b5042ed3d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"90c3c69ccd6a5ef3043f830b54887ef17cb88218","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"36d22153_3ce315f0","updated":"2025-07-08 16:38:07.000000000","message":"I had a typo in the pattern 😢\nNow it\u0027s ok, I just tested with bifrost\n\n| nic:NIC.Integrated.1 | 19.5.12         | 22.0.9          | 22.0.9               | 2025-06-26T01:33:13+00:00 | 2025-07-08T16:21:49+00:00 |","commit_id":"0624d19876abeb9e1e82104ab6993fb9cc860bd6"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"c28322f7b7ce06119bc0c0746059bba8a351b84d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4c270899_23514c0f","updated":"2025-07-21 17:10:34.000000000","message":"My only nit would be a documentation update to include an example of using this or even making users aware that this is available. Because today the docs only say \"bmc\" and \"bios\" as being valid.","commit_id":"0624d19876abeb9e1e82104ab6993fb9cc860bd6"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f5fa2fff74b040a2e6af88cbf1935818951c1d51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"22847e41_a7de43de","updated":"2025-07-22 08:10:53.000000000","message":"docs in follow up look good","commit_id":"0624d19876abeb9e1e82104ab6993fb9cc860bd6"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"5e63486c504d2a46868dbe1f628c616631f730a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3edcf709_fe6cad72","in_reply_to":"4c270899_23514c0f","updated":"2025-07-21 17:12:36.000000000","message":"Hey Doug, you are totally right, I will push the docs update in a separate patch later today.\nThanks!","commit_id":"0624d19876abeb9e1e82104ab6993fb9cc860bd6"}],"ironic/drivers/modules/redfish/firmware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9ae61ae26f30f00b593283da6eb8a5d2da2ab606","unresolved":true,"context_lines":[{"line_number":109,"context_line":"            LOG.warning(\u0027No manager available to retrieve Firmware \u0027"},{"line_number":110,"context_line":"                        \u0027from the bmc of node %s\u0027, task.node.uuid)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        try:"},{"line_number":113,"context_line":"            chassis \u003d redfish_utils.get_chassis(task.node, system)"},{"line_number":114,"context_line":"            nic_prefix \u003d \"nic:\""},{"line_number":115,"context_line":"            nic_info_added \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"e558bd76_443b2db6","line":112,"updated":"2025-07-07 16:43:21.000000000","message":"nit: this method is already large, I\u0027d prefer the addition to go into a new helper function.","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c72eef727e81fbc6ff04ff039979cc61d8314491","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            LOG.warning(\u0027No manager available to retrieve Firmware \u0027"},{"line_number":110,"context_line":"                        \u0027from the bmc of node %s\u0027, task.node.uuid)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        try:"},{"line_number":113,"context_line":"            chassis \u003d redfish_utils.get_chassis(task.node, system)"},{"line_number":114,"context_line":"            nic_prefix \u003d \"nic:\""},{"line_number":115,"context_line":"            nic_info_added \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"6c971d26_bfe2bc38","line":112,"in_reply_to":"e558bd76_443b2db6","updated":"2025-07-07 17:41:20.000000000","message":"yeah I was thinking about this, thanks!","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9ae61ae26f30f00b593283da6eb8a5d2da2ab606","unresolved":true,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        try:"},{"line_number":113,"context_line":"            chassis \u003d redfish_utils.get_chassis(task.node, system)"},{"line_number":114,"context_line":"            nic_prefix \u003d \"nic:\""},{"line_number":115,"context_line":"            nic_info_added \u003d False"},{"line_number":116,"context_line":"            for net_adp in chassis.network_adapters.get_members():"},{"line_number":117,"context_line":"                for net_adp_ctrl in net_adp.controllers:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9bf7b30b_eea2f45a","line":114,"updated":"2025-07-07 16:43:21.000000000","message":"nit: Let\u0027s make this a module-level constant","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c72eef727e81fbc6ff04ff039979cc61d8314491","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        try:"},{"line_number":113,"context_line":"            chassis \u003d redfish_utils.get_chassis(task.node, system)"},{"line_number":114,"context_line":"            nic_prefix \u003d \"nic:\""},{"line_number":115,"context_line":"            nic_info_added \u003d False"},{"line_number":116,"context_line":"            for net_adp in chassis.network_adapters.get_members():"},{"line_number":117,"context_line":"                for net_adp_ctrl in net_adp.controllers:"}],"source_content_type":"text/x-python","patch_set":2,"id":"2b15890c_59caec2f","line":114,"in_reply_to":"9bf7b30b_eea2f45a","updated":"2025-07-07 17:41:20.000000000","message":"Acknowledged","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9ae61ae26f30f00b593283da6eb8a5d2da2ab606","unresolved":true,"context_lines":[{"line_number":124,"context_line":"                LOG.debug(\u0027Could not retrieve Firmware Package Version from \u0027"},{"line_number":125,"context_line":"                          \u0027NetworkAdapters on node %(node_uuid)s\u0027,"},{"line_number":126,"context_line":"                          {\u0027node_uuid\u0027: task.node.uuid})"},{"line_number":127,"context_line":"        except exception.RedfishError:"},{"line_number":128,"context_line":"            LOG.warning(\u0027No chassis available to retrieve NetworkAdapters \u0027"},{"line_number":129,"context_line":"                        \u0027firmware information on node %(node_uuid)s\u0027,"},{"line_number":130,"context_line":"                        {\u0027node_uuid\u0027: task.node.uuid})"}],"source_content_type":"text/x-python","patch_set":2,"id":"a7304608_09da8cb1","line":127,"updated":"2025-07-07 16:43:21.000000000","message":"Let\u0027s limit the scope of try..except to only the get_chassis call. Everything else cannot raise a RedfishError, right?\n\n(this will be easier once the code is split into a new function)","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c72eef727e81fbc6ff04ff039979cc61d8314491","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                LOG.debug(\u0027Could not retrieve Firmware Package Version from \u0027"},{"line_number":125,"context_line":"                          \u0027NetworkAdapters on node %(node_uuid)s\u0027,"},{"line_number":126,"context_line":"                          {\u0027node_uuid\u0027: task.node.uuid})"},{"line_number":127,"context_line":"        except exception.RedfishError:"},{"line_number":128,"context_line":"            LOG.warning(\u0027No chassis available to retrieve NetworkAdapters \u0027"},{"line_number":129,"context_line":"                        \u0027firmware information on node %(node_uuid)s\u0027,"},{"line_number":130,"context_line":"                        {\u0027node_uuid\u0027: task.node.uuid})"}],"source_content_type":"text/x-python","patch_set":2,"id":"127c40fe_99ca3d7c","line":127,"in_reply_to":"a7304608_09da8cb1","updated":"2025-07-07 17:41:20.000000000","message":"Will do that, thanks for the review!","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"}],"ironic/drivers/modules/redfish/firmware_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9ae61ae26f30f00b593283da6eb8a5d2da2ab606","unresolved":true,"context_lines":[{"line_number":80,"context_line":"                \"type\": \"string\","},{"line_number":81,"context_line":"                \"anyOf\": ["},{"line_number":82,"context_line":"                    {\"enum\": redfish_utils.FIRMWARE_COMPONENTS},"},{"line_number":83,"context_line":"                    {\"pattern\": \"^nic:.*\"}"},{"line_number":84,"context_line":"                ]"},{"line_number":85,"context_line":"            },"},{"line_number":86,"context_line":"            \"url\": {"}],"source_content_type":"text/x-python","patch_set":2,"id":"429b0c43_cc0b7e49","line":83,"updated":"2025-07-07 16:43:21.000000000","message":"nit: to echo my comment in the implementation: ideally \"nic:\" should be a named constant","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c72eef727e81fbc6ff04ff039979cc61d8314491","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                \"type\": \"string\","},{"line_number":81,"context_line":"                \"anyOf\": ["},{"line_number":82,"context_line":"                    {\"enum\": redfish_utils.FIRMWARE_COMPONENTS},"},{"line_number":83,"context_line":"                    {\"pattern\": \"^nic:.*\"}"},{"line_number":84,"context_line":"                ]"},{"line_number":85,"context_line":"            },"},{"line_number":86,"context_line":"            \"url\": {"}],"source_content_type":"text/x-python","patch_set":2,"id":"37da3cfd_e16efd9f","line":83,"in_reply_to":"429b0c43_cc0b7e49","updated":"2025-07-07 17:41:20.000000000","message":"ack, I will update things, retest and push the code changes probably tomorrow","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"}],"ironic/drivers/modules/redfish/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9ae61ae26f30f00b593283da6eb8a5d2da2ab606","unresolved":true,"context_lines":[{"line_number":578,"context_line":"        if available_chassis:"},{"line_number":579,"context_line":"            return available_chassis[0]"},{"line_number":580,"context_line":"        else:"},{"line_number":581,"context_line":"            raise Exception(\u0027No Redfish Chassis found\u0027)"},{"line_number":582,"context_line":"    except sushy.exceptions.MissingAttributeError as e:"},{"line_number":583,"context_line":"        LOG.error(\u0027No chassis associated with system %(system)s. \u0027"},{"line_number":584,"context_line":"                  \u0027Error %(error)s\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"c4ed9838_fb3c584a","line":581,"updated":"2025-07-07 16:43:21.000000000","message":"We\u0027re doing strange stuff in other methods, let\u0027s not repeat them: this can raise RedfishError directly.","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c72eef727e81fbc6ff04ff039979cc61d8314491","unresolved":false,"context_lines":[{"line_number":578,"context_line":"        if available_chassis:"},{"line_number":579,"context_line":"            return available_chassis[0]"},{"line_number":580,"context_line":"        else:"},{"line_number":581,"context_line":"            raise Exception(\u0027No Redfish Chassis found\u0027)"},{"line_number":582,"context_line":"    except sushy.exceptions.MissingAttributeError as e:"},{"line_number":583,"context_line":"        LOG.error(\u0027No chassis associated with system %(system)s. \u0027"},{"line_number":584,"context_line":"                  \u0027Error %(error)s\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"eee27285_bb6ccbb9","line":581,"in_reply_to":"c4ed9838_fb3c584a","updated":"2025-07-07 17:41:20.000000000","message":"Acknowledged","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9ae61ae26f30f00b593283da6eb8a5d2da2ab606","unresolved":true,"context_lines":[{"line_number":582,"context_line":"    except sushy.exceptions.MissingAttributeError as e:"},{"line_number":583,"context_line":"        LOG.error(\u0027No chassis associated with system %(system)s. \u0027"},{"line_number":584,"context_line":"                  \u0027Error %(error)s\u0027,"},{"line_number":585,"context_line":"                  {\u0027system\u0027: system.identity, \u0027error\u0027: e})"},{"line_number":586,"context_line":"    except Exception as exc:"},{"line_number":587,"context_line":"        LOG.error(\u0027The Redfish Chassis was not found for node %(node)s. \u0027"},{"line_number":588,"context_line":"                  \u0027Error %(error)s\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7736db9e_8f41d50e","line":585,"updated":"2025-07-07 16:43:21.000000000","message":"Missing raise RedfishError on this code path.","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c72eef727e81fbc6ff04ff039979cc61d8314491","unresolved":false,"context_lines":[{"line_number":582,"context_line":"    except sushy.exceptions.MissingAttributeError as e:"},{"line_number":583,"context_line":"        LOG.error(\u0027No chassis associated with system %(system)s. \u0027"},{"line_number":584,"context_line":"                  \u0027Error %(error)s\u0027,"},{"line_number":585,"context_line":"                  {\u0027system\u0027: system.identity, \u0027error\u0027: e})"},{"line_number":586,"context_line":"    except Exception as exc:"},{"line_number":587,"context_line":"        LOG.error(\u0027The Redfish Chassis was not found for node %(node)s. \u0027"},{"line_number":588,"context_line":"                  \u0027Error %(error)s\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"265741cd_23a89d27","line":585,"in_reply_to":"7736db9e_8f41d50e","updated":"2025-07-07 17:41:20.000000000","message":"Acknowledged","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9ae61ae26f30f00b593283da6eb8a5d2da2ab606","unresolved":true,"context_lines":[{"line_number":583,"context_line":"        LOG.error(\u0027No chassis associated with system %(system)s. \u0027"},{"line_number":584,"context_line":"                  \u0027Error %(error)s\u0027,"},{"line_number":585,"context_line":"                  {\u0027system\u0027: system.identity, \u0027error\u0027: e})"},{"line_number":586,"context_line":"    except Exception as exc:"},{"line_number":587,"context_line":"        LOG.error(\u0027The Redfish Chassis was not found for node %(node)s. \u0027"},{"line_number":588,"context_line":"                  \u0027Error %(error)s\u0027,"},{"line_number":589,"context_line":"                  {\u0027node\u0027: node.uuid, \u0027error\u0027: exc})"}],"source_content_type":"text/x-python","patch_set":2,"id":"0eb85439_07ab72ac","line":586,"updated":"2025-07-07 16:43:21.000000000","message":"Do we expect any other exceptions than the one on line 581?","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c72eef727e81fbc6ff04ff039979cc61d8314491","unresolved":true,"context_lines":[{"line_number":583,"context_line":"        LOG.error(\u0027No chassis associated with system %(system)s. \u0027"},{"line_number":584,"context_line":"                  \u0027Error %(error)s\u0027,"},{"line_number":585,"context_line":"                  {\u0027system\u0027: system.identity, \u0027error\u0027: e})"},{"line_number":586,"context_line":"    except Exception as exc:"},{"line_number":587,"context_line":"        LOG.error(\u0027The Redfish Chassis was not found for node %(node)s. \u0027"},{"line_number":588,"context_line":"                  \u0027Error %(error)s\u0027,"},{"line_number":589,"context_line":"                  {\u0027node\u0027: node.uuid, \u0027error\u0027: exc})"}],"source_content_type":"text/x-python","patch_set":2,"id":"bc979089_fcddd6e4","line":586,"in_reply_to":"0eb85439_07ab72ac","updated":"2025-07-07 17:41:20.000000000","message":"no we don\u0027t","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"79ff665b884fe0044aecd80f595183724eae2aa8","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        LOG.error(\u0027No chassis associated with system %(system)s. \u0027"},{"line_number":584,"context_line":"                  \u0027Error %(error)s\u0027,"},{"line_number":585,"context_line":"                  {\u0027system\u0027: system.identity, \u0027error\u0027: e})"},{"line_number":586,"context_line":"    except Exception as exc:"},{"line_number":587,"context_line":"        LOG.error(\u0027The Redfish Chassis was not found for node %(node)s. \u0027"},{"line_number":588,"context_line":"                  \u0027Error %(error)s\u0027,"},{"line_number":589,"context_line":"                  {\u0027node\u0027: node.uuid, \u0027error\u0027: exc})"}],"source_content_type":"text/x-python","patch_set":2,"id":"b6202d55_8ecce3ce","line":586,"in_reply_to":"bc979089_fcddd6e4","updated":"2025-07-07 23:28:45.000000000","message":"Done","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"}],"releasenotes/notes/firmware-interface-support-nic-updates-429f3c6f62f9a0d4.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9ae61ae26f30f00b593283da6eb8a5d2da2ab606","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to update NIC firmware via ``update`` step, the node should"},{"line_number":5,"context_line":"    be using the ``redifhs`` driver and set ``firmware_interface``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bc3e1f1b_2c68a19a","line":4,"updated":"2025-07-07 16:43:21.000000000","message":"I\u0027d rephrase this to something like \"Adds support for updating firmware of certain NIC interfaces to the ``redfish`` firmware interface.\"","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c72eef727e81fbc6ff04ff039979cc61d8314491","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to update NIC firmware via ``update`` step, the node should"},{"line_number":5,"context_line":"    be using the ``redifhs`` driver and set ``firmware_interface``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ad049d29_7e15b638","line":4,"in_reply_to":"bc3e1f1b_2c68a19a","updated":"2025-07-07 17:41:20.000000000","message":"Acknowledged","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9ae61ae26f30f00b593283da6eb8a5d2da2ab606","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to update NIC firmware via ``update`` step, the node should"},{"line_number":5,"context_line":"    be using the ``redifhs`` driver and set ``firmware_interface``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d41a9e26_8f4cbf5b","line":5,"updated":"2025-07-07 16:43:21.000000000","message":"typo: redfish\n\nnit: set to what?","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c72eef727e81fbc6ff04ff039979cc61d8314491","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to update NIC firmware via ``update`` step, the node should"},{"line_number":5,"context_line":"    be using the ``redifhs`` driver and set ``firmware_interface``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c5cdef41_1dbfee6c","line":5,"in_reply_to":"d41a9e26_8f4cbf5b","updated":"2025-07-07 17:41:20.000000000","message":"yeah, I will update and make this more clear.","commit_id":"de6131677fe285b45544a0540acbc6adeb1d00b9"}]}