)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"6adcacfc31fd7bb711dae2a21155f14801faea2b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b6f1cffb_50f8bac3","updated":"2025-06-26 22:41:56.000000000","message":"update the commit message to state that other parts of ironic code require the inventory to have the name field and that identifier was used because it’s a shorter stable name.","commit_id":"65205bd71f2743c00674bc2c3344a29026680fc3"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"f2b052d14483154f586f07e7bc45132c2dda7e6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0ac0d63c_a6fb2f34","in_reply_to":"b6f1cffb_50f8bac3","updated":"2025-06-27 05:00:29.000000000","message":"Done","commit_id":"65205bd71f2743c00674bc2c3344a29026680fc3"}],"ironic/drivers/modules/redfish/inspect.py":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"6adcacfc31fd7bb711dae2a21155f14801faea2b","unresolved":true,"context_lines":[{"line_number":206,"context_line":"            else:"},{"line_number":207,"context_line":"                LOG.warning(\"No port information discovered \""},{"line_number":208,"context_line":"                            \"for node %(node)s\", {\u0027node\u0027: task.node.uuid})"},{"line_number":209,"context_line":"        # import pdb;pdb.set_trace()"},{"line_number":210,"context_line":"        inspect_utils.store_inspection_data(task.node,"},{"line_number":211,"context_line":"                                            inventory, None, task.context)"},{"line_number":212,"context_line":"        return states.MANAGEABLE"}],"source_content_type":"text/x-python","patch_set":3,"id":"3dd79379_385d403b","line":209,"updated":"2025-06-26 22:41:56.000000000","message":"delete this add.","commit_id":"65205bd71f2743c00674bc2c3344a29026680fc3"},{"author":{"_account_id":36720,"name":"Syed Haseeb Ahmed","display_name":"haseeb","email":"syedhaseebahmed12@gmail.com","username":"haseeb"},"change_message_id":"fca8fe60d25fac1eb5388d1d532cf1e33f0c9869","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            else:"},{"line_number":207,"context_line":"                LOG.warning(\"No port information discovered \""},{"line_number":208,"context_line":"                            \"for node %(node)s\", {\u0027node\u0027: task.node.uuid})"},{"line_number":209,"context_line":"        # import pdb;pdb.set_trace()"},{"line_number":210,"context_line":"        inspect_utils.store_inspection_data(task.node,"},{"line_number":211,"context_line":"                                            inventory, None, task.context)"},{"line_number":212,"context_line":"        return states.MANAGEABLE"}],"source_content_type":"text/x-python","patch_set":3,"id":"201b63fc_e25b22e3","line":209,"in_reply_to":"3dd79379_385d403b","updated":"2025-06-27 15:43:45.000000000","message":"Done","commit_id":"65205bd71f2743c00674bc2c3344a29026680fc3"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"f2b052d14483154f586f07e7bc45132c2dda7e6e","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            else:"},{"line_number":207,"context_line":"                LOG.warning(\"No port information discovered \""},{"line_number":208,"context_line":"                            \"for node %(node)s\", {\u0027node\u0027: task.node.uuid})"},{"line_number":209,"context_line":"        # import pdb;pdb.set_trace()"},{"line_number":210,"context_line":"        inspect_utils.store_inspection_data(task.node,"},{"line_number":211,"context_line":"                                            inventory, None, task.context)"},{"line_number":212,"context_line":"        return states.MANAGEABLE"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa5fe730_04347a8f","line":209,"in_reply_to":"3dd79379_385d403b","updated":"2025-06-27 05:00:29.000000000","message":"Done","commit_id":"65205bd71f2743c00674bc2c3344a29026680fc3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d50a8012acc5d36c804d9b90f8f229733b529ad2","unresolved":true,"context_lines":[{"line_number":137,"context_line":"            inventory[\u0027interfaces\u0027] \u003d []"},{"line_number":138,"context_line":"            for eth in system.ethernet_interfaces.get_members():"},{"line_number":139,"context_line":"                iface \u003d {\u0027mac_address\u0027: getattr(eth, \u0027mac_address\u0027, None),"},{"line_number":140,"context_line":"                         \u0027name\u0027: getattr(eth, \u0027identity\u0027, None)}"},{"line_number":141,"context_line":"                inventory[\u0027interfaces\u0027].append(iface)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        system_vendor \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"e6108341_1e088293","line":140,"updated":"2025-06-30 15:37:35.000000000","message":"Why getattr? These fields are always present, even if None","commit_id":"1c0488bc23a3d8030dae73186de943df9176b002"},{"author":{"_account_id":36720,"name":"Syed Haseeb Ahmed","display_name":"haseeb","email":"syedhaseebahmed12@gmail.com","username":"haseeb"},"change_message_id":"046a4f9a168793486d9fdb01a708c0ccfbea0c9f","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            inventory[\u0027interfaces\u0027] \u003d []"},{"line_number":138,"context_line":"            for eth in system.ethernet_interfaces.get_members():"},{"line_number":139,"context_line":"                iface \u003d {\u0027mac_address\u0027: getattr(eth, \u0027mac_address\u0027, None),"},{"line_number":140,"context_line":"                         \u0027name\u0027: getattr(eth, \u0027identity\u0027, None)}"},{"line_number":141,"context_line":"                inventory[\u0027interfaces\u0027].append(iface)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        system_vendor \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"a9de9328_01bd8caa","line":140,"in_reply_to":"e6108341_1e088293","updated":"2025-07-02 14:05:13.000000000","message":"Acknowledged","commit_id":"1c0488bc23a3d8030dae73186de943df9176b002"}],"ironic/tests/unit/drivers/modules/redfish/test_inspect.py":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"6adcacfc31fd7bb711dae2a21155f14801faea2b","unresolved":true,"context_lines":[{"line_number":92,"context_line":"            2 * units.Gi, units.Gi * 4, units.Gi * 6)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        eth_interface_mock \u003d mock.Mock()"},{"line_number":95,"context_line":"        eth_interface_mock.identity \u003d \u0027eth0\u0027"},{"line_number":96,"context_line":"        eth_interface_mock.mac_address \u003d \u002700:11:22:33:44:55\u0027"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        system_mock.ethernet_interfaces.summary \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"f38b9910_a8c1496f","line":95,"updated":"2025-06-26 22:41:56.000000000","message":"to not have confusion I would use NIC.Integrated.1-1 since that’s a real value redfish would use.","commit_id":"65205bd71f2743c00674bc2c3344a29026680fc3"},{"author":{"_account_id":36720,"name":"Syed Haseeb Ahmed","display_name":"haseeb","email":"syedhaseebahmed12@gmail.com","username":"haseeb"},"change_message_id":"fca8fe60d25fac1eb5388d1d532cf1e33f0c9869","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            2 * units.Gi, units.Gi * 4, units.Gi * 6)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        eth_interface_mock \u003d mock.Mock()"},{"line_number":95,"context_line":"        eth_interface_mock.identity \u003d \u0027eth0\u0027"},{"line_number":96,"context_line":"        eth_interface_mock.mac_address \u003d \u002700:11:22:33:44:55\u0027"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        system_mock.ethernet_interfaces.summary \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"1c00e3f4_e96461fc","line":95,"in_reply_to":"f38b9910_a8c1496f","updated":"2025-06-27 15:43:45.000000000","message":"Done","commit_id":"65205bd71f2743c00674bc2c3344a29026680fc3"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"f2b052d14483154f586f07e7bc45132c2dda7e6e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            2 * units.Gi, units.Gi * 4, units.Gi * 6)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        eth_interface_mock \u003d mock.Mock()"},{"line_number":95,"context_line":"        eth_interface_mock.identity \u003d \u0027eth0\u0027"},{"line_number":96,"context_line":"        eth_interface_mock.mac_address \u003d \u002700:11:22:33:44:55\u0027"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        system_mock.ethernet_interfaces.summary \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"ca022721_d774968f","line":95,"in_reply_to":"f38b9910_a8c1496f","updated":"2025-06-27 05:00:29.000000000","message":"Done","commit_id":"65205bd71f2743c00674bc2c3344a29026680fc3"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"6adcacfc31fd7bb711dae2a21155f14801faea2b","unresolved":true,"context_lines":[{"line_number":139,"context_line":"            \u0027local_gb\u0027: \u00273\u0027, \u0027memory_mb\u0027: 2048,"},{"line_number":140,"context_line":"        }"},{"line_number":141,"context_line":"        self.init_system_mock(mock_get_system.return_value)"},{"line_number":142,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":143,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":144,"context_line":"            task.driver.inspect.inspect_hardware(task)"},{"line_number":145,"context_line":"            self.assertEqual(1, mock_create_ports_if_not_exist.call_count)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a3357de_5cd8de13","line":142,"updated":"2025-06-26 22:41:56.000000000","message":"don’t change the white space.","commit_id":"65205bd71f2743c00674bc2c3344a29026680fc3"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"f2b052d14483154f586f07e7bc45132c2dda7e6e","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            \u0027local_gb\u0027: \u00273\u0027, \u0027memory_mb\u0027: 2048,"},{"line_number":140,"context_line":"        }"},{"line_number":141,"context_line":"        self.init_system_mock(mock_get_system.return_value)"},{"line_number":142,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":143,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":144,"context_line":"            task.driver.inspect.inspect_hardware(task)"},{"line_number":145,"context_line":"            self.assertEqual(1, mock_create_ports_if_not_exist.call_count)"}],"source_content_type":"text/x-python","patch_set":3,"id":"017b5103_c1e021d6","line":142,"in_reply_to":"1a3357de_5cd8de13","updated":"2025-06-27 05:00:29.000000000","message":"Done","commit_id":"65205bd71f2743c00674bc2c3344a29026680fc3"},{"author":{"_account_id":36720,"name":"Syed Haseeb Ahmed","display_name":"haseeb","email":"syedhaseebahmed12@gmail.com","username":"haseeb"},"change_message_id":"fca8fe60d25fac1eb5388d1d532cf1e33f0c9869","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            \u0027local_gb\u0027: \u00273\u0027, \u0027memory_mb\u0027: 2048,"},{"line_number":140,"context_line":"        }"},{"line_number":141,"context_line":"        self.init_system_mock(mock_get_system.return_value)"},{"line_number":142,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":143,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":144,"context_line":"            task.driver.inspect.inspect_hardware(task)"},{"line_number":145,"context_line":"            self.assertEqual(1, mock_create_ports_if_not_exist.call_count)"}],"source_content_type":"text/x-python","patch_set":3,"id":"d295a7af_ef9cb764","line":142,"in_reply_to":"1a3357de_5cd8de13","updated":"2025-06-27 15:43:45.000000000","message":"Done","commit_id":"65205bd71f2743c00674bc2c3344a29026680fc3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"89390499ba68cb72667948dba418e4583c4e3b46","unresolved":true,"context_lines":[{"line_number":162,"context_line":"                             system_vendor[\u0027manufacturer\u0027])"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"            expected_interfaces \u003d [{\u0027mac_address\u0027: \u002700:11:22:33:44:55\u0027,"},{"line_number":165,"context_line":"                                    \u0027name\u0027: \u0027NIC.Integrated.1-1\u0027}]"},{"line_number":166,"context_line":"            self.assertEqual(expected_interfaces,"},{"line_number":167,"context_line":"                             inventory[\u0027inventory\u0027][\u0027interfaces\u0027])"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"d9fb7b12_eac7f3d0","line":165,"updated":"2025-07-11 15:06:07.000000000","message":"So, I feel a bit concerned here, given you have two interfaces in the prior state, and now your just expecting this method to return a single interface, which seems wrong actually. I guess, sort of looking at it, it might just be the mocking, but wouldn\u0027t we want to ensure we get both interfaces out?","commit_id":"8f17e611fa2e6e8b13135cf777ee1e1f5e371e3d"},{"author":{"_account_id":36720,"name":"Syed Haseeb Ahmed","display_name":"haseeb","email":"syedhaseebahmed12@gmail.com","username":"haseeb"},"change_message_id":"6a0bf80a5630600aa220bc56d2befa9890e978f4","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                             system_vendor[\u0027manufacturer\u0027])"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"            expected_interfaces \u003d [{\u0027mac_address\u0027: \u002700:11:22:33:44:55\u0027,"},{"line_number":165,"context_line":"                                    \u0027name\u0027: \u0027NIC.Integrated.1-1\u0027}]"},{"line_number":166,"context_line":"            self.assertEqual(expected_interfaces,"},{"line_number":167,"context_line":"                             inventory[\u0027inventory\u0027][\u0027interfaces\u0027])"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"60ee3424_40bbd06d","line":165,"in_reply_to":"d9fb7b12_eac7f3d0","updated":"2025-07-17 16:37:06.000000000","message":"Acknowledged","commit_id":"8f17e611fa2e6e8b13135cf777ee1e1f5e371e3d"}]}