)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5622bbed4b465df7e9abd8da0d8631df3a633355","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"301c652a_b984c485","updated":"2025-07-21 17:35:02.000000000","message":"Overall, LGTM but one minor issue. requirements.txt should be updated to set a minimum on the version of sushy. Specifically that appears to be version 5.7.0","commit_id":"f6bc73507452f5951e419e2104c8ce96472a3b7e"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"c430cf4313ee78427e360c2d74b00e4809da9489","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"449685d1_457f043e","updated":"2025-07-23 14:44:04.000000000","message":"recheck \n\nSeeing a failure in the ironic-grenade job:\n\nHttpException: 501: Server Error for url: http://10.0.18.29/compute/v2.1/servers/d40d62c5-f0d0-4485-8d76-eb84b2e94f86/action, The requested functionality is not supported.\n\nSince this patch only updates the sushy version in `requirements.txt`, it seems unrelated. Rechecking to see if it was a transient issue.","commit_id":"938edffff0b60c3465682965e558afb9e5f6a7e2"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"dfa1f27a12764b91703b3891b6e785aa20aa896f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d179fa01_85f4ca0a","updated":"2025-07-28 08:13:50.000000000","message":"great job!\nlet\u0027s fix the nits since the CI needs to run again\nalso please respect the limit of \u003c80 characters in the commit message too","commit_id":"75af49216425aa273f8374b38953dbdd2fdb7245"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c1456d5dc2d39986bb56f610d1fda73f0d4c8fe7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"582969a9_4040f392","updated":"2025-07-28 07:30:25.000000000","message":"recheck","commit_id":"75af49216425aa273f8374b38953dbdd2fdb7245"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"320e39ee0f5ebb7987ad622d551d19cb539d1b7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"a9a8e491_ffdb4f42","updated":"2025-07-30 14:33:37.000000000","message":"Iury\u0027s comments need to be addressed, I\u0027m removing my vote for the time being","commit_id":"8e249b8513fc69400eeefb13733222cdcd51f404"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"0854c3c0fe95a949721bd159b689828ed7d2dcdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"c96661af_f4e305b7","updated":"2025-07-30 14:51:55.000000000","message":"Looking good. \\o/.","commit_id":"8e249b8513fc69400eeefb13733222cdcd51f404"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"2790e47fb88e80d1cc308f6ba256c7236284cc0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"61852adb_fac8fe91","updated":"2025-07-30 09:57:27.000000000","message":"lgtm","commit_id":"8e249b8513fc69400eeefb13733222cdcd51f404"}],"ironic/conf/redfish.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"dfa1f27a12764b91703b3891b6e785aa20aa896f","unresolved":true,"context_lines":[{"line_number":132,"context_line":"    cfg.BoolOpt(\u0027enable_verify_bmc_clock\u0027,"},{"line_number":133,"context_line":"                default\u003dFalse,"},{"line_number":134,"context_line":"                help\u003d_(\u0027Whether to enable the automated verify step \u0027"},{"line_number":135,"context_line":"                       \u0027that checks and sets the BMC clock.\u0027"},{"line_number":136,"context_line":"                       \u0027When enabled, Ironic will automatically attempt \u0027"},{"line_number":137,"context_line":"                       \u0027 to set the BMC\\\u0027s clock during node registration \u0027"},{"line_number":138,"context_line":"                       \u0027(in the verify phase) using Redfish\\\u0027s \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"b55d3778_5f0f1a9f","line":135,"range":{"start_line":135,"start_character":59,"end_line":135,"end_character":60},"updated":"2025-07-28 08:13:50.000000000","message":"nit: missing space before \u0027","commit_id":"75af49216425aa273f8374b38953dbdd2fdb7245"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"b4943177f9666de96df0926d856bc271b59c38d1","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    cfg.BoolOpt(\u0027enable_verify_bmc_clock\u0027,"},{"line_number":133,"context_line":"                default\u003dFalse,"},{"line_number":134,"context_line":"                help\u003d_(\u0027Whether to enable the automated verify step \u0027"},{"line_number":135,"context_line":"                       \u0027that checks and sets the BMC clock.\u0027"},{"line_number":136,"context_line":"                       \u0027When enabled, Ironic will automatically attempt \u0027"},{"line_number":137,"context_line":"                       \u0027 to set the BMC\\\u0027s clock during node registration \u0027"},{"line_number":138,"context_line":"                       \u0027(in the verify phase) using Redfish\\\u0027s \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"396d15dd_c9200a6e","line":135,"range":{"start_line":135,"start_character":59,"end_line":135,"end_character":60},"in_reply_to":"b55d3778_5f0f1a9f","updated":"2025-07-29 21:08:32.000000000","message":"Acknowledged","commit_id":"75af49216425aa273f8374b38953dbdd2fdb7245"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"dfa1f27a12764b91703b3891b6e785aa20aa896f","unresolved":true,"context_lines":[{"line_number":134,"context_line":"                help\u003d_(\u0027Whether to enable the automated verify step \u0027"},{"line_number":135,"context_line":"                       \u0027that checks and sets the BMC clock.\u0027"},{"line_number":136,"context_line":"                       \u0027When enabled, Ironic will automatically attempt \u0027"},{"line_number":137,"context_line":"                       \u0027 to set the BMC\\\u0027s clock during node registration \u0027"},{"line_number":138,"context_line":"                       \u0027(in the verify phase) using Redfish\\\u0027s \u0027"},{"line_number":139,"context_line":"                       \u0027DateTime fields. \u0027"},{"line_number":140,"context_line":"                       \u0027This helps avoid TLS certificate issues\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"892564b9_6edfad4e","line":137,"range":{"start_line":137,"start_character":24,"end_line":137,"end_character":25},"updated":"2025-07-28 08:13:50.000000000","message":"nit: remove space from beginning of line after \u0027","commit_id":"75af49216425aa273f8374b38953dbdd2fdb7245"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"b4943177f9666de96df0926d856bc271b59c38d1","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                help\u003d_(\u0027Whether to enable the automated verify step \u0027"},{"line_number":135,"context_line":"                       \u0027that checks and sets the BMC clock.\u0027"},{"line_number":136,"context_line":"                       \u0027When enabled, Ironic will automatically attempt \u0027"},{"line_number":137,"context_line":"                       \u0027 to set the BMC\\\u0027s clock during node registration \u0027"},{"line_number":138,"context_line":"                       \u0027(in the verify phase) using Redfish\\\u0027s \u0027"},{"line_number":139,"context_line":"                       \u0027DateTime fields. \u0027"},{"line_number":140,"context_line":"                       \u0027This helps avoid TLS certificate issues\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"c20a2d29_68fabda6","line":137,"range":{"start_line":137,"start_character":24,"end_line":137,"end_character":25},"in_reply_to":"892564b9_6edfad4e","updated":"2025-07-29 21:08:32.000000000","message":"Acknowledged","commit_id":"75af49216425aa273f8374b38953dbdd2fdb7245"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"dfa1f27a12764b91703b3891b6e785aa20aa896f","unresolved":true,"context_lines":[{"line_number":137,"context_line":"                       \u0027 to set the BMC\\\u0027s clock during node registration \u0027"},{"line_number":138,"context_line":"                       \u0027(in the verify phase) using Redfish\\\u0027s \u0027"},{"line_number":139,"context_line":"                       \u0027DateTime fields. \u0027"},{"line_number":140,"context_line":"                       \u0027This helps avoid TLS certificate issues\u0027"},{"line_number":141,"context_line":"                       \u0027caused by incorrect BMC time.\u0027)),"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":14,"id":"9af13ee1_6c5046a9","line":140,"updated":"2025-07-28 08:13:50.000000000","message":"nit: missing space before \u0027","commit_id":"75af49216425aa273f8374b38953dbdd2fdb7245"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"b4943177f9666de96df0926d856bc271b59c38d1","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                       \u0027 to set the BMC\\\u0027s clock during node registration \u0027"},{"line_number":138,"context_line":"                       \u0027(in the verify phase) using Redfish\\\u0027s \u0027"},{"line_number":139,"context_line":"                       \u0027DateTime fields. \u0027"},{"line_number":140,"context_line":"                       \u0027This helps avoid TLS certificate issues\u0027"},{"line_number":141,"context_line":"                       \u0027caused by incorrect BMC time.\u0027)),"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":14,"id":"9df90ea5_f12a5b6f","line":140,"in_reply_to":"9af13ee1_6c5046a9","updated":"2025-07-29 21:08:32.000000000","message":"Acknowledged","commit_id":"75af49216425aa273f8374b38953dbdd2fdb7245"}],"ironic/drivers/modules/redfish/management.py":[{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"3ab73a23250cf6c689d307392dd0139d7b3916a8","unresolved":true,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"class RedfishManagement(base.ManagementInterface):"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    CLEAN_STEPS \u003d ["},{"line_number":181,"context_line":"        {"},{"line_number":182,"context_line":"            \u0027interface\u0027: \u0027management\u0027,"},{"line_number":183,"context_line":"            \u0027step\u0027: \u0027set_bmc_clock\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"c46e5d7c_18e8add8","line":180,"updated":"2025-07-17 10:21:37.000000000","message":"This could perhaps be added to the docs?","commit_id":"b3e92114f9963b08e7064c1d65709ff28a273db0"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"bce6ee9d912145af3f9eab638da98acc84ea24fb","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"class RedfishManagement(base.ManagementInterface):"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    CLEAN_STEPS \u003d ["},{"line_number":181,"context_line":"        {"},{"line_number":182,"context_line":"            \u0027interface\u0027: \u0027management\u0027,"},{"line_number":183,"context_line":"            \u0027step\u0027: \u0027set_bmc_clock\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fc27c5ea_7f9d695f","line":180,"in_reply_to":"c46e5d7c_18e8add8","updated":"2025-07-18 08:15:24.000000000","message":"Acknowledged","commit_id":"b3e92114f9963b08e7064c1d65709ff28a273db0"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"3ab73a23250cf6c689d307392dd0139d7b3916a8","unresolved":true,"context_lines":[{"line_number":214,"context_line":"        \"\"\""},{"line_number":215,"context_line":"        redfish_utils.parse_driver_info(task.node)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def get_clean_steps(self, node, ports\u003dNone):"},{"line_number":218,"context_line":"        \"\"\"Return the clean steps supported by the interface."},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        :param node: the node object"}],"source_content_type":"text/x-python","patch_set":8,"id":"dd2af5c3_1521d5aa","line":217,"updated":"2025-07-17 10:21:37.000000000","message":"Not sure if we need this...","commit_id":"b3e92114f9963b08e7064c1d65709ff28a273db0"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"9271a784711f600fbdf36115c9c5d1327685b0bc","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        \"\"\""},{"line_number":215,"context_line":"        redfish_utils.parse_driver_info(task.node)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def get_clean_steps(self, node, ports\u003dNone):"},{"line_number":218,"context_line":"        \"\"\"Return the clean steps supported by the interface."},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        :param node: the node object"}],"source_content_type":"text/x-python","patch_set":8,"id":"234ba064_26555b16","line":217,"in_reply_to":"dd2af5c3_1521d5aa","updated":"2025-07-21 15:18:10.000000000","message":"Thanks for the feedback.\nYou\u0027re right, the get_clean_steps() method isn\u0027t needed here since the CLEAN_STEPS list is already defined, and the base ManagementInterface will handle returning it.\nI have removed the method to keep the code clean and avoid redundancy.","commit_id":"b3e92114f9963b08e7064c1d65709ff28a273db0"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"3ab73a23250cf6c689d307392dd0139d7b3916a8","unresolved":true,"context_lines":[{"line_number":541,"context_line":"            LOG.debug(\"Auto-setting BMC clock to current time: %s\","},{"line_number":542,"context_line":"                      system_time)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"            manager.set_datetime(system_time)"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"            manager.refresh()"},{"line_number":547,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3ddac313_540e71f5","line":544,"updated":"2025-07-17 10:21:37.000000000","message":"Should this be get_datetime instead? We perhaps don\u0027t need to set the datetime before actually checking if its correct or not.","commit_id":"b3e92114f9963b08e7064c1d65709ff28a273db0"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"9271a784711f600fbdf36115c9c5d1327685b0bc","unresolved":false,"context_lines":[{"line_number":541,"context_line":"            LOG.debug(\"Auto-setting BMC clock to current time: %s\","},{"line_number":542,"context_line":"                      system_time)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"            manager.set_datetime(system_time)"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"            manager.refresh()"},{"line_number":547,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"15829f3a_5b640927","line":544,"in_reply_to":"3ddac313_540e71f5","updated":"2025-07-21 15:18:10.000000000","message":"Thanks for pointing this out. It makes more sense to compare the BMC clock with the system time first before deciding to update it. I have updated the logic to first check the time using manager.datetime, and only set the BMC clock if the drift exceeds 1 second.","commit_id":"b3e92114f9963b08e7064c1d65709ff28a273db0"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"3ab73a23250cf6c689d307392dd0139d7b3916a8","unresolved":true,"context_lines":[{"line_number":556,"context_line":"            # Fail if the BMC clock differs from system time"},{"line_number":557,"context_line":"            # by more than 1 second"},{"line_number":558,"context_line":"            if abs((manager_time - local_time).total_seconds()) \u003e 1:"},{"line_number":559,"context_line":"                raise exception.RedfishError(\"BMC clock verification failed\")"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"            LOG.info(\"Auto BMC clock update successful for node %s\","},{"line_number":562,"context_line":"                     task.node.uuid)"}],"source_content_type":"text/x-python","patch_set":8,"id":"64e4af0d_706d84ee","line":559,"updated":"2025-07-17 10:21:37.000000000","message":"It could be set here. Then we could raise an exception if its still not correct upon rechecking.","commit_id":"b3e92114f9963b08e7064c1d65709ff28a273db0"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"9271a784711f600fbdf36115c9c5d1327685b0bc","unresolved":false,"context_lines":[{"line_number":556,"context_line":"            # Fail if the BMC clock differs from system time"},{"line_number":557,"context_line":"            # by more than 1 second"},{"line_number":558,"context_line":"            if abs((manager_time - local_time).total_seconds()) \u003e 1:"},{"line_number":559,"context_line":"                raise exception.RedfishError(\"BMC clock verification failed\")"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"            LOG.info(\"Auto BMC clock update successful for node %s\","},{"line_number":562,"context_line":"                     task.node.uuid)"}],"source_content_type":"text/x-python","patch_set":8,"id":"f88c7a86_69427a98","line":559,"in_reply_to":"64e4af0d_706d84ee","updated":"2025-07-21 15:18:10.000000000","message":"Yes. I have now added the update and recheck logic inside the conditional block.","commit_id":"b3e92114f9963b08e7064c1d65709ff28a273db0"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"c676e78cf0cca4b0a465ca2f2ec37e4f330311ec","unresolved":true,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"class RedfishManagement(base.ManagementInterface):"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    CLEAN_STEPS \u003d ["},{"line_number":181,"context_line":"        {"},{"line_number":182,"context_line":"            \u0027interface\u0027: \u0027management\u0027,"},{"line_number":183,"context_line":"            \u0027step\u0027: \u0027set_bmc_clock\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"448ccb09_4c9aedf1","line":180,"updated":"2025-07-23 11:01:01.000000000","message":"Not sure if we need this in code (just adding it to docs might suffice), I will let others give their opinion :)","commit_id":"938edffff0b60c3465682965e558afb9e5f6a7e2"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"a63e93d9808fb59145e4da945881e7c25a3537db","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"class RedfishManagement(base.ManagementInterface):"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    CLEAN_STEPS \u003d ["},{"line_number":181,"context_line":"        {"},{"line_number":182,"context_line":"            \u0027interface\u0027: \u0027management\u0027,"},{"line_number":183,"context_line":"            \u0027step\u0027: \u0027set_bmc_clock\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"cdb62881_b3750ce8","line":180,"in_reply_to":"448ccb09_4c9aedf1","updated":"2025-07-27 20:31:35.000000000","message":"Acknowledged","commit_id":"938edffff0b60c3465682965e558afb9e5f6a7e2"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"090c12251ff9665950618f21c261f878d7f18e3e","unresolved":true,"context_lines":[{"line_number":529,"context_line":"            manager_time \u003d parser.isoparse(manager.datetime)"},{"line_number":530,"context_line":"            local_time \u003d parser.isoparse(system_time)"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"            LOG.debug(\"BMC time: %s, System time: %s\","},{"line_number":533,"context_line":"                      manager_time, local_time)"},{"line_number":534,"context_line":"            LOG.debug(\"manager.datetime_local_offset: %s\","},{"line_number":535,"context_line":"                      manager.datetimelocaloffset)"}],"source_content_type":"text/x-python","patch_set":12,"id":"62db92d0_38d00798","line":532,"updated":"2025-07-23 10:57:16.000000000","message":"Perhaps \u0027current time\u0027, or \u0027local time\u0027 is a better name than \u0027system time\u0027, to avoid confusion with the redfish system time","commit_id":"938edffff0b60c3465682965e558afb9e5f6a7e2"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"a63e93d9808fb59145e4da945881e7c25a3537db","unresolved":false,"context_lines":[{"line_number":529,"context_line":"            manager_time \u003d parser.isoparse(manager.datetime)"},{"line_number":530,"context_line":"            local_time \u003d parser.isoparse(system_time)"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"            LOG.debug(\"BMC time: %s, System time: %s\","},{"line_number":533,"context_line":"                      manager_time, local_time)"},{"line_number":534,"context_line":"            LOG.debug(\"manager.datetime_local_offset: %s\","},{"line_number":535,"context_line":"                      manager.datetimelocaloffset)"}],"source_content_type":"text/x-python","patch_set":12,"id":"a3d0f8bc_32d7de55","line":532,"in_reply_to":"62db92d0_38d00798","updated":"2025-07-27 20:31:35.000000000","message":"Thanks for the feedback. I think that\u0027s understandable. I have implemented the change to avoid confusion.","commit_id":"938edffff0b60c3465682965e558afb9e5f6a7e2"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"c676e78cf0cca4b0a465ca2f2ec37e4f330311ec","unresolved":true,"context_lines":[{"line_number":538,"context_line":"            # by more than 1 second"},{"line_number":539,"context_line":"            if abs((manager_time - local_time).total_seconds()) \u003e 1:"},{"line_number":540,"context_line":"                LOG.info(\"BMC clock is out of sync. Updating...\")"},{"line_number":541,"context_line":"                manager.set_datetime(system_time)"},{"line_number":542,"context_line":"                manager.refresh()"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"                updated_time \u003d parser.isoparse(manager.datetime)"}],"source_content_type":"text/x-python","patch_set":12,"id":"806fab0f_71f3a72a","line":541,"updated":"2025-07-23 11:01:01.000000000","message":"Wondering if we should set datetimelocaloffset to utc (or 0) as a default","commit_id":"938edffff0b60c3465682965e558afb9e5f6a7e2"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"a63e93d9808fb59145e4da945881e7c25a3537db","unresolved":false,"context_lines":[{"line_number":538,"context_line":"            # by more than 1 second"},{"line_number":539,"context_line":"            if abs((manager_time - local_time).total_seconds()) \u003e 1:"},{"line_number":540,"context_line":"                LOG.info(\"BMC clock is out of sync. Updating...\")"},{"line_number":541,"context_line":"                manager.set_datetime(system_time)"},{"line_number":542,"context_line":"                manager.refresh()"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"                updated_time \u003d parser.isoparse(manager.datetime)"}],"source_content_type":"text/x-python","patch_set":12,"id":"8b5b45ba_1b5e022f","line":541,"in_reply_to":"806fab0f_71f3a72a","updated":"2025-07-27 20:31:35.000000000","message":"Thanks for the review.  I have updated the verify_bmc_clock step to explicitly set the datetime_local_offset to \"+00:00\" when calling set_datetime, so that the BMC clock is aligned with UTC by default.","commit_id":"938edffff0b60c3465682965e558afb9e5f6a7e2"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"dfa1f27a12764b91703b3891b6e785aa20aa896f","unresolved":true,"context_lines":[{"line_number":476,"context_line":"        \"\"\"Set the BMC clock using Redfish Manager resource."},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        :param datetime: The datetime to set in ISO8601 format"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"        :param datetime_local_offset: The local time offset from UTC (optional)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f28be30_5fbbe468","line":479,"updated":"2025-07-28 08:13:50.000000000","message":"nit: usually we don\u0027t leave empty rows between lines in the docstring","commit_id":"75af49216425aa273f8374b38953dbdd2fdb7245"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"b4943177f9666de96df0926d856bc271b59c38d1","unresolved":false,"context_lines":[{"line_number":476,"context_line":"        \"\"\"Set the BMC clock using Redfish Manager resource."},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        :param datetime: The datetime to set in ISO8601 format"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"        :param datetime_local_offset: The local time offset from UTC (optional)"}],"source_content_type":"text/x-python","patch_set":14,"id":"c72c8663_460f9ec0","line":479,"in_reply_to":"7f28be30_5fbbe468","updated":"2025-07-29 21:08:32.000000000","message":"Acknowledged","commit_id":"75af49216425aa273f8374b38953dbdd2fdb7245"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3187db0179175acedec53a81eb87eec2743e6489","unresolved":true,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"class RedfishManagement(base.ManagementInterface):"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    CLEAN_STEPS \u003d ["},{"line_number":181,"context_line":"        {"},{"line_number":182,"context_line":"            \u0027interface\u0027: \u0027management\u0027,"},{"line_number":183,"context_line":"            \u0027step\u0027: \u0027set_bmc_clock\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"7458c33f_81c7dceb","line":180,"updated":"2025-07-30 14:20:44.000000000","message":"I don\u0027t see this been used, I\u0027m assuming you would pass to the cleaning decorator, but I wouldn\u0027t use CLEAN_STEPS as the name of the variable","commit_id":"8e249b8513fc69400eeefb13733222cdcd51f404"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"e7fe80fa94ae16707375eaa5879d56216ee4dfc4","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"class RedfishManagement(base.ManagementInterface):"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    CLEAN_STEPS \u003d ["},{"line_number":181,"context_line":"        {"},{"line_number":182,"context_line":"            \u0027interface\u0027: \u0027management\u0027,"},{"line_number":183,"context_line":"            \u0027step\u0027: \u0027set_bmc_clock\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"3d4541cd_ef907230","line":180,"in_reply_to":"7458c33f_81c7dceb","updated":"2025-07-31 05:39:16.000000000","message":"Thanks for the feedback. I have added the decorator, and merged the release notes as suggested. Please let me know if anything else needs adjustment.","commit_id":"8e249b8513fc69400eeefb13733222cdcd51f404"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3187db0179175acedec53a81eb87eec2743e6489","unresolved":true,"context_lines":[{"line_number":472,"context_line":"        }"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":475,"context_line":"    def set_bmc_clock(self, task, datetime, datetime_local_offset\u003dNone):"},{"line_number":476,"context_line":"        \"\"\"Set the BMC clock using Redfish Manager resource."},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":17,"id":"fcbff89f_26d519b6","line":475,"updated":"2025-07-30 14:20:44.000000000","message":"The release note mentions this is a clean step, but we don\u0027t have the decorator here.","commit_id":"8e249b8513fc69400eeefb13733222cdcd51f404"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"0854c3c0fe95a949721bd159b689828ed7d2dcdd","unresolved":true,"context_lines":[{"line_number":472,"context_line":"        }"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":475,"context_line":"    def set_bmc_clock(self, task, datetime, datetime_local_offset\u003dNone):"},{"line_number":476,"context_line":"        \"\"\"Set the BMC clock using Redfish Manager resource."},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":17,"id":"ec0ea754_89585c07","line":475,"range":{"start_line":475,"start_character":34,"end_line":475,"end_character":42},"updated":"2025-07-30 14:51:55.000000000","message":"nit: I will personally avoid using variables and params such as `datetime`.","commit_id":"8e249b8513fc69400eeefb13733222cdcd51f404"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"e7fe80fa94ae16707375eaa5879d56216ee4dfc4","unresolved":false,"context_lines":[{"line_number":472,"context_line":"        }"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":475,"context_line":"    def set_bmc_clock(self, task, datetime, datetime_local_offset\u003dNone):"},{"line_number":476,"context_line":"        \"\"\"Set the BMC clock using Redfish Manager resource."},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":17,"id":"819ac0d9_8528142f","line":475,"range":{"start_line":475,"start_character":34,"end_line":475,"end_character":42},"in_reply_to":"ec0ea754_89585c07","updated":"2025-07-31 05:39:16.000000000","message":"Acknowledged","commit_id":"8e249b8513fc69400eeefb13733222cdcd51f404"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"e7fe80fa94ae16707375eaa5879d56216ee4dfc4","unresolved":false,"context_lines":[{"line_number":472,"context_line":"        }"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":475,"context_line":"    def set_bmc_clock(self, task, datetime, datetime_local_offset\u003dNone):"},{"line_number":476,"context_line":"        \"\"\"Set the BMC clock using Redfish Manager resource."},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":17,"id":"01a11391_7db44fc8","line":475,"in_reply_to":"fcbff89f_26d519b6","updated":"2025-07-31 05:39:16.000000000","message":"Acknowledged","commit_id":"8e249b8513fc69400eeefb13733222cdcd51f404"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"0854c3c0fe95a949721bd159b689828ed7d2dcdd","unresolved":true,"context_lines":[{"line_number":494,"context_line":"            manager.refresh()"},{"line_number":495,"context_line":"            if manager.datetime !\u003d datetime:"},{"line_number":496,"context_line":"                raise exception.RedfishError("},{"line_number":497,"context_line":"                    \"DateTime verification failed after setting\")"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"            LOG.info("},{"line_number":500,"context_line":"                \"Successfully updated BMC clock for node %s\","}],"source_content_type":"text/x-python","patch_set":17,"id":"9d21104b_00933d27","line":497,"range":{"start_line":497,"start_character":0,"end_line":497,"end_character":65},"updated":"2025-07-30 14:51:55.000000000","message":"\"BMC clock update failed: %s\" might be the right log here as well, to not be confused to have come from the verification method\n\nA time mismatch means the update failed.","commit_id":"8e249b8513fc69400eeefb13733222cdcd51f404"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"e7fe80fa94ae16707375eaa5879d56216ee4dfc4","unresolved":false,"context_lines":[{"line_number":494,"context_line":"            manager.refresh()"},{"line_number":495,"context_line":"            if manager.datetime !\u003d datetime:"},{"line_number":496,"context_line":"                raise exception.RedfishError("},{"line_number":497,"context_line":"                    \"DateTime verification failed after setting\")"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"            LOG.info("},{"line_number":500,"context_line":"                \"Successfully updated BMC clock for node %s\","}],"source_content_type":"text/x-python","patch_set":17,"id":"46152eb2_ad1e2f0a","line":497,"range":{"start_line":497,"start_character":0,"end_line":497,"end_character":65},"in_reply_to":"9d21104b_00933d27","updated":"2025-07-31 05:39:16.000000000","message":"Thanks for the review. I have addressed the variable name and applied the other suggested changes. Please let me know if anything else needs adjustment.","commit_id":"8e249b8513fc69400eeefb13733222cdcd51f404"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"0854c3c0fe95a949721bd159b689828ed7d2dcdd","unresolved":true,"context_lines":[{"line_number":510,"context_line":"        \"\"\"Verify and auto-set the BMC clock to the current UTC time."},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        This step compares the system UTC time to the BMC\u0027s Redfish datetime."},{"line_number":513,"context_line":"        If the difference exceeds 1 second, verification fails."},{"line_number":514,"context_line":"        \"\"\""},{"line_number":515,"context_line":"        if not CONF.redfish.enable_verify_bmc_clock:"},{"line_number":516,"context_line":"            LOG.info(\"Skipping BMC clock verify step: disabled via config\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"c8aee619_1cc3f55e","line":513,"range":{"start_line":513,"start_character":0,"end_line":513,"end_character":63},"updated":"2025-07-30 14:51:55.000000000","message":"nit: Maybe update this part to include we attempt a time sync before excepting","commit_id":"8e249b8513fc69400eeefb13733222cdcd51f404"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"e7fe80fa94ae16707375eaa5879d56216ee4dfc4","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        \"\"\"Verify and auto-set the BMC clock to the current UTC time."},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        This step compares the system UTC time to the BMC\u0027s Redfish datetime."},{"line_number":513,"context_line":"        If the difference exceeds 1 second, verification fails."},{"line_number":514,"context_line":"        \"\"\""},{"line_number":515,"context_line":"        if not CONF.redfish.enable_verify_bmc_clock:"},{"line_number":516,"context_line":"            LOG.info(\"Skipping BMC clock verify step: disabled via config\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"7c56c212_1691673a","line":513,"range":{"start_line":513,"start_character":0,"end_line":513,"end_character":63},"in_reply_to":"c8aee619_1cc3f55e","updated":"2025-07-31 05:39:16.000000000","message":"Acknowledged","commit_id":"8e249b8513fc69400eeefb13733222cdcd51f404"}],"ironic/tests/unit/drivers/modules/redfish/test_management.py":[{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"3ab73a23250cf6c689d307392dd0139d7b3916a8","unresolved":true,"context_lines":[{"line_number":694,"context_line":"        mock_manager.set_datetime.assert_called_once()"},{"line_number":695,"context_line":"        mock_manager.refresh.assert_called_once()"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"    def test__get_sensors_fan(self):"},{"line_number":698,"context_line":"        attributes \u003d {"},{"line_number":699,"context_line":"            \"identity\": \"XXX-YYY-ZZZ\","},{"line_number":700,"context_line":"            \"name\": \"CPU Fan\","}],"source_content_type":"text/x-python","patch_set":8,"id":"6e0d8118_d11a8a1d","line":697,"updated":"2025-07-17 10:21:37.000000000","message":"From Line 697-923 it might be added by mistake :)","commit_id":"b3e92114f9963b08e7064c1d65709ff28a273db0"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"bce6ee9d912145af3f9eab638da98acc84ea24fb","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        mock_manager.set_datetime.assert_called_once()"},{"line_number":695,"context_line":"        mock_manager.refresh.assert_called_once()"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"    def test__get_sensors_fan(self):"},{"line_number":698,"context_line":"        attributes \u003d {"},{"line_number":699,"context_line":"            \"identity\": \"XXX-YYY-ZZZ\","},{"line_number":700,"context_line":"            \"name\": \"CPU Fan\","}],"source_content_type":"text/x-python","patch_set":8,"id":"9d4615bc_e376fe15","line":697,"in_reply_to":"6e0d8118_d11a8a1d","updated":"2025-07-18 08:15:24.000000000","message":"Yeah, exactly. I don\u0027t remember touching that code since it\u0027s not related to what I was working on.","commit_id":"b3e92114f9963b08e7064c1d65709ff28a273db0"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"9595aae0a83c26c6f93a75a1b12799da66449806","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        mock_manager.set_datetime.assert_called_once()"},{"line_number":695,"context_line":"        mock_manager.refresh.assert_called_once()"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"    def test__get_sensors_fan(self):"},{"line_number":698,"context_line":"        attributes \u003d {"},{"line_number":699,"context_line":"            \"identity\": \"XXX-YYY-ZZZ\","},{"line_number":700,"context_line":"            \"name\": \"CPU Fan\","}],"source_content_type":"text/x-python","patch_set":8,"id":"0a75cf05_16fb4876","line":697,"in_reply_to":"9d4615bc_e376fe15","updated":"2025-07-18 09:41:42.000000000","message":"You could just delete these lines from your local work, and push the change, and that should update the change :)","commit_id":"b3e92114f9963b08e7064c1d65709ff28a273db0"}],"releasenotes/notes/add-set-bmc-clock-cleaning-step-f8fa61aeef0cc985.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"dfa1f27a12764b91703b3891b6e785aa20aa896f","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new manual cleaning step ``set_bmc_clock`` to the Redfish management"},{"line_number":5,"context_line":"    interface. This allows operators to set the BMC\u0027s hardware clock to a specific"},{"line_number":6,"context_line":"    datetime (in ISO8601 format), optionally including a datetimelocaloffset."},{"line_number":7,"context_line":"    This step can be useful to synchronize the BMC clock in bare metal environments"},{"line_number":8,"context_line":"    where BMC clocks are incorrect."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"e04b2100_c06618d6","line":5,"updated":"2025-07-28 08:13:50.000000000","message":"nit: line limit is \u003c80 characters","commit_id":"75af49216425aa273f8374b38953dbdd2fdb7245"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"b4943177f9666de96df0926d856bc271b59c38d1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new manual cleaning step ``set_bmc_clock`` to the Redfish management"},{"line_number":5,"context_line":"    interface. This allows operators to set the BMC\u0027s hardware clock to a specific"},{"line_number":6,"context_line":"    datetime (in ISO8601 format), optionally including a datetimelocaloffset."},{"line_number":7,"context_line":"    This step can be useful to synchronize the BMC clock in bare metal environments"},{"line_number":8,"context_line":"    where BMC clocks are incorrect."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"25d29294_e197f506","line":5,"in_reply_to":"e04b2100_c06618d6","updated":"2025-07-29 21:08:32.000000000","message":"Acknowledged","commit_id":"75af49216425aa273f8374b38953dbdd2fdb7245"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3187db0179175acedec53a81eb87eec2743e6489","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"a2ee8b46_d46b1581","line":9,"updated":"2025-07-30 14:20:44.000000000","message":"We have two separated release notes, you can merge them.\nI would rename the releasenote to cover both features and add them.","commit_id":"8e249b8513fc69400eeefb13733222cdcd51f404"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"e7fe80fa94ae16707375eaa5879d56216ee4dfc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"63e03d6e_fc1ae337","line":9,"in_reply_to":"a2ee8b46_d46b1581","updated":"2025-07-31 05:39:16.000000000","message":"Acknowledged","commit_id":"8e249b8513fc69400eeefb13733222cdcd51f404"}],"releasenotes/notes/add-verify-bmc-clock-step-061e2dcc5810aacf.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"dfa1f27a12764b91703b3891b6e785aa20aa896f","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    synchronization in baremetal environments where BMC clocks may drift or be"},{"line_number":9,"context_line":"    misconfigured."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"d3c0b42c_7397f04f","line":11,"updated":"2025-07-28 08:13:50.000000000","message":"nit: too many blank lines at the end","commit_id":"75af49216425aa273f8374b38953dbdd2fdb7245"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"b4943177f9666de96df0926d856bc271b59c38d1","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    synchronization in baremetal environments where BMC clocks may drift or be"},{"line_number":9,"context_line":"    misconfigured."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"cd285c51_9c8f6043","line":11,"in_reply_to":"d3c0b42c_7397f04f","updated":"2025-07-29 21:08:32.000000000","message":"Thank you for the feedback. I have made the corrections. Also, thanks for work on the ironic grenade job.","commit_id":"75af49216425aa273f8374b38953dbdd2fdb7245"}]}