)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cb1c1c7a70fda83d10a084a25c914a0c358e7f27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c4c9ec6b_523a7c00","updated":"2025-07-02 08:50:10.000000000","message":"\u003e At the time I asked if there should be a separate conf like hooks.conf which had their configs.\n\nThis can be done but oslo.config will merge all configuration in the same tree anyway.","commit_id":"70e69fa58f407943dbd4e722a8fccb1ecf59114b"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"da2a0c0367e0421de3975753db5bc8f6967f40b4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b2c09d66_a9f1064f","updated":"2025-07-01 21:53:51.000000000","message":"I think we need to have a plan on how to pass arguments into hooks and how to have the arguments clearly scoped to those hooks as the [inspector] key will get dirty quickly.\n\nWhen I cleaned up the hook loading code one of the changes that I was asked to make was to support passing arguments to the constructor of the hook. So in theory arguments could be loaded there and supplied there. This could make it cleaner have them standalone.\n\nAt the time I asked if there should be a separate conf like hooks.conf which had their configs.","commit_id":"70e69fa58f407943dbd4e722a8fccb1ecf59114b"}],"doc/source/admin/inspection/hooks.rst":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"da2a0c0367e0421de3975753db5bc8f6967f40b4","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"       [inspector]"},{"line_number":64,"context_line":"       ignore_interface \u003d mac_address:\"11:22:33:44:55:66\""},{"line_number":65,"context_line":"       ignore_interface \u003d driver:cdc_ether"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    Deletes ports that don\u0027t match the"},{"line_number":68,"context_line":"    :oslo.config:option:`inspector.keep_ports` setting."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ea8950f4_46e0623c","line":65,"updated":"2025-07-01 21:53:51.000000000","message":"So this is making a modification of the \"ports\" hook. We should somehow be scoping these variables to the hooks they are for. This is going to be a slippery slope as we allow for out of tree hooks and we have options that can affect hooks as well as some of the rules actions in the future.","commit_id":"70e69fa58f407943dbd4e722a8fccb1ecf59114b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1518fe821303e00ff1186d3c4ccc7ce5dd029960","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"       [inspector]"},{"line_number":64,"context_line":"       ignore_interface \u003d mac_address:\"11:22:33:44:55:66\""},{"line_number":65,"context_line":"       ignore_interface \u003d driver:cdc_ether"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    Deletes ports that don\u0027t match the"},{"line_number":68,"context_line":"    :oslo.config:option:`inspector.keep_ports` setting."}],"source_content_type":"text/x-rst","patch_set":2,"id":"2552c7bc_dfecb319","line":65,"in_reply_to":"ea8950f4_46e0623c","updated":"2025-07-02 08:48:47.000000000","message":"We already have a lot of options for the ports hook. While I welcome this discussion, I\u0027d prefer not to block an important patch on this.","commit_id":"70e69fa58f407943dbd4e722a8fccb1ecf59114b"}]}