)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"277642adf90fcf6ac061c41dd0759cc652b9a57d","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-07-21 18:15:17 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch from local RPC to automated JSON RPC on localhost"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I4a245b3820f8054cb8e6b716aa101aeb3876e504"},{"line_number":10,"context_line":"Signed-off-by: Dmitry Tantsur \u003cdtantsur@protonmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f32d4be_b9803b71","line":8,"updated":"2025-07-22 14:38:24.000000000","message":"Perhaps more detail:\n\nPreviously, in the single-process runner mode, the service \"cheated\" by creating work items directly within the same process space. With the removal of eventlet, this is problematic because the single process launcher delineates the \"processes\" to separate processes launched by the single process launcher. While more scalable, the post-eventlet modeling is incompatible with the single process mode.\n\nTo preserve the single process, combined API and conductor process mode, we\u0027re changing the local RPC engagement to utilize json-rpc as opposed to what was effectively \"cheating\" previously, just calling the object internally inside the single process.\n\nUltimately, this change is a step along the path to remove eventlet from Ironic.","commit_id":"3831464751735ede659c972283bdc5c44d583e04"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"39208f5360955fabdde805ea5df7e48d06eaf084","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bca77082_f58355ef","updated":"2025-07-13 16:25:38.000000000","message":"Overall, pretty good start. I\u0027m sligthly concerned over file placement and ability to write files, but... It look limited and the use case is also super isolated, so maybe its okay.","commit_id":"47829eb5fb0ad0580478deb340e15bf94dca1f6e"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"82ef90af97840f646d93961077cee36504186831","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a2502549_f32ddc2e","updated":"2025-07-22 14:07:01.000000000","message":"I\u0027d say the commit message is confusing with what\u0027s going on.","commit_id":"3831464751735ede659c972283bdc5c44d583e04"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"54380920923d93028a957621fe76de6a652945da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"625f4f7c_f0107b25","updated":"2025-07-22 12:29:35.000000000","message":"LGTM","commit_id":"3831464751735ede659c972283bdc5c44d583e04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"277642adf90fcf6ac061c41dd0759cc652b9a57d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ba8ff7e1_aa6c96b8","updated":"2025-07-22 14:38:24.000000000","message":"Overall, LGTM. One suggestion in-line.","commit_id":"3831464751735ede659c972283bdc5c44d583e04"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bea0c9d3da8f9b07b6347f0a5333128adea29e8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2f3cb358_7fd4dbba","updated":"2025-07-24 06:13:41.000000000","message":"recheck","commit_id":"3831464751735ede659c972283bdc5c44d583e04"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"949f41e4a6ce81e86e2fc799ddb625aaf793995c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ff94a9c4_86b1cbe2","updated":"2025-07-28 08:07:21.000000000","message":"recheck","commit_id":"3831464751735ede659c972283bdc5c44d583e04"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8002ccd9912da86b483a3fc821c7e057bac89f84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1dcbf649_138d1ebf","updated":"2025-07-30 09:52:20.000000000","message":"recheck time out","commit_id":"3831464751735ede659c972283bdc5c44d583e04"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2210fbaa13977c8b7f5105102888ef9110c37f22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"681a9e8d_487efe71","updated":"2025-07-28 13:23:42.000000000","message":"recheck time out","commit_id":"3831464751735ede659c972283bdc5c44d583e04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"277642adf90fcf6ac061c41dd0759cc652b9a57d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9dd862ce_528d62fb","in_reply_to":"a2502549_f32ddc2e","updated":"2025-07-22 14:38:24.000000000","message":"It could definitely be more verbose... hmm","commit_id":"3831464751735ede659c972283bdc5c44d583e04"}],"ironic/common/rpc_service.py":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"82ef90af97840f646d93961077cee36504186831","unresolved":true,"context_lines":[{"line_number":77,"context_line":"            target \u003d messaging.Target(topic\u003dself.topic, server\u003dself.host)"},{"line_number":78,"context_line":"            endpoints \u003d [self.manager]"},{"line_number":79,"context_line":"            self.rpcserver \u003d rpc.get_server(target, endpoints, serializer)"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            self.rpcserver \u003d json_rpc.WSGIService("},{"line_number":82,"context_line":"                self.manager, serializer, context.RequestContext.from_dict)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"d250620a_aa3c29a5","line":80,"updated":"2025-07-22 14:07:01.000000000","message":"here you set the check to anything not \u0027oslo\u0027....","commit_id":"3831464751735ede659c972283bdc5c44d583e04"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"48026fccbfa66d1db955e31919faccf4aff1c295","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            target \u003d messaging.Target(topic\u003dself.topic, server\u003dself.host)"},{"line_number":78,"context_line":"            endpoints \u003d [self.manager]"},{"line_number":79,"context_line":"            self.rpcserver \u003d rpc.get_server(target, endpoints, serializer)"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            self.rpcserver \u003d json_rpc.WSGIService("},{"line_number":82,"context_line":"                self.manager, serializer, context.RequestContext.from_dict)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9c2ad18a_d6ee368f","line":80,"in_reply_to":"b734675a_955bdff4","updated":"2025-07-23 11:59:40.000000000","message":"From the server\u0027s perspective, none and json-rpc are now the same case with different configuration.","commit_id":"3831464751735ede659c972283bdc5c44d583e04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"277642adf90fcf6ac061c41dd0759cc652b9a57d","unresolved":true,"context_lines":[{"line_number":77,"context_line":"            target \u003d messaging.Target(topic\u003dself.topic, server\u003dself.host)"},{"line_number":78,"context_line":"            endpoints \u003d [self.manager]"},{"line_number":79,"context_line":"            self.rpcserver \u003d rpc.get_server(target, endpoints, serializer)"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            self.rpcserver \u003d json_rpc.WSGIService("},{"line_number":82,"context_line":"                self.manager, serializer, context.RequestContext.from_dict)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"b734675a_955bdff4","line":80,"in_reply_to":"d250620a_aa3c29a5","updated":"2025-07-22 14:38:24.000000000","message":"In that case, is it not what line 76+80 is doing? When starting the server, it taking the appropriate path.","commit_id":"3831464751735ede659c972283bdc5c44d583e04"}],"ironic/conductor/rpcapi.py":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"82ef90af97840f646d93961077cee36504186831","unresolved":true,"context_lines":[{"line_number":143,"context_line":"            self.client \u003d json_rpc.Client(serializer\u003dserializer,"},{"line_number":144,"context_line":"                                          version_cap\u003dversion_cap)"},{"line_number":145,"context_line":"            self.topic \u003d \u0027\u0027"},{"line_number":146,"context_line":"        elif CONF.rpc_transport \u003d\u003d \u0027none\u0027:"},{"line_number":147,"context_line":"            self.client \u003d local_rpc.LocalClient(serializer\u003dserializer,"},{"line_number":148,"context_line":"                                                version_cap\u003dversion_cap)"},{"line_number":149,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a75fe37_93cbd1e9","line":146,"updated":"2025-07-22 14:07:01.000000000","message":"Here you set the check to none....","commit_id":"3831464751735ede659c972283bdc5c44d583e04"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"48026fccbfa66d1db955e31919faccf4aff1c295","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            self.client \u003d json_rpc.Client(serializer\u003dserializer,"},{"line_number":144,"context_line":"                                          version_cap\u003dversion_cap)"},{"line_number":145,"context_line":"            self.topic \u003d \u0027\u0027"},{"line_number":146,"context_line":"        elif CONF.rpc_transport \u003d\u003d \u0027none\u0027:"},{"line_number":147,"context_line":"            self.client \u003d local_rpc.LocalClient(serializer\u003dserializer,"},{"line_number":148,"context_line":"                                                version_cap\u003dversion_cap)"},{"line_number":149,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"f8d36e1b_96d9b0b2","line":146,"in_reply_to":"29489091_25164b19","updated":"2025-07-23 11:59:40.000000000","message":"Yep, the client case is different. Well, I guess, I could write this part in a similar fashion as the server side and hide the differences inside json_rpc.Client. Not sure it\u0027s going to be beneficial though? I\u0027d need some sort of a flag to pass from CLI all the way here.","commit_id":"3831464751735ede659c972283bdc5c44d583e04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"277642adf90fcf6ac061c41dd0759cc652b9a57d","unresolved":true,"context_lines":[{"line_number":143,"context_line":"            self.client \u003d json_rpc.Client(serializer\u003dserializer,"},{"line_number":144,"context_line":"                                          version_cap\u003dversion_cap)"},{"line_number":145,"context_line":"            self.topic \u003d \u0027\u0027"},{"line_number":146,"context_line":"        elif CONF.rpc_transport \u003d\u003d \u0027none\u0027:"},{"line_number":147,"context_line":"            self.client \u003d local_rpc.LocalClient(serializer\u003dserializer,"},{"line_number":148,"context_line":"                                                version_cap\u003dversion_cap)"},{"line_number":149,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"29489091_25164b19","line":146,"in_reply_to":"5a75fe37_93cbd1e9","updated":"2025-07-22 14:38:24.000000000","message":"My impression is this is correct, given \"none\" is still a specialized pattern as opposed to json-rpc. Specifically self.client is getting initialized differently in the none case as compared to the oslo case as compared to the remote json-rpc endpoint case.","commit_id":"3831464751735ede659c972283bdc5c44d583e04"}]}