)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1cda4001eb7e633a9f05806dc098d8b1b146625f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"76bd74d3_7c1a836b","updated":"2025-08-04 07:23:20.000000000","message":"single core approving docs update\nthanks!","commit_id":"3106588d61a870525f7db4e3626400c76e5adca0"}],"doc/source/admin/cleaning.rst":[{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"e7a769340e848df4f0b9673ec80f23ed503254b7","unresolved":true,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"The specified runbook must match one of the node\u0027s traits to be used."},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"Another example is setting the BMC clock using the Redfish managemet interface::"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"  {\"target\": \"clean\","},{"line_number":375,"context_line":"   \"clean_steps\": [{"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0abd38f3_7176468c","line":372,"updated":"2025-07-28 09:57:34.000000000","message":"I would move this above line 363 and after line 361\nAlso, nit: management (spelling)","commit_id":"51b046bcf7f4d7ce1ae46eb471cba2b3198fa2b2"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"b762c4327b6ae9a09500fb6c241e29bd003562d4","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"The specified runbook must match one of the node\u0027s traits to be used."},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"Another example is setting the BMC clock using the Redfish managemet interface::"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"  {\"target\": \"clean\","},{"line_number":375,"context_line":"   \"clean_steps\": [{"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8332b764_d8e739f9","line":372,"in_reply_to":"0abd38f3_7176468c","updated":"2025-07-29 04:45:05.000000000","message":"Acknowledged","commit_id":"51b046bcf7f4d7ce1ae46eb471cba2b3198fa2b2"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"e7a769340e848df4f0b9673ec80f23ed503254b7","unresolved":true,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"Another example is setting the BMC clock using the Redfish managemet interface::"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"  {\"target\": \"clean\","},{"line_number":375,"context_line":"   \"clean_steps\": [{"},{"line_number":376,"context_line":"   \"interface\": \"management\","},{"line_number":377,"context_line":"       \"step\": \"set_bmc_clock\","}],"source_content_type":"text/x-rst","patch_set":1,"id":"5515e6e5_7f89c779","line":374,"updated":"2025-07-28 09:57:34.000000000","message":"nit: line break after {","commit_id":"51b046bcf7f4d7ce1ae46eb471cba2b3198fa2b2"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"b762c4327b6ae9a09500fb6c241e29bd003562d4","unresolved":false,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"Another example is setting the BMC clock using the Redfish managemet interface::"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"  {\"target\": \"clean\","},{"line_number":375,"context_line":"   \"clean_steps\": [{"},{"line_number":376,"context_line":"   \"interface\": \"management\","},{"line_number":377,"context_line":"       \"step\": \"set_bmc_clock\","}],"source_content_type":"text/x-rst","patch_set":1,"id":"9e4d83ce_0614f092","line":374,"in_reply_to":"5515e6e5_7f89c779","updated":"2025-07-29 04:45:05.000000000","message":"Acknowledged","commit_id":"51b046bcf7f4d7ce1ae46eb471cba2b3198fa2b2"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"e7a769340e848df4f0b9673ec80f23ed503254b7","unresolved":true,"context_lines":[{"line_number":373,"context_line":""},{"line_number":374,"context_line":"  {\"target\": \"clean\","},{"line_number":375,"context_line":"   \"clean_steps\": [{"},{"line_number":376,"context_line":"   \"interface\": \"management\","},{"line_number":377,"context_line":"       \"step\": \"set_bmc_clock\","},{"line_number":378,"context_line":"       \"args\": {\"datetime\": \"2025-07-22T12:34:56+00:00\"}"},{"line_number":379,"context_line":"     }]"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5efa02ac_28c7d9ab","line":376,"updated":"2025-07-28 09:57:34.000000000","message":"nit: indentation","commit_id":"51b046bcf7f4d7ce1ae46eb471cba2b3198fa2b2"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"b762c4327b6ae9a09500fb6c241e29bd003562d4","unresolved":false,"context_lines":[{"line_number":373,"context_line":""},{"line_number":374,"context_line":"  {\"target\": \"clean\","},{"line_number":375,"context_line":"   \"clean_steps\": [{"},{"line_number":376,"context_line":"   \"interface\": \"management\","},{"line_number":377,"context_line":"       \"step\": \"set_bmc_clock\","},{"line_number":378,"context_line":"       \"args\": {\"datetime\": \"2025-07-22T12:34:56+00:00\"}"},{"line_number":379,"context_line":"     }]"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c86c096c_05c2376e","line":376,"in_reply_to":"5efa02ac_28c7d9ab","updated":"2025-07-29 04:45:05.000000000","message":"Acknowledged","commit_id":"51b046bcf7f4d7ce1ae46eb471cba2b3198fa2b2"}],"doc/source/admin/steps.rst":[{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"e7a769340e848df4f0b9673ec80f23ed503254b7","unresolved":true,"context_lines":[{"line_number":135,"context_line":"which automatically checks and sets the BMC clock during node registration."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"This step compares the system time on the conductor with the BMC\u0027s time reported"},{"line_number":138,"context_line":"via Redfish. If the clock differ by more than one second, Ironic update the BMC\u0027s"},{"line_number":139,"context_line":"clock to match the conductor\u0027s UTC time."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"This step runs automatically if enabled and the node supports the Redfish interface."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f529ef6_7643b965","line":138,"updated":"2025-07-28 09:57:34.000000000","message":"nit: If the clock differs...Ironic updates","commit_id":"51b046bcf7f4d7ce1ae46eb471cba2b3198fa2b2"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"b762c4327b6ae9a09500fb6c241e29bd003562d4","unresolved":false,"context_lines":[{"line_number":135,"context_line":"which automatically checks and sets the BMC clock during node registration."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"This step compares the system time on the conductor with the BMC\u0027s time reported"},{"line_number":138,"context_line":"via Redfish. If the clock differ by more than one second, Ironic update the BMC\u0027s"},{"line_number":139,"context_line":"clock to match the conductor\u0027s UTC time."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"This step runs automatically if enabled and the node supports the Redfish interface."}],"source_content_type":"text/x-rst","patch_set":1,"id":"e6d81e2f_b988a6e1","line":138,"in_reply_to":"7f529ef6_7643b965","updated":"2025-07-29 04:45:05.000000000","message":"Acknowledged","commit_id":"51b046bcf7f4d7ce1ae46eb471cba2b3198fa2b2"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"e7a769340e848df4f0b9673ec80f23ed503254b7","unresolved":true,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":" Note:"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"- If the BMC does not support setting the clock via Redfish, the setp will fail."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"- If the time cannot be synchronized within 1 second, the set will raise a ``NodeVerifyFailure``."},{"line_number":166,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ef989af_c3f52ff2","line":163,"updated":"2025-07-28 09:57:34.000000000","message":"spelling: step","commit_id":"51b046bcf7f4d7ce1ae46eb471cba2b3198fa2b2"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"b762c4327b6ae9a09500fb6c241e29bd003562d4","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":" Note:"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"- If the BMC does not support setting the clock via Redfish, the setp will fail."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"- If the time cannot be synchronized within 1 second, the set will raise a ``NodeVerifyFailure``."},{"line_number":166,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1dc01818_658edf1f","line":163,"in_reply_to":"3ef989af_c3f52ff2","updated":"2025-07-29 04:45:05.000000000","message":"Acknowledged","commit_id":"51b046bcf7f4d7ce1ae46eb471cba2b3198fa2b2"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"e7a769340e848df4f0b9673ec80f23ed503254b7","unresolved":true,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"- If the BMC does not support setting the clock via Redfish, the setp will fail."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"- If the time cannot be synchronized within 1 second, the set will raise a ``NodeVerifyFailure``."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"- If the configuration option is disabled, the step is skipped."},{"line_number":168,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ddec5577_945c8c61","line":165,"updated":"2025-07-28 09:57:34.000000000","message":"nit: ...the step will raise a...","commit_id":"51b046bcf7f4d7ce1ae46eb471cba2b3198fa2b2"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"b762c4327b6ae9a09500fb6c241e29bd003562d4","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"- If the BMC does not support setting the clock via Redfish, the setp will fail."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"- If the time cannot be synchronized within 1 second, the set will raise a ``NodeVerifyFailure``."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"- If the configuration option is disabled, the step is skipped."},{"line_number":168,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"f2a57b57_5e65f3c7","line":165,"in_reply_to":"ddec5577_945c8c61","updated":"2025-07-29 04:45:05.000000000","message":"Thanks so much for all the feedback. I have made the corrections.","commit_id":"51b046bcf7f4d7ce1ae46eb471cba2b3198fa2b2"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"df789e64e56926d07ed371102a46a3f81bbd4e26","unresolved":true,"context_lines":[{"line_number":131,"context_line":"BMC Clock Verification Step (Verify Phase)"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"The Redfish management interface includes a verify step called ``verify_bmc_clock``"},{"line_number":135,"context_line":"which automatically checks and sets the BMC clock during node registration."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"This step compares the system time on the conductor with the BMC\u0027s time reported"}],"source_content_type":"text/x-rst","patch_set":2,"id":"cff3290f_122c7e9b","line":134,"updated":"2025-07-30 10:37:38.000000000","message":"let\u0027s keep the lines length below 80 characters for better readability","commit_id":"3e3c691aeac6fc9b52e15a044d0d0297312aa13d"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"0e402932b9f76f252b815608b235868bfe2f90fc","unresolved":false,"context_lines":[{"line_number":131,"context_line":"BMC Clock Verification Step (Verify Phase)"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"The Redfish management interface includes a verify step called ``verify_bmc_clock``"},{"line_number":135,"context_line":"which automatically checks and sets the BMC clock during node registration."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"This step compares the system time on the conductor with the BMC\u0027s time reported"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e6130d0c_7ae59a5c","line":134,"in_reply_to":"cff3290f_122c7e9b","updated":"2025-07-31 03:04:04.000000000","message":"Acknowledged","commit_id":"3e3c691aeac6fc9b52e15a044d0d0297312aa13d"}]}