)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"dcae860b0e59de395e9a75f3742a6c7a839960e3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cc7d5269_eb6e8719","updated":"2025-08-22 16:46:10.000000000","message":"Are we sure this should default to \"True\"?\n\nIf we have an image in the cache with the correct hash, it seems like for many use cases we\u0027d be regressing behavior significantly -- there\u0027s a lot of Ironic users who use a very short list of images, but deployment failures can happen for a lot of reasons.\n\nThis is an awesome feature; but I think a default of False is the correct move. WDYT?","commit_id":"8fac5aab693b17b0e57c2e90b6e315fc7cd148e7"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"d4b47dde2b0b90ce709140757ac869a88837d58c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bacb057b_0bf5a430","updated":"2025-08-22 11:41:27.000000000","message":"recheck - CI stables","commit_id":"8fac5aab693b17b0e57c2e90b6e315fc7cd148e7"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"82c992a9e2a830b41dd90906e468d3d76180802d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6a8977c9_342a6123","in_reply_to":"cc7d5269_eb6e8719","updated":"2025-08-22 16:47:50.000000000","message":"This opinion is fueled significantly by the fact if a hash fails to validate, we\u0027ll clean out the image unconditionally (right?!?). So we should have ruled \"image download failures\" completely out as a failure case at this point","commit_id":"8fac5aab693b17b0e57c2e90b6e315fc7cd148e7"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"8f017622aee85ffee64e482e8c38be529d49edf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a860959d_57fdbe53","updated":"2025-12-22 14:40:30.000000000","message":"I think what you did makes sense.","commit_id":"5cb4933df664e7c837d54cdecaa625fb5b5b3a10"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e1877b85e4a94b1ae71a9c1acf061d85ed3a3167","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"61a453e4_dad24b5b","updated":"2025-12-10 17:30:34.000000000","message":"Maybe we should abandon this change for now?","commit_id":"5cb4933df664e7c837d54cdecaa625fb5b5b3a10"}],"ironic/conductor/utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"733f9ce5613037e7904e980c9a54c10829a460a4","unresolved":true,"context_lines":[{"line_number":738,"context_line":"        # When clean_up\u003dFalse, we still need to clean up instance images"},{"line_number":739,"context_line":"        # to prevent orphaned files"},{"line_number":740,"context_line":"        try:"},{"line_number":741,"context_line":"            deploy_utils.destroy_images(node.uuid)"},{"line_number":742,"context_line":"        except Exception as e:"},{"line_number":743,"context_line":"            LOG.warning(\u0027Failed to clean up cached instance images \u0027"},{"line_number":744,"context_line":"                        \u0027for node %(node)s; reason: %(err)s\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5d3cbf19_676742f6","line":741,"updated":"2025-08-19 00:05:08.000000000","message":"I suspect we should put a knob in to be able to disable this, since... it can be a feature that the image is already there. This ensures retry of a failed deploy with an unchanged image will always download the image again.","commit_id":"73265d86c5a741a41b2feb1dac7bea5e19f8f4f6"}]}