)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"bc66bf9c1afd8f0e1c266615a7157245ef64051b","unresolved":true,"context_lines":[{"line_number":4200,"context_line":"                    and task.node.fault \u003d\u003d faults.POWER_FAILURE):"},{"line_number":4201,"context_line":"                raise exception.TemporaryFailure("},{"line_number":4202,"context_line":"                    \u0027Unable to attach virtual media for node %s due to power \u0027"},{"line_number":4203,"context_line":"                    \u0027failure state\u0027 % task.node.uuid)"},{"line_number":4204,"context_line":""},{"line_number":4205,"context_line":"            # Starting new operation, so clear the previous error."},{"line_number":4206,"context_line":"            # We\u0027ll be putting an error here soon if we fail task."}],"source_content_type":"text/x-python","patch_set":2,"id":"dbaa0f4a_d148dc7b","line":4203,"updated":"2025-08-23 03:42:09.000000000","message":"Thinking out loud: there are zero cases where telling an API user this would be information they don\u0027t already have access to, right? node maintenance_reason/last_error/history is almost certainly viewable by anyone with attach_virtual_media access, at least in default policy.json","commit_id":"d74b3fac6c2ff9ea18b3c2dbcd9369d92e5c5fe5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"eb3eec03114d207229bd4e4d475121a6158a4874","unresolved":true,"context_lines":[{"line_number":4200,"context_line":"                    and task.node.fault \u003d\u003d faults.POWER_FAILURE):"},{"line_number":4201,"context_line":"                raise exception.TemporaryFailure("},{"line_number":4202,"context_line":"                    \u0027Unable to attach virtual media for node %s due to power \u0027"},{"line_number":4203,"context_line":"                    \u0027failure state\u0027 % task.node.uuid)"},{"line_number":4204,"context_line":""},{"line_number":4205,"context_line":"            # Starting new operation, so clear the previous error."},{"line_number":4206,"context_line":"            # We\u0027ll be putting an error here soon if we fail task."}],"source_content_type":"text/x-python","patch_set":2,"id":"a9103044_90e9d1fd","line":4203,"in_reply_to":"912abe62_2d70458f","updated":"2025-08-23 19:17:15.000000000","message":"No need to update, that\u0027s basically the same conclusion I came to but just wanted to note it in case someone else thought different.","commit_id":"d74b3fac6c2ff9ea18b3c2dbcd9369d92e5c5fe5"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"0071334a13f12aa0703e17283208939f4e420501","unresolved":true,"context_lines":[{"line_number":4200,"context_line":"                    and task.node.fault \u003d\u003d faults.POWER_FAILURE):"},{"line_number":4201,"context_line":"                raise exception.TemporaryFailure("},{"line_number":4202,"context_line":"                    \u0027Unable to attach virtual media for node %s due to power \u0027"},{"line_number":4203,"context_line":"                    \u0027failure state\u0027 % task.node.uuid)"},{"line_number":4204,"context_line":""},{"line_number":4205,"context_line":"            # Starting new operation, so clear the previous error."},{"line_number":4206,"context_line":"            # We\u0027ll be putting an error here soon if we fail task."}],"source_content_type":"text/x-python","patch_set":2,"id":"912abe62_2d70458f","line":4203,"in_reply_to":"dbaa0f4a_d148dc7b","updated":"2025-08-23 08:37:32.000000000","message":"So I think this is not something sensitive, and policy can be changed in deployment. If there are phrases that more suitable I\u0027d glad to update it :)","commit_id":"d74b3fac6c2ff9ea18b3c2dbcd9369d92e5c5fe5"}],"ironic/tests/unit/conductor/test_manager.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"0071334a13f12aa0703e17283208939f4e420501","unresolved":false,"context_lines":[{"line_number":9451,"context_line":"                heartbeat_timeout\u003dheartbeat_timeout,"},{"line_number":9452,"context_line":"                conductor_cleanup_timeout\u003dcleanup_timeout,"},{"line_number":9453,"context_line":"                expected_warning_substring\u003dexpected_warning"},{"line_number":9454,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":2,"id":"d056a474_1476cbe0","line":9454,"in_reply_to":"811a61cd_28a34b86","updated":"2025-08-23 08:37:32.000000000","message":"\u003e pep8: W292 no newline at end of file\n\nPlease fix.","commit_id":"d74b3fac6c2ff9ea18b3c2dbcd9369d92e5c5fe5"}]}