)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"7dd275cde641844a64a8ae9c6e459fd7aec6fd07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3a46fee2_36a9191e","updated":"2025-09-18 00:14:20.000000000","message":"@jay@jvf.cc @dtantsur@protonmail.com ping","commit_id":"fe633a74661cc4fb79cef2e5a54ec5d6f1022525"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9a9beee8da631a537e04f87f6dd6ed4baf309cb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1f66639f_2b8422e6","updated":"2025-09-22 15:48:51.000000000","message":"I hate \"Extra\" but I also hate making this trivial patch linger so too long, and we seem to have a general consensus.","commit_id":"fe633a74661cc4fb79cef2e5a54ec5d6f1022525"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"5a5d8c4a31fb4aba137c9bb0bd17772080af92be","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4faf7a0e_59c3364d","updated":"2025-09-02 14:47:43.000000000","message":"My only comment here is that the SKU field is the Dell Service Tag. While the HPE Serial Number is under the Serial Number field (I think). It might be worthy to include these as well as those are more often used for inventory.","commit_id":"fe633a74661cc4fb79cef2e5a54ec5d6f1022525"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"70acd436a833adc46749fc0a46fa9d1fda49ddc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"413105e0_94ff4748","updated":"2025-09-02 18:23:09.000000000","message":"Overall, I\u0027m good with this as-is since it is just extra information if someone wishes to cross-link.","commit_id":"fe633a74661cc4fb79cef2e5a54ec5d6f1022525"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c601d8bca655c719605393758f8f3a57e1b4d394","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f474511a_2145e3e6","updated":"2025-09-02 16:30:07.000000000","message":"Waiting for Dmitry before landing this","commit_id":"fe633a74661cc4fb79cef2e5a54ec5d6f1022525"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"c2594d58898e3194bc5f66601ed50bcd91d32f15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"18b276e1_9f5621a2","updated":"2025-09-22 18:20:31.000000000","message":"recheck post failure","commit_id":"fe633a74661cc4fb79cef2e5a54ec5d6f1022525"}],"ironic/drivers/modules/redfish/management.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1d5dee16c8dcd1543272e013af859c3920f59946","unresolved":true,"context_lines":[{"line_number":654,"context_line":"            \u0027UUID\u0027: system.uuid"},{"line_number":655,"context_line":"        }"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"        sensors[\u0027Extra\u0027] \u003d baremetal_fields"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        for chassis in system.chassis:"},{"line_number":660,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"2ed83cc7_c40c2213","line":657,"updated":"2025-09-02 14:06:25.000000000","message":"What is the reason to put these fields under \"Extra\"?","commit_id":"fe633a74661cc4fb79cef2e5a54ec5d6f1022525"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"06ecbc96af6cae6f6cbc328fe05c5368962bcca9","unresolved":true,"context_lines":[{"line_number":654,"context_line":"            \u0027UUID\u0027: system.uuid"},{"line_number":655,"context_line":"        }"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"        sensors[\u0027Extra\u0027] \u003d baremetal_fields"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        for chassis in system.chassis:"},{"line_number":660,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"4f41aaa0_7cd894ca","line":657,"in_reply_to":"26b3c799_640c90c8","updated":"2025-09-02 14:47:18.000000000","message":"I think _filter_out_unsupported_types may break both approaches","commit_id":"fe633a74661cc4fb79cef2e5a54ec5d6f1022525"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"76e72f54d8159b578a5074ebea1e7c91dcb3b463","unresolved":true,"context_lines":[{"line_number":654,"context_line":"            \u0027UUID\u0027: system.uuid"},{"line_number":655,"context_line":"        }"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"        sensors[\u0027Extra\u0027] \u003d baremetal_fields"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        for chassis in system.chassis:"},{"line_number":660,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"441b69ac_5706c316","line":657,"in_reply_to":"2ed83cc7_c40c2213","updated":"2025-09-02 14:18:07.000000000","message":"The current struct we have for the message is\n{\n    \u0027message_id\u0027: \u00278b93d7f3-67e3-4b63-8bad-e314c9c987de\u0027,\n    \u0027publisher_id\u0027: \u0027None.hardprov-fx2-26.tripleo.lab.eng.rdu2.redhat.com\u0027,\n    \u0027event_type\u0027: \u0027hardware.idrac.metrics\u0027,\n    \u0027priority\u0027: \u0027INFO\u0027,\n    \u0027payload\u0027: {\n        \u0027message_id\u0027: \u0027f2d37e51-c6bc-4070-a672-382779393d10\u0027,\n        \u0027instance_uuid\u0027: None,\n        \u0027node_uuid\u0027: \u0027fe81395b-1999-4ab4-8eb0-235e1ab02778\u0027,\n        \u0027timestamp\u0027: \u00272025-06-27T16:58:36.884084\u0027,\n        \u0027node_name\u0027: \u0027r640-u12\u0027,\n        \u0027event_type\u0027: \u0027hardware.idrac.metrics.update\u0027,\n        \u0027payload\u0027: { \n               \u0027Fan\u0027: {}, \n               \u0027Temperature\u0027: {},\n               \u0027Power\u0027: {}, \n               \u0027Drive\u0027: {}\n        }\n    }\n}\n\n\nIf we want the information on the first payload together with `instance_uuid`, `node_uuid` and `node_name` the change would need to happen on https://github.com/openstack/ironic/blob/24ab604a512c0887fc3846b21f7f78bd43ad7284/ironic/conductor/manager.py, but we would be adding redfish info there (which doesn\u0027t make sense to me..), so I told him it would be better to have the extra information from redfish in the same place we retrieve the payload for the sensors, so we can re-use the information from the system.","commit_id":"fe633a74661cc4fb79cef2e5a54ec5d6f1022525"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"cbf12c73311a36a84d1cbf117e3249b9debd6011","unresolved":true,"context_lines":[{"line_number":654,"context_line":"            \u0027UUID\u0027: system.uuid"},{"line_number":655,"context_line":"        }"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"        sensors[\u0027Extra\u0027] \u003d baremetal_fields"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        for chassis in system.chassis:"},{"line_number":660,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"26b3c799_640c90c8","line":657,"in_reply_to":"441b69ac_5706c316","updated":"2025-09-02 14:24:16.000000000","message":"Oh the Extra I thought it would make things looking better see https://paste.opendev.org/show/b4FyuVUW48lxq6x8FHK6/","commit_id":"fe633a74661cc4fb79cef2e5a54ec5d6f1022525"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"8c2686aebf4ad1c1b1ff4531b8ba2217f090dbab","unresolved":true,"context_lines":[{"line_number":654,"context_line":"            \u0027UUID\u0027: system.uuid"},{"line_number":655,"context_line":"        }"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"        sensors[\u0027Extra\u0027] \u003d baremetal_fields"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        for chassis in system.chassis:"},{"line_number":660,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"325671a1_01513a3b","line":657,"in_reply_to":"4f41aaa0_7cd894ca","updated":"2025-09-02 15:15:10.000000000","message":"On bifrost I didn\u0027t have any problems\n\n```\n{\n\t\u0027message_id\u0027: \u0027c644f714-da5b-4bc0-b156-5c212f1ca6ee\u0027, \n\t\u0027publisher_id\u0027: \u0027\u0027, \n\t\u0027event_type\u0027: \u0027hardware.idrac.metrics\u0027, \n\t\u0027priority\u0027: \u0027INFO\u0027, \n\t\u0027payload\u0027: {\n\t\t\u0027message_id\u0027: \u002761e0eaf1-4aef-4e95-ba4f-d8f060c9db6b\u0027, \n\t\t\u0027instance_uuid\u0027: None, \n\t\t\u0027node_uuid\u0027: \u002711111111-1111-3333-4444-555555555555\u0027, \n\t\t\u0027timestamp\u0027: \u00272025-09-02T15:09:23.551197\u0027, \n\t\t\u0027node_name\u0027: \u0027idrac10-r7715\u0027, \n\t\t\u0027event_type\u0027: \u0027hardware.idrac.metrics.update\u0027, \n\t\t\u0027payload\u0027: {\n\t\t\t\u0027Extra\u0027: {\u0027Manufacturer\u0027: \u0027Dell Inc.\u0027, \u0027Model\u0027: \u0027System\u0027, \u0027UUID\u0027: \u00274c4c4544-004c-3310-8035-c6c04f303534\u0027}, \n\t\t\t\u0027Fan\u0027: {}, \n\t\t\t\u0027Temperature\u0027: {}, \n\t\t\t\u0027Power\u0027: {}, \n\t\t\t\u0027Drive\u0027: {}\n\t\t}\n\t}, \n\t\u0027timestamp\u0027: \u00272025-09-02 15:09:27.355917\u0027\n}\n```","commit_id":"fe633a74661cc4fb79cef2e5a54ec5d6f1022525"}]}