)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a068058848c9e9369a42077249c4034bac017398","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ead21e37_1d92b35c","updated":"2025-09-11 15:06:24.000000000","message":"This needs a release note at a minimum. Ideally we\u0027d also document this in our docs. \n\nYou can add these by: \n`tox -ereleasenotes -- echo`\n`. .tox/releasenotes/bin/activate`\n`reno new a-short-description-of-change`\n\nThis will create a new yaml file in the notes folder which you can edit to contain information about your fix. Feel free to reach out in IRC or here if you need a hand.\n\nMy other question: are these node.properties[vendor] set via inspection on these servers?","commit_id":"abb3c595e5fb00576ba023a48cc05833c374d0fe"},{"author":{"_account_id":38375,"name":"Mohamed EL HADDAD","display_name":"Mohamed","email":"mohamed.el-haddad@ovhcloud.com","username":"mhmd-hdd"},"change_message_id":"a1f516d5501e411897dda26673d9c8232e5c2694","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ecb8e65f_0f967851","in_reply_to":"ead21e37_1d92b35c","updated":"2025-09-11 15:13:14.000000000","message":"Thanks for the guidance! I’ll work on adding the release note with reno and will check where the docs should be updated.\n\nAnd yes — on these ASRock Rack servers, the node.properties[\u0027vendor\u0027] is set during inspection.\nAppreciate the help!","commit_id":"abb3c595e5fb00576ba023a48cc05833c374d0fe"},{"author":{"_account_id":38375,"name":"Mohamed EL HADDAD","display_name":"Mohamed","email":"mohamed.el-haddad@ovhcloud.com","username":"mhmd-hdd"},"change_message_id":"57904e65b7cb584ef93fef166afcd334f02ac12f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a0ec7e11_b72cedcc","in_reply_to":"ecb8e65f_0f967851","updated":"2025-09-12 07:23:37.000000000","message":"Done","commit_id":"abb3c595e5fb00576ba023a48cc05833c374d0fe"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"5b9c2b8cd24878e6f2a0e62acf1865bdd3e89121","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"11de01db_4f06eec0","updated":"2025-09-16 17:21:21.000000000","message":"@juliaashleykreger@gmail.com @dtantsur@protonmail.com This has pangs of that quirks patch for Sushy I\u0027ve thrown out there.","commit_id":"54977a14d57c8c56e9b25a65e4c8ccd2b9fabb7a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"375cebcdc42df9fe243ea6b35dd7a129829ac3c0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1e4e7da9_76458af4","updated":"2025-09-11 16:04:23.000000000","message":"Given we\u0027re using vendor values set in inspection, I\u0027m not sure there will be a place in the docs to update. Please do so if you find one but my vote won\u0027t be blocked on it.\n\nGonna see how CI likes the change before core-reviewing.","commit_id":"54977a14d57c8c56e9b25a65e4c8ccd2b9fabb7a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3fbb2f99695accaace5b470d5d78b037ffb4c521","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8c1fabfa_1a660565","in_reply_to":"11de01db_4f06eec0","updated":"2025-09-23 18:47:14.000000000","message":"Yeah, we\u0027ve had vendors muse with this multiple times and even briefly had a version of dell firmware that required this behavior before they yanked it and fixed it.  Also, some vendors entirely blowup on this too. Ugh.  Anyhow, I do like this solution since its not really otherwise detectable through interaction. We only know because we\u0027ve had to do the investigation separately.","commit_id":"54977a14d57c8c56e9b25a65e4c8ccd2b9fabb7a"},{"author":{"_account_id":38375,"name":"Mohamed EL HADDAD","display_name":"Mohamed","email":"mohamed.el-haddad@ovhcloud.com","username":"mhmd-hdd"},"change_message_id":"57904e65b7cb584ef93fef166afcd334f02ac12f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"165af4e4_3bd3f61e","in_reply_to":"1e4e7da9_76458af4","updated":"2025-09-12 07:23:37.000000000","message":"Thanks! I’ll check if there’s a relevant place in the docs.\nAppreciate the review!\n\nEdit: The functions are used internally, so I don’t think there’s a place in the user-facing docs to update.","commit_id":"54977a14d57c8c56e9b25a65e4c8ccd2b9fabb7a"}],"ironic/drivers/modules/redfish/management.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3fbb2f99695accaace5b470d5d78b037ffb4c521","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    try:"},{"line_number":165,"context_line":"        # NOTE(TheJulia): In sushy, it is uri, due to the convention used"},{"line_number":166,"context_line":"        # in the standard. URL is used internally in ironic."},{"line_number":167,"context_line":"        if requires_full_boot_request:"},{"line_number":168,"context_line":"            # Some vendors require sending all boot parameters every time"},{"line_number":169,"context_line":"            desired_mode \u003d system.boot.get(\u0027mode\u0027) \\"},{"line_number":170,"context_line":"                or sushy.BOOT_SOURCE_MODE_UEFI"}],"source_content_type":"text/x-python","patch_set":4,"id":"ec21e34b_91ca9835","line":167,"updated":"2025-09-23 18:47:14.000000000","message":"I have been waiting for a patch like this. Thanks!","commit_id":"54977a14d57c8c56e9b25a65e4c8ccd2b9fabb7a"}]}