)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"692fd11fdcbd9c624851a947c9a4e050e05a9e3d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5cdc6958_ccb2bfba","updated":"2025-09-15 17:51:41.000000000","message":"I\u0027m really confused about the full story here:\n- This change appears to be all about inspection and DHCP\n- DHCP isn\u0027t even mentioned in https://opendev.org/openstack/ironic-specs/commit/aaa37c0fc3ab920dfa8ae2bfe61c3a2de0066f7d\n\nCan you help me understand how this fits into the bigger picture?\n\nAlso, even if it was OK as-is, it still would need a release note.","commit_id":"85d27a166b2634b054b5cd5afaed434505fd7a5f"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"97afaf7073c2142372bcbb2b731b0193191e4178","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4cabf395_6327fdb8","in_reply_to":"5cdc6958_ccb2bfba","updated":"2025-09-15 18:25:14.000000000","message":"Hi JayF,\nSorry, yes, sorry... Take a look at this change to the spec:  https://review.opendev.org/c/openstack/ironic-specs/+/960550\n\nI realized that in order for this to work properly we need the switch ports to be enabled ahead of time so that we can get LLDP information.  \n\nMy proposal is that we \u0027park\u0027 the nodes on the inspection VLAN and then they can be dynamically moved to their intended VLAN when they are provisioned/deployed.  To do that it means that the static network data that may be provided when the node is enrolled likely won\u0027t be valid on the inspection VLAN so it would be best to make it ignore that static data and instead DHCP on that network to get an address for the purpose of inspection.","commit_id":"85d27a166b2634b054b5cd5afaed434505fd7a5f"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"381d5907bf1cb47695c68bef0bab674e9ee1d897","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9ef5aa06_e2d3993e","updated":"2025-09-22 20:36:46.000000000","message":"@jay@jvf.cc, @cardoe@cardoe.com ... I\u0027ve updated the change to rename the option as suggested as well as the commit title/message.","commit_id":"cb3435c9f114b3c7d1eca8bc6c244e30f2d4a94a"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"3c6ee509f652773ebb8088d42637bcf6fc541071","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ec99419b_a4afdaec","updated":"2025-09-22 14:58:25.000000000","message":"Given the current parameters update, can we update the commit message and commit title to reflect the new option name as well?","commit_id":"cb3435c9f114b3c7d1eca8bc6c244e30f2d4a94a"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"381d5907bf1cb47695c68bef0bab674e9ee1d897","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"08b3ee75_3b99032a","in_reply_to":"ec99419b_a4afdaec","updated":"2025-09-22 20:36:46.000000000","message":"@cardoe@cardoe.com ... Thanks, I\u0027ve updated the commit title/message.","commit_id":"cb3435c9f114b3c7d1eca8bc6c244e30f2d4a94a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3b4daf7e8d2a06c7ba91c8bb6f6cf5eb79d2e487","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"192214c6_05db6165","updated":"2025-09-25 21:25:52.000000000","message":"The +1 instead of +2 is b/c this seems like something we should have the spec landed for before we land patches for.","commit_id":"1a4a645aff7a344cd0b3fe1f2c1d63902a54fa94"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"9f44ca4da865a185c33521a7296ff75457d23929","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fc32e80c_86611017","updated":"2025-10-02 16:50:49.000000000","message":"LGTM, one nit.","commit_id":"7ae28aa4755aeb87fc1b2e3fe171650e19ef67d6"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"2f4890aade751ad2faad5c6367e5be802ac96e70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"54d05a41_d0d554e7","updated":"2025-10-06 23:26:03.000000000","message":"recheck","commit_id":"5a4ce557fc709c798ad40a8f60cc0fbd832502a1"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"c14a4e50481c8be35cfe352b7fab31261f71c8fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"af64466c_aaf8c2cb","updated":"2025-10-06 13:44:36.000000000","message":"recheck","commit_id":"5a4ce557fc709c798ad40a8f60cc0fbd832502a1"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"0629dbdefca50d1d7d9e37680bf74dcf5103b2d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b30e7581_ba1de6d1","updated":"2025-10-14 12:49:34.000000000","message":"recheck","commit_id":"eb3334511e9f968ce2bfa196b92992116f8d2c7d"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"69e06af74fe60dc9350b4793bad7ff2cec937d15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"db0d2e58_7bc6332c","updated":"2025-10-28 12:06:13.000000000","message":"recheck","commit_id":"3b5503199321a5fae8651ab7fa15f4101920e1fa"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"3826cc6b948e0c11422a26a30ddab69f37628d28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"faaccbba_a94093be","updated":"2025-10-27 12:02:21.000000000","message":"recheck","commit_id":"3b5503199321a5fae8651ab7fa15f4101920e1fa"}],"ironic/conf/inspector.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"692fd11fdcbd9c624851a947c9a4e050e05a9e3d","unresolved":true,"context_lines":[{"line_number":52,"context_line":"                       \u0027interfaces and avoid injecting any static network \u0027"},{"line_number":53,"context_line":"                       \u0027configuration into the virtual media ISO. This \u0027"},{"line_number":54,"context_line":"                       \u0027disables DHCP-less/L3 inspection and helps ensure \u0027"},{"line_number":55,"context_line":"                       \u0027LLDP collection across all interfaces.\u0027)),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027extra_kernel_params\u0027, default\u003d\u0027\u0027,"},{"line_number":57,"context_line":"               help\u003d_(\u0027extra kernel parameters to pass to the inspection \u0027"},{"line_number":58,"context_line":"                      \u0027ramdisk when boot is managed by ironic (not \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ae37ab25_0782cc00","line":55,"updated":"2025-09-15 17:51:41.000000000","message":"This option seems maybe overloaded? An option named \"dhcp_all_interfaces\" shouldn\u0027t, IMO, have non-DHCP related side effects. Perhaps there\u0027s a better way to express this?","commit_id":"85d27a166b2634b054b5cd5afaed434505fd7a5f"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"381d5907bf1cb47695c68bef0bab674e9ee1d897","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                       \u0027interfaces and avoid injecting any static network \u0027"},{"line_number":53,"context_line":"                       \u0027configuration into the virtual media ISO. This \u0027"},{"line_number":54,"context_line":"                       \u0027disables DHCP-less/L3 inspection and helps ensure \u0027"},{"line_number":55,"context_line":"                       \u0027LLDP collection across all interfaces.\u0027)),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027extra_kernel_params\u0027, default\u003d\u0027\u0027,"},{"line_number":57,"context_line":"               help\u003d_(\u0027extra kernel parameters to pass to the inspection \u0027"},{"line_number":58,"context_line":"                      \u0027ramdisk when boot is managed by ironic (not \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"c164099d_dc701f09","line":55,"in_reply_to":"370bc0ff_f544ef74","updated":"2025-09-22 20:36:46.000000000","message":"Done","commit_id":"85d27a166b2634b054b5cd5afaed434505fd7a5f"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"97afaf7073c2142372bcbb2b731b0193191e4178","unresolved":true,"context_lines":[{"line_number":52,"context_line":"                       \u0027interfaces and avoid injecting any static network \u0027"},{"line_number":53,"context_line":"                       \u0027configuration into the virtual media ISO. This \u0027"},{"line_number":54,"context_line":"                       \u0027disables DHCP-less/L3 inspection and helps ensure \u0027"},{"line_number":55,"context_line":"                       \u0027LLDP collection across all interfaces.\u0027)),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027extra_kernel_params\u0027, default\u003d\u0027\u0027,"},{"line_number":57,"context_line":"               help\u003d_(\u0027extra kernel parameters to pass to the inspection \u0027"},{"line_number":58,"context_line":"                      \u0027ramdisk when boot is managed by ironic (not \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"370bc0ff_f544ef74","line":55,"in_reply_to":"ae37ab25_0782cc00","updated":"2025-09-15 18:25:14.000000000","message":"Saw your comment in the spec update.  I\u0027ll revise this with the new name.","commit_id":"85d27a166b2634b054b5cd5afaed434505fd7a5f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"570e0994e6f3b845b1eb9dd0402929802e768210","unresolved":true,"context_lines":[{"line_number":46,"context_line":"    cfg.IntOpt(\u0027status_check_period\u0027, default\u003d60,"},{"line_number":47,"context_line":"               help\u003d_(\u0027period (in seconds) to check status of nodes \u0027"},{"line_number":48,"context_line":"                      \u0027on inspection\u0027)),"},{"line_number":49,"context_line":"    cfg.BoolOpt(\u0027inspect_all_interfaces\u0027, default\u003dFalse,"},{"line_number":50,"context_line":"                help\u003d_(\u0027If True, during managed inspection force the \u0027"},{"line_number":51,"context_line":"                       \u0027inspection ramdisk to use DHCP on all available \u0027"},{"line_number":52,"context_line":"                       \u0027interfaces and avoid injecting any static network \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"b7a28e80_0f34076e","line":49,"updated":"2025-09-23 16:54:31.000000000","message":"I guess I\u0027m a little hesitant because this is creating a behavior which most would normally expect from a ramdisk out of the box, dhcp on everything. Which then creates an expectation the agent triggers it... which is a whole other ball of wax.\n\nI guess some discussion would be helpful, but maybe contextual predication is necessary, dunno.\n\nFollow-up: I think this would just be best with a different name \"force_inspection_dhcp\" ?","commit_id":"2b9e3a4896d31784ae8ec015a586a893db18ff87"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"57df6b9fb0337efd087e9e03a9071ba3a859bbdf","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    cfg.IntOpt(\u0027status_check_period\u0027, default\u003d60,"},{"line_number":47,"context_line":"               help\u003d_(\u0027period (in seconds) to check status of nodes \u0027"},{"line_number":48,"context_line":"                      \u0027on inspection\u0027)),"},{"line_number":49,"context_line":"    cfg.BoolOpt(\u0027inspect_all_interfaces\u0027, default\u003dFalse,"},{"line_number":50,"context_line":"                help\u003d_(\u0027If True, during managed inspection force the \u0027"},{"line_number":51,"context_line":"                       \u0027inspection ramdisk to use DHCP on all available \u0027"},{"line_number":52,"context_line":"                       \u0027interfaces and avoid injecting any static network \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"4db45b8d_4751a30b","line":49,"in_reply_to":"b7a28e80_0f34076e","updated":"2025-09-24 18:04:21.000000000","message":"Ok.  Name changed.","commit_id":"2b9e3a4896d31784ae8ec015a586a893db18ff87"}],"ironic/drivers/modules/image_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"570e0994e6f3b845b1eb9dd0402929802e768210","unresolved":true,"context_lines":[{"line_number":593,"context_line":"    # inspection on all interfaces is requested."},{"line_number":594,"context_line":"    skip_network_data \u003d ("},{"line_number":595,"context_line":"        task.node.provision_state in (states.INSPECTING, states.INSPECTWAIT)"},{"line_number":596,"context_line":"        and CONF.inspector.inspect_all_interfaces"},{"line_number":597,"context_line":"    )"},{"line_number":598,"context_line":"    if not skip_network_data:"},{"line_number":599,"context_line":"        network_data \u003d task.driver.network.get_node_network_data(task)"}],"source_content_type":"text/x-python","patch_set":3,"id":"e99da7cd_c0ca3dab","line":596,"range":{"start_line":596,"start_character":12,"end_line":596,"end_character":49},"updated":"2025-09-23 16:54:31.000000000","message":"Maybe just a different name for the option? Since we\u0027re effectively skipping configuration injection.","commit_id":"2b9e3a4896d31784ae8ec015a586a893db18ff87"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"57df6b9fb0337efd087e9e03a9071ba3a859bbdf","unresolved":false,"context_lines":[{"line_number":593,"context_line":"    # inspection on all interfaces is requested."},{"line_number":594,"context_line":"    skip_network_data \u003d ("},{"line_number":595,"context_line":"        task.node.provision_state in (states.INSPECTING, states.INSPECTWAIT)"},{"line_number":596,"context_line":"        and CONF.inspector.inspect_all_interfaces"},{"line_number":597,"context_line":"    )"},{"line_number":598,"context_line":"    if not skip_network_data:"},{"line_number":599,"context_line":"        network_data \u003d task.driver.network.get_node_network_data(task)"}],"source_content_type":"text/x-python","patch_set":3,"id":"04c743c2_60799c9d","line":596,"range":{"start_line":596,"start_character":12,"end_line":596,"end_character":49},"in_reply_to":"e99da7cd_c0ca3dab","updated":"2025-09-24 18:04:21.000000000","message":"Ok.  Name changed.","commit_id":"2b9e3a4896d31784ae8ec015a586a893db18ff87"}],"ironic/drivers/modules/inspector/interface.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"692fd11fdcbd9c624851a947c9a4e050e05a9e3d","unresolved":true,"context_lines":[{"line_number":156,"context_line":"    if CONF.inspector.dhcp_all_interfaces:"},{"line_number":157,"context_line":"        # Only set if not explicitly provided by operator."},{"line_number":158,"context_line":"        params.setdefault(\u0027ipa-dhcp-all-interfaces\u0027, \u00271\u0027)"},{"line_number":159,"context_line":"        params.setdefault(\u0027ipa-collect-lldp\u0027, \u00271\u0027)"},{"line_number":160,"context_line":"    if utils.fast_track_enabled(task.node):"},{"line_number":161,"context_line":"        params[\u0027ipa-api-url\u0027] \u003d deploy_utils.get_ironic_api_url()"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a2178d38_fdcb3b0b","line":159,"updated":"2025-09-15 17:51:41.000000000","message":"comment is weird/wrong --- it says requested, but AFAICT we\u0027re only checking the dhcp_all_interfaces setting; nothing related to lldp","commit_id":"85d27a166b2634b054b5cd5afaed434505fd7a5f"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"381d5907bf1cb47695c68bef0bab674e9ee1d897","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    if CONF.inspector.dhcp_all_interfaces:"},{"line_number":157,"context_line":"        # Only set if not explicitly provided by operator."},{"line_number":158,"context_line":"        params.setdefault(\u0027ipa-dhcp-all-interfaces\u0027, \u00271\u0027)"},{"line_number":159,"context_line":"        params.setdefault(\u0027ipa-collect-lldp\u0027, \u00271\u0027)"},{"line_number":160,"context_line":"    if utils.fast_track_enabled(task.node):"},{"line_number":161,"context_line":"        params[\u0027ipa-api-url\u0027] \u003d deploy_utils.get_ironic_api_url()"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"613a0a57_b3804b70","line":159,"in_reply_to":"693a637c_f5b55432","updated":"2025-09-22 20:36:46.000000000","message":"Done","commit_id":"85d27a166b2634b054b5cd5afaed434505fd7a5f"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"97afaf7073c2142372bcbb2b731b0193191e4178","unresolved":true,"context_lines":[{"line_number":156,"context_line":"    if CONF.inspector.dhcp_all_interfaces:"},{"line_number":157,"context_line":"        # Only set if not explicitly provided by operator."},{"line_number":158,"context_line":"        params.setdefault(\u0027ipa-dhcp-all-interfaces\u0027, \u00271\u0027)"},{"line_number":159,"context_line":"        params.setdefault(\u0027ipa-collect-lldp\u0027, \u00271\u0027)"},{"line_number":160,"context_line":"    if utils.fast_track_enabled(task.node):"},{"line_number":161,"context_line":"        params[\u0027ipa-api-url\u0027] \u003d deploy_utils.get_ironic_api_url()"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"693a637c_f5b55432","line":159,"in_reply_to":"a2178d38_fdcb3b0b","updated":"2025-09-15 18:25:14.000000000","message":"Wasn\u0027t sure how to handle this and having 2 separate options seemed like it might overcomplicate things.  I saw your comment in the spec about renaming this to \"inspect_all_interfaces\".  That seems like a good choice to me.","commit_id":"85d27a166b2634b054b5cd5afaed434505fd7a5f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"22b1c4e372e60df09552165e3bdf0a18be1851e3","unresolved":true,"context_lines":[{"line_number":154,"context_line":"        **{\u0027ipa-inspection-callback-url\u0027: endpoint})"},{"line_number":155,"context_line":"    if CONF.inspector.force_inspection_dhcp:"},{"line_number":156,"context_line":"        # Ensure DHCP and LLDP collection for inspection on all interfaces."},{"line_number":157,"context_line":"        params.setdefault(\u0027ipa-dhcp-all-interfaces\u0027, \u00271\u0027)"},{"line_number":158,"context_line":"        params.setdefault(\u0027ipa-collect-lldp\u0027, \u00271\u0027)"},{"line_number":159,"context_line":"    if utils.fast_track_enabled(task.node):"},{"line_number":160,"context_line":"        params[\u0027ipa-api-url\u0027] \u003d deploy_utils.get_ironic_api_url()"}],"source_content_type":"text/x-python","patch_set":8,"id":"0b043d28_b31a28ab","line":157,"updated":"2025-10-01 14:46:42.000000000","message":"Seems like this requires an IPA change? Can we get a depends-on added covering this?","commit_id":"7ae28aa4755aeb87fc1b2e3fe171650e19ef67d6"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"a2aaddc0b63cd5dd465ea65ac850cff16923e854","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        **{\u0027ipa-inspection-callback-url\u0027: endpoint})"},{"line_number":155,"context_line":"    if CONF.inspector.force_inspection_dhcp:"},{"line_number":156,"context_line":"        # Ensure DHCP and LLDP collection for inspection on all interfaces."},{"line_number":157,"context_line":"        params.setdefault(\u0027ipa-dhcp-all-interfaces\u0027, \u00271\u0027)"},{"line_number":158,"context_line":"        params.setdefault(\u0027ipa-collect-lldp\u0027, \u00271\u0027)"},{"line_number":159,"context_line":"    if utils.fast_track_enabled(task.node):"},{"line_number":160,"context_line":"        params[\u0027ipa-api-url\u0027] \u003d deploy_utils.get_ironic_api_url()"}],"source_content_type":"text/x-python","patch_set":8,"id":"661c8a99_d474a45a","line":157,"in_reply_to":"0b043d28_b31a28ab","updated":"2025-10-02 21:07:12.000000000","message":"My mistake.  Removed the ipa-dhcp-all-interfaces option.","commit_id":"7ae28aa4755aeb87fc1b2e3fe171650e19ef67d6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ac682be0ccc3799788276af659eb3cbf0456c7e7","unresolved":true,"context_lines":[{"line_number":154,"context_line":"        **{\u0027ipa-inspection-callback-url\u0027: endpoint})"},{"line_number":155,"context_line":"    if CONF.inspector.force_dhcp:"},{"line_number":156,"context_line":"        # Ensure LLDP collection for inspection on all interfaces."},{"line_number":157,"context_line":"        params.setdefault(\u0027ipa-collect-lldp\u0027, \u00271\u0027)"},{"line_number":158,"context_line":"    if utils.fast_track_enabled(task.node):"},{"line_number":159,"context_line":"        params[\u0027ipa-api-url\u0027] \u003d deploy_utils.get_ironic_api_url()"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"67f51efa_d3e1a6bd","line":157,"range":{"start_line":157,"start_character":8,"end_line":157,"end_character":50},"updated":"2025-11-03 18:39:38.000000000","message":"feels like we should just set/enable this by default at this point :\\","commit_id":"3b5503199321a5fae8651ab7fa15f4101920e1fa"}],"ironic/tests/unit/drivers/modules/test_image_utils.py":[{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"9f44ca4da865a185c33521a7296ff75457d23929","unresolved":true,"context_lines":[{"line_number":966,"context_line":""},{"line_number":967,"context_line":"            mock__prepare_iso_image.assert_called_once_with("},{"line_number":968,"context_line":"                task, \u0027kernel\u0027, \u0027ramdisk\u0027, bootloader_href\u003dNone,"},{"line_number":969,"context_line":"                params\u003d{}, inject_files\u003d{}, base_iso\u003dNone)"},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"    @mock.patch.object(image_utils, \u0027_prepare_iso_image\u0027, autospec\u003dTrue)"},{"line_number":972,"context_line":"    def test_prepare_deploy_iso_tls(self, mock__prepare_iso_image):"}],"source_content_type":"text/x-python","patch_set":8,"id":"b5002044_6a11101c","line":969,"range":{"start_line":969,"start_character":27,"end_line":969,"end_character":39},"updated":"2025-10-02 16:50:49.000000000","message":"nit: Comment that what we\u0027re testing for is that inject_files should be empty (ie no network_data.json).","commit_id":"7ae28aa4755aeb87fc1b2e3fe171650e19ef67d6"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"a2aaddc0b63cd5dd465ea65ac850cff16923e854","unresolved":false,"context_lines":[{"line_number":966,"context_line":""},{"line_number":967,"context_line":"            mock__prepare_iso_image.assert_called_once_with("},{"line_number":968,"context_line":"                task, \u0027kernel\u0027, \u0027ramdisk\u0027, bootloader_href\u003dNone,"},{"line_number":969,"context_line":"                params\u003d{}, inject_files\u003d{}, base_iso\u003dNone)"},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"    @mock.patch.object(image_utils, \u0027_prepare_iso_image\u0027, autospec\u003dTrue)"},{"line_number":972,"context_line":"    def test_prepare_deploy_iso_tls(self, mock__prepare_iso_image):"}],"source_content_type":"text/x-python","patch_set":8,"id":"8d25bd7e_0acdf6a7","line":969,"range":{"start_line":969,"start_character":27,"end_line":969,"end_character":39},"in_reply_to":"b5002044_6a11101c","updated":"2025-10-02 21:07:12.000000000","message":"Thanks you.  Updated the comment.","commit_id":"7ae28aa4755aeb87fc1b2e3fe171650e19ef67d6"}]}