)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"913e4a3c9108a7070c5e4a14e32331b14ce565e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"97443f8d_e316fbf1","updated":"2025-09-30 16:26:23.000000000","message":"LGTM but please check the CI","commit_id":"a55469c196f17f45f7a92f9ef86d09864b482ada"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"771eacd993715cf256080317afd84244b285b37a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f29dc2cc_ea5cfa37","updated":"2025-10-01 11:12:30.000000000","message":"Thank you for your review Dmitry. Tests pass now. Patch should be in a good shape. Despite this I will W-1 for now it until I test it on hardware to make sure it achieves the result I am hoping for.","commit_id":"a55469c196f17f45f7a92f9ef86d09864b482ada"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"fa34362ea420b5fe74d7a358ab9d0bad9e3d6a3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f5fdd57_4a260ff6","updated":"2025-10-02 13:00:45.000000000","message":"let\u0027s test CI, then rebase.","commit_id":"a55469c196f17f45f7a92f9ef86d09864b482ada"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"771eacd993715cf256080317afd84244b285b37a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"54fab47e_b4ffb4bd","in_reply_to":"97443f8d_e316fbf1","updated":"2025-10-01 11:12:30.000000000","message":"Oops, sorry about that. Pushed the patch sooner than I should. Should be fixed now.","commit_id":"a55469c196f17f45f7a92f9ef86d09864b482ada"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"210975e54124a04228dd94bce7d808b79550fba5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ebf7d093_f83a6fa0","updated":"2025-10-03 10:49:33.000000000","message":"Rebase/merge of the tests across the chain is getting increasingly complicated, will leave tests out and add them in a follow-up. Meanwhile I will focus on testing.","commit_id":"c8cd043ed7b9313bfb9a608c7d0a5caf85a7abeb"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d29fb263704eacaea65b3fa2bf588a8d6ac9efcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"81b1dc02_e4c1b3f5","updated":"2025-10-23 12:48:49.000000000","message":"recheck metal3 failure","commit_id":"0be99039c58c4779e0fb299e2d120bc6bee26095"}],"ironic/drivers/modules/redfish/firmware.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1afecfaad4c964b1bc0bad43332cdae18403ac93","unresolved":true,"context_lines":[{"line_number":224,"context_line":"        # Check if BMC firmware is being updated - BMC may need extended"},{"line_number":225,"context_line":"        # timeout after firmware update as it transitions through states"},{"line_number":226,"context_line":"        has_bmc_update \u003d any("},{"line_number":227,"context_line":"            setting.get(\u0027component\u0027, \u0027\u0027).lower() \u003d\u003d \u0027bmc\u0027"},{"line_number":228,"context_line":"            for setting in settings"},{"line_number":229,"context_line":"        )"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"e3cdec4e_6373babc","line":227,"updated":"2025-10-17 01:47:19.000000000","message":"you can just do setting.get(\u0027component\u0027, \u0027\u0027) \u003d\u003d redfish_utils.BMC\n\nhttps://github.com/openstack/ironic/blob/26c72079356a2eeb45eaf0348797337ee5a95455/ironic/drivers/modules/redfish/utils.py#L91","commit_id":"c8cd043ed7b9313bfb9a608c7d0a5caf85a7abeb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9246ce637557f4e5db4ec9c3d177e93e3a9a176f","unresolved":true,"context_lines":[{"line_number":231,"context_line":"        # Use extended timeout for BMC updates to handle transitional states"},{"line_number":232,"context_line":"        if has_bmc_update:"},{"line_number":233,"context_line":"            # BMC needs more time after firmware update - use at least 300s"},{"line_number":234,"context_line":"            reboot_timeout \u003d max(wait_interval or 60, 300)"},{"line_number":235,"context_line":"            LOG.info(\u0027BMC firmware update detected, using extended reboot \u0027"},{"line_number":236,"context_line":"                     \u0027timeout of %(timeout)s seconds for node %(node)s to \u0027"},{"line_number":237,"context_line":"                     \u0027handle BMC transitional states\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"e4892993_f41f55bd","line":234,"range":{"start_line":234,"start_character":54,"end_line":234,"end_character":57},"updated":"2025-10-03 18:45:52.000000000","message":"This really should be configurable....","commit_id":"c8cd043ed7b9313bfb9a608c7d0a5caf85a7abeb"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1afecfaad4c964b1bc0bad43332cdae18403ac93","unresolved":true,"context_lines":[{"line_number":231,"context_line":"        # Use extended timeout for BMC updates to handle transitional states"},{"line_number":232,"context_line":"        if has_bmc_update:"},{"line_number":233,"context_line":"            # BMC needs more time after firmware update - use at least 300s"},{"line_number":234,"context_line":"            reboot_timeout \u003d max(wait_interval or 60, 300)"},{"line_number":235,"context_line":"            LOG.info(\u0027BMC firmware update detected, using extended reboot \u0027"},{"line_number":236,"context_line":"                     \u0027timeout of %(timeout)s seconds for node %(node)s to \u0027"},{"line_number":237,"context_line":"                     \u0027handle BMC transitional states\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ba2b52a_69ab1aa8","line":234,"range":{"start_line":234,"start_character":54,"end_line":234,"end_character":57},"in_reply_to":"e4892993_f41f55bd","updated":"2025-10-17 01:47:19.000000000","message":"Agreee, we had CONF.redfish.firmware_update_wait_unresponsive_bmc, I\u0027m wondering if we can re-use or create a new config.","commit_id":"c8cd043ed7b9313bfb9a608c7d0a5caf85a7abeb"}],"releasenotes/notes/bmc-firmware-timeout-fix-328e09ff98f9348f.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"913e4a3c9108a7070c5e4a14e32331b14ce565e4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed BMC firmware update timeout issues by using extended timeout"},{"line_number":5,"context_line":"    (minimum 5 minutes) for BMC firmware updates to handle BMC transitional"},{"line_number":6,"context_line":"    states during firmware update process."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a80f3eac_97bbe0f7","line":4,"updated":"2025-09-30 16:26:23.000000000","message":"nit: Fixes","commit_id":"a55469c196f17f45f7a92f9ef86d09864b482ada"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"771eacd993715cf256080317afd84244b285b37a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed BMC firmware update timeout issues by using extended timeout"},{"line_number":5,"context_line":"    (minimum 5 minutes) for BMC firmware updates to handle BMC transitional"},{"line_number":6,"context_line":"    states during firmware update process."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b7ef0c05_4b64080a","line":4,"in_reply_to":"a80f3eac_97bbe0f7","updated":"2025-10-01 11:12:30.000000000","message":"Done","commit_id":"a55469c196f17f45f7a92f9ef86d09864b482ada"}]}