)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5d205d360f9b69aa39b3f212a16835ba7ea2b685","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"716c9986_d1ce7f24","updated":"2025-11-11 18:22:13.000000000","message":"A couple more comments you may really want to consider","commit_id":"f8a0de8a569ae7498bdb778ab3b903e790c5eb28"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d26a246165c724a12dd368da1f91c715605bd318","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75be1523_bda56856","updated":"2025-11-10 14:40:43.000000000","message":"Nothing against the feature, but the link with adoption seems wrong to me, and the docs are misleading.","commit_id":"f8a0de8a569ae7498bdb778ab3b903e790c5eb28"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"d982b1fce45c1a7720b0ccb26b8a8b14f34d5fab","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5dcf1ab0_0f5d808f","updated":"2025-11-18 16:16:30.000000000","message":"@dtantsur@protonmail.com did the most recent change address your concerns?","commit_id":"bcae66f199235baa60f0d389d92028616e92eec7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e3aa2f058e5aa8c95371ad686f36e473bd92987","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cf99ecbb_3dfa0292","updated":"2025-11-18 16:25:52.000000000","message":"LGTM, but please follow-up with a small documentation tweak.","commit_id":"bcae66f199235baa60f0d389d92028616e92eec7"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"24fd63f0e625106c90e1962dc9976b4f2c7d4bc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cb3b8ff5_5bf49b65","updated":"2025-11-18 06:50:23.000000000","message":"recheck - TIMEOUTS","commit_id":"bcae66f199235baa60f0d389d92028616e92eec7"}],"doc/source/admin/interfaces/deploy.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d26a246165c724a12dd368da1f91c715605bd318","unresolved":true,"context_lines":[{"line_number":334,"context_line":"    baremetal node adopt \u003cNODE\u003e"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"The node will transition to ``active`` state without any actual provisioning"},{"line_number":337,"context_line":"taking place."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":".. note::"},{"line_number":340,"context_line":"   The ``noop`` deploy interface requires no configuration and accepts any"}],"source_content_type":"text/x-rst","patch_set":1,"id":"81bcc059_b33d8511","line":337,"updated":"2025-11-10 14:40:43.000000000","message":"This is misleading. Adoption always work like this, regardless of the deploy interface. Please remove the section on adoption and add something on your actual use case.","commit_id":"f8a0de8a569ae7498bdb778ab3b903e790c5eb28"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"29797efac34d64fe004eea8e7e4707ed0cfee9ee","unresolved":true,"context_lines":[{"line_number":334,"context_line":"    baremetal node adopt \u003cNODE\u003e"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"The node will transition to ``active`` state without any actual provisioning"},{"line_number":337,"context_line":"taking place."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":".. note::"},{"line_number":340,"context_line":"   The ``noop`` deploy interface requires no configuration and accepts any"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6421f42c_93df7796","line":337,"in_reply_to":"55c81e67_785416b4","updated":"2025-11-11 14:21:59.000000000","message":"Alternative is to add an explicit note, something like:\n\n.. note:: The adopt api verb does not explicitly require use of the ``noop`` deployment interface. While the adoption workflow will attempt to lay some groudwork by default, the ``noop`` deploy interface may be advisable when wanting to ensure all conductor side deployment actions are skipped.\n\nAlternatively, it can be followed-up with such a note to provide clarity.","commit_id":"f8a0de8a569ae7498bdb778ab3b903e790c5eb28"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4ed167be4faa992cb1ccf030fd64e127add64b9d","unresolved":true,"context_lines":[{"line_number":334,"context_line":"    baremetal node adopt \u003cNODE\u003e"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"The node will transition to ``active`` state without any actual provisioning"},{"line_number":337,"context_line":"taking place."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":".. note::"},{"line_number":340,"context_line":"   The ``noop`` deploy interface requires no configuration and accepts any"}],"source_content_type":"text/x-rst","patch_set":1,"id":"63093aa4_07a6df2b","line":337,"in_reply_to":"6421f42c_93df7796","updated":"2025-11-11 18:09:24.000000000","message":"If this is about Nova, let\u0027s explicitly mention Nova.\n\nFurthermore, the implied Nova adoption will **not** use the `adopt` verb. What you\u0027re trying to explain here is an alternative approach to adoption by using the normal `deploy` verb instead of `adopt` for systems that support it.\n\nWithout this context, this addition is simply misleading.","commit_id":"f8a0de8a569ae7498bdb778ab3b903e790c5eb28"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7744f6a1cd90df49752e6d7f723f790bfe12d8f0","unresolved":true,"context_lines":[{"line_number":334,"context_line":"    baremetal node adopt \u003cNODE\u003e"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"The node will transition to ``active`` state without any actual provisioning"},{"line_number":337,"context_line":"taking place."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":".. note::"},{"line_number":340,"context_line":"   The ``noop`` deploy interface requires no configuration and accepts any"}],"source_content_type":"text/x-rst","patch_set":1,"id":"55c81e67_785416b4","line":337,"in_reply_to":"81bcc059_b33d8511","updated":"2025-11-10 21:17:43.000000000","message":"https://docs.openstack.org/ironic/latest/admin/adoption.html#adoption-with-nova\n\nIt kinda is adjacent to adoption with nova, but it\u0027s not really officially supported.","commit_id":"f8a0de8a569ae7498bdb778ab3b903e790c5eb28"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5d205d360f9b69aa39b3f212a16835ba7ea2b685","unresolved":true,"context_lines":[{"line_number":339,"context_line":".. note::"},{"line_number":340,"context_line":"   The ``noop`` deploy interface requires no configuration and accepts any"},{"line_number":341,"context_line":"   node settings. It is enabled by adding ``noop`` to the"},{"line_number":342,"context_line":"   ``enabled_deploy_interfaces`` configuration option."},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"Configuration"},{"line_number":345,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b90080c0_11e29e09","line":342,"updated":"2025-11-11 18:22:13.000000000","message":"This is a duplicate of the next section.","commit_id":"f8a0de8a569ae7498bdb778ab3b903e790c5eb28"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5d205d360f9b69aa39b3f212a16835ba7ea2b685","unresolved":true,"context_lines":[{"line_number":344,"context_line":"Configuration"},{"line_number":345,"context_line":"-------------"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"Enable the interface in ``ironic.conf``::"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    [DEFAULT]"},{"line_number":350,"context_line":"    enabled_deploy_interfaces \u003d direct,ramdisk,noop"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3b58471c_8ecb7429","line":347,"updated":"2025-11-11 18:22:13.000000000","message":"It may be worth mentioning, by the way, that this interface completely bypasses cleaning. So, even if your user cannot update Node.automated_clean, as long as they set Node.instance_info[deploy_interface], cleaning will be off.","commit_id":"f8a0de8a569ae7498bdb778ab3b903e790c5eb28"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e3aa2f058e5aa8c95371ad686f36e473bd92987","unresolved":true,"context_lines":[{"line_number":338,"context_line":"Nova to properly track the instances while Ironic skips all conductor-side"},{"line_number":339,"context_line":"deployment actions."},{"line_number":340,"context_line":""},{"line_number":341,"context_line":".. note::"},{"line_number":342,"context_line":"   The ``noop`` deploy interface completely bypasses cleaning operations."},{"line_number":343,"context_line":"   Even if a user cannot update ``Node.automated_clean``, as long as they set"},{"line_number":344,"context_line":"   ``Node.instance_info[deploy_interface]`` to ``noop``, cleaning will be"}],"source_content_type":"text/x-rst","patch_set":2,"id":"2ea48dd2_4e71472a","line":341,"updated":"2025-11-18 16:25:52.000000000","message":"Let\u0027s move this to \"Configuration\" since it\u0027s not Nova-specific (in fact, it\u0027s not a concern for Nova). Also change it from a note to a warning.","commit_id":"bcae66f199235baa60f0d389d92028616e92eec7"}],"releasenotes/notes/add-noop-deploy-interface-e0b1440f9de92dce.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d26a246165c724a12dd368da1f91c715605bd318","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Adds a ``noop`` deploy interface that performs no actual deployment"},{"line_number":5,"context_line":"    operations. This allows operators to allocate nodes and mark them as"},{"line_number":6,"context_line":"    ``active`` in Ironic without deploying an operating system. This is"},{"line_number":7,"context_line":"    particularly useful in conjunction with node adoption or when nodes"},{"line_number":8,"context_line":"    are managed by external systems but tracked in Ironic\u0027s inventory."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8c0329cb_895bc326","line":7,"updated":"2025-11-10 14:40:43.000000000","message":"Similarly, please remove the reference to adoption","commit_id":"f8a0de8a569ae7498bdb778ab3b903e790c5eb28"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4ed167be4faa992cb1ccf030fd64e127add64b9d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Adds a ``noop`` deploy interface that performs no actual deployment"},{"line_number":5,"context_line":"    operations. This allows operators to allocate nodes and mark them as"},{"line_number":6,"context_line":"    ``active`` in Ironic without deploying an operating system. This is"},{"line_number":7,"context_line":"    particularly useful in conjunction with node adoption or when nodes"},{"line_number":8,"context_line":"    are managed by external systems but tracked in Ironic\u0027s inventory."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e4e0e5e7_cad84ee5","line":7,"in_reply_to":"3da205f1_8eade0fd","updated":"2025-11-11 18:09:24.000000000","message":"It\u0027s not truthful. This feature replaces the adoption feature, not works together with it.","commit_id":"f8a0de8a569ae7498bdb778ab3b903e790c5eb28"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"29797efac34d64fe004eea8e7e4707ed0cfee9ee","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Adds a ``noop`` deploy interface that performs no actual deployment"},{"line_number":5,"context_line":"    operations. This allows operators to allocate nodes and mark them as"},{"line_number":6,"context_line":"    ``active`` in Ironic without deploying an operating system. This is"},{"line_number":7,"context_line":"    particularly useful in conjunction with node adoption or when nodes"},{"line_number":8,"context_line":"    are managed by external systems but tracked in Ironic\u0027s inventory."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3da205f1_8eade0fd","line":7,"in_reply_to":"8c0329cb_895bc326","updated":"2025-11-11 14:21:59.000000000","message":"It is suggesting useful, but not required. I\u0027m +0 to changing the release note since it is still a truthful statement. FakeDeploy and ultimately FakeHardware doesn\u0027t set the right tone for operators, and some get touchy about it, so this sort of helps.\n\nFWIW, I don\u0027t see this as explicilty setting a tone requiring use, just stating it could be helpful.","commit_id":"f8a0de8a569ae7498bdb778ab3b903e790c5eb28"}]}