)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"932f5159501590dd0bad947073a2d4e44280356e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"12a227b0_619410b1","updated":"2025-11-14 16:20:10.000000000","message":"Seems fine to me, but I\u0027ll","commit_id":"e721c56e681a2f20a0f7edd2605339c3e6b275f3"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"932f5159501590dd0bad947073a2d4e44280356e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8ef02e56_080eb506","updated":"2025-11-14 16:20:10.000000000","message":"Seems fine to me, but I\u0027ll note that the neutron spec hasn\u0027t merged yet.","commit_id":"e721c56e681a2f20a0f7edd2605339c3e6b275f3"}],"ironic/drivers/modules/network/common.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"96c3c87f5c0f20387834be884d8dd0efbd9b47bc","unresolved":true,"context_lines":[{"line_number":274,"context_line":"        binding_profile[\u0027local_group_information\u0027] \u003d local_group_info"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    # Include physical_network if available"},{"line_number":277,"context_line":"    if isinstance(port_like_obj, objects.Portgroup):"},{"line_number":278,"context_line":"        # For portgroups, get physical_network from the first port"},{"line_number":279,"context_line":"        pg_ports \u003d [p for p in task.ports"},{"line_number":280,"context_line":"                    if p.portgroup_id \u003d\u003d port_like_obj.id]"}],"source_content_type":"text/x-python","patch_set":1,"id":"b3429b0a_21446f9c","line":277,"updated":"2025-10-27 21:11:19.000000000","message":"So, There is a patch in review to add physical_network (with guarding logic) to portgroups as well. Technically once merged, this is sort of wrong.","commit_id":"f7d06492fe30357ec3bc09d319f050adbf18aced"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"49bc8e91205b874d6d5291d24347e11040ff8e90","unresolved":true,"context_lines":[{"line_number":274,"context_line":"        binding_profile[\u0027local_group_information\u0027] \u003d local_group_info"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    # Include physical_network if available"},{"line_number":277,"context_line":"    if isinstance(port_like_obj, objects.Portgroup):"},{"line_number":278,"context_line":"        # For portgroups, get physical_network from the first port"},{"line_number":279,"context_line":"        pg_ports \u003d [p for p in task.ports"},{"line_number":280,"context_line":"                    if p.portgroup_id \u003d\u003d port_like_obj.id]"}],"source_content_type":"text/x-python","patch_set":1,"id":"98f88851_b7bd8dba","line":277,"in_reply_to":"7c230d5a_27b8b477","updated":"2025-10-29 14:51:26.000000000","message":"Once my portgroup.physical_network change is merged then, theoretically, a portgroup\u0027s \u0027physical_network\u0027 and its constituent ports\u0027 \u0027physical_network\u0027s will always be the same. So here you would draw from portgroup.physical_network.","commit_id":"f7d06492fe30357ec3bc09d319f050adbf18aced"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"41397119bdca879794e0d438f077500e689147da","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        binding_profile[\u0027local_group_information\u0027] \u003d local_group_info"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    # Include physical_network if available"},{"line_number":277,"context_line":"    if isinstance(port_like_obj, objects.Portgroup):"},{"line_number":278,"context_line":"        # For portgroups, get physical_network from the first port"},{"line_number":279,"context_line":"        pg_ports \u003d [p for p in task.ports"},{"line_number":280,"context_line":"                    if p.portgroup_id \u003d\u003d port_like_obj.id]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ccf04ed4_4ff9c326","line":277,"in_reply_to":"98f88851_b7bd8dba","updated":"2025-11-03 20:15:13.000000000","message":"Done","commit_id":"f7d06492fe30357ec3bc09d319f050adbf18aced"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"836b8af19d33f15c4eb31e4a320d371c02f5b155","unresolved":true,"context_lines":[{"line_number":274,"context_line":"        binding_profile[\u0027local_group_information\u0027] \u003d local_group_info"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    # Include physical_network if available"},{"line_number":277,"context_line":"    if isinstance(port_like_obj, objects.Portgroup):"},{"line_number":278,"context_line":"        # For portgroups, get physical_network from the first port"},{"line_number":279,"context_line":"        pg_ports \u003d [p for p in task.ports"},{"line_number":280,"context_line":"                    if p.portgroup_id \u003d\u003d port_like_obj.id]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7c230d5a_27b8b477","line":277,"in_reply_to":"b3429b0a_21446f9c","updated":"2025-10-27 23:10:05.000000000","message":"agreed. I asked @me@clifhouck.com what the right behavior is once his patch goes in.","commit_id":"f7d06492fe30357ec3bc09d319f050adbf18aced"}]}
