)]}'
{"ironic/nova/tests/virt/ironic/test_driver.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6d8954a348091fa80e472d5aa74cc29d34413a79","unresolved":false,"context_lines":[{"line_number":973,"context_line":"        mock_sbf \u003d mock.patch.object(self.driver.firewall_driver,"},{"line_number":974,"context_line":"                                     \u0027setup_basic_filtering\u0027).start()"},{"line_number":975,"context_line":"        mock_pif \u003d mock.patch.object(self.driver.firewall_driver,"},{"line_number":976,"context_line":"                                     \u0027prepare_instance_filter\u0027).start()"},{"line_number":977,"context_line":"        self.driver.ensure_filtering_rules_for_instance(instance,"},{"line_number":978,"context_line":"                                                        network_info)"},{"line_number":979,"context_line":"        mock_sbf.assert_called_once_with(instance, network_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_b630c757","line":976,"updated":"2014-05-30 13:07:39.000000000","message":"any reasons for not using @decorators or context managers here? It\u0027s strange you don\u0027t stop these mocks.","commit_id":"24c710f8850c929c49613fc172cd59906173ce2e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7298de95a404a5a9b15a5e6177ca71dd5fd30671","unresolved":false,"context_lines":[{"line_number":973,"context_line":"        mock_sbf \u003d mock.patch.object(self.driver.firewall_driver,"},{"line_number":974,"context_line":"                                     \u0027setup_basic_filtering\u0027).start()"},{"line_number":975,"context_line":"        mock_pif \u003d mock.patch.object(self.driver.firewall_driver,"},{"line_number":976,"context_line":"                                     \u0027prepare_instance_filter\u0027).start()"},{"line_number":977,"context_line":"        self.driver.ensure_filtering_rules_for_instance(instance,"},{"line_number":978,"context_line":"                                                        network_info)"},{"line_number":979,"context_line":"        mock_sbf.assert_called_once_with(instance, network_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_59f174cc","line":976,"in_reply_to":"1ae5cdf2_b630c757","updated":"2014-05-30 13:26:28.000000000","message":"will fix","commit_id":"24c710f8850c929c49613fc172cd59906173ce2e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40abdcd6d0d879d211cdbb78129d16dbe9ff7853","unresolved":false,"context_lines":[{"line_number":967,"context_line":"            self.driver.unfilter_instance(instance, network_info)"},{"line_number":968,"context_line":"            mock_ui.assert_called_once_with(instance, network_info)"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"    def test_ensure_filtering_rules_for_instance(self):"},{"line_number":971,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.ctx)"},{"line_number":972,"context_line":"        network_info \u003d utils.get_test_network_info()"},{"line_number":973,"context_line":"        with mock.patch.object(self.driver.firewall_driver,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_d1e8b012","line":970,"updated":"2014-06-02 19:17:00.000000000","message":"It proved to be quite simple, though required some thoughts:\n\n from nova.virt import firewall\n\n @mock.patch.object(firewall.NoopFirewallDriver, \u0027prepare_instance_filter\u0027, create\u003dTrue)\n @mock.patch.object(firewall.NoopFirewallDriver, \u0027setup_basic_filtering\u0027, create\u003dTrue)\n    \nyeah, I\u0027m stubborn :)","commit_id":"14ffe566e36409f81d525e6b8ec5ef96ca43c0c2"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fb0042cfcc7c36221123629e4be94e3abc67e8e9","unresolved":false,"context_lines":[{"line_number":967,"context_line":"            self.driver.unfilter_instance(instance, network_info)"},{"line_number":968,"context_line":"            mock_ui.assert_called_once_with(instance, network_info)"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"    def test_ensure_filtering_rules_for_instance(self):"},{"line_number":971,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.ctx)"},{"line_number":972,"context_line":"        network_info \u003d utils.get_test_network_info()"},{"line_number":973,"context_line":"        with mock.patch.object(self.driver.firewall_driver,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_21f96f80","line":970,"in_reply_to":"1ae5cdf2_d1e8b012","updated":"2014-06-03 10:28:20.000000000","message":"cheers, will update the tests :)","commit_id":"14ffe566e36409f81d525e6b8ec5ef96ca43c0c2"}],"ironic/nova/virt/ironic/driver.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6d8954a348091fa80e472d5aa74cc29d34413a79","unresolved":false,"context_lines":[{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        :param instance: The instance object."},{"line_number":596,"context_line":"        :param network_info: Instance network information. Ignored by"},{"line_number":597,"context_line":"            this driver."},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        \"\"\""},{"line_number":600,"context_line":"        self.firewall_driver.setup_basic_filtering(instance, network_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d6fe336b","line":597,"updated":"2014-05-30 13:07:39.000000000","message":"Could you somehow expand \"ignored\" here? It at least passes it to firewall_driver...","commit_id":"24c710f8850c929c49613fc172cd59906173ce2e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7298de95a404a5a9b15a5e6177ca71dd5fd30671","unresolved":false,"context_lines":[{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        :param instance: The instance object."},{"line_number":596,"context_line":"        :param network_info: Instance network information. Ignored by"},{"line_number":597,"context_line":"            this driver."},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        \"\"\""},{"line_number":600,"context_line":"        self.firewall_driver.setup_basic_filtering(instance, network_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_b93198a4","line":597,"in_reply_to":"1ae5cdf2_d6fe336b","updated":"2014-05-30 13:26:28.000000000","message":"ew shame on me, it was a bad copy and paste. Will fix","commit_id":"24c710f8850c929c49613fc172cd59906173ce2e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6d8954a348091fa80e472d5aa74cc29d34413a79","unresolved":false,"context_lines":[{"line_number":605,"context_line":""},{"line_number":606,"context_line":"        :param instance: The instance object."},{"line_number":607,"context_line":"        :param network_info: Instance network information. Ignored by"},{"line_number":608,"context_line":"            this driver."},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"        \"\"\""},{"line_number":611,"context_line":"        self.firewall_driver.unfilter_instance(instance, network_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_16f89b7b","line":608,"updated":"2014-05-30 13:07:39.000000000","message":"ditto","commit_id":"24c710f8850c929c49613fc172cd59906173ce2e"}]}