)]}'
{"ironic/nova/tests/virt/ironic/test_driver.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2425851d0875ba908eba506035e1d0ffaf185b9e","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.ctx, node\u003dnode_uuid)"},{"line_number":591,"context_line":"        mock_inst_save \u003d mock.patch.object(instance, \u0027save\u0027).start()"},{"line_number":592,"context_line":"        self.addCleanup(mock_inst_save.stop)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"        mock_get \u003d mock.patch.object(FAKE_CLIENT.node, \u0027get\u0027).start()"},{"line_number":595,"context_line":"        mock_get.return_value \u003d node"},{"line_number":596,"context_line":"        self.addCleanup(mock_get.stop)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_cf269668","line":593,"updated":"2014-05-30 14:17:38.000000000","message":"please use context managers or decorators instead of start-stop pair","commit_id":"e7d3fdf397d6db44b1d452cf09eabaea9fb22e99"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"ebb1630a7e0849ba4cb689666dfe068183ef884a","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.ctx, node\u003dnode_uuid)"},{"line_number":591,"context_line":"        mock_inst_save \u003d mock.patch.object(instance, \u0027save\u0027).start()"},{"line_number":592,"context_line":"        self.addCleanup(mock_inst_save.stop)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"        mock_get \u003d mock.patch.object(FAKE_CLIENT.node, \u0027get\u0027).start()"},{"line_number":595,"context_line":"        mock_get.return_value \u003d node"},{"line_number":596,"context_line":"        self.addCleanup(mock_get.stop)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_455507c5","line":593,"in_reply_to":"1ae5cdf2_cf269668","updated":"2014-05-30 14:56:45.000000000","message":"Done","commit_id":"e7d3fdf397d6db44b1d452cf09eabaea9fb22e99"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"319ca0c31c0ad366bc85ec311b39ad6c4b1a0dd0","unresolved":false,"context_lines":[{"line_number":660,"context_line":"        node \u003d ironic_utils.get_test_node(driver\u003d\u0027fake\u0027, uuid\u003dnode_uuid)"},{"line_number":661,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.ctx, node\u003dnode_uuid)"},{"line_number":662,"context_line":"        mock_inst_save \u003d mock.patch.object(instance, \u0027save\u0027).start()"},{"line_number":663,"context_line":"        self.addCleanup(mock_inst_save.stop)"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"        mock_get \u003d mock.patch.object(FAKE_CLIENT.node, \u0027get\u0027).start()"},{"line_number":666,"context_line":"        mock_get.return_value \u003d node"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_e57373af","line":663,"updated":"2014-05-30 14:53:07.000000000","message":"One more skipped","commit_id":"2dc49b28883e9ad31eb7146c61ecd7ca127f3bab"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4dc5b3759d5cf2adad87ba7d68be8da18ed9839b","unresolved":false,"context_lines":[{"line_number":703,"context_line":"        # Causing validation to fail short-circuits the rest of the method"},{"line_number":704,"context_line":"        mock_validate.return_value \u003d ironic_utils.get_test_validation("},{"line_number":705,"context_line":"                                                                 power\u003dFalse,"},{"line_number":706,"context_line":"                                                                 deploy\u003dFalse)"},{"line_number":707,"context_line":"        mock_get.return_value \u003d node"},{"line_number":708,"context_line":"        mock_flavor.return_value \u003d fake_flavor"},{"line_number":709,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_7392c458","line":706,"updated":"2014-05-30 17:27:38.000000000","message":"Indentation nit: should probably be\n\n ironic_utils.get_test_validation(\n     power\u003dFalse, deploy\u003dFalse)","commit_id":"43161c5f0d20e8644868eb475b113332df194d93"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"925adb241b81a9eb79d10f32be0269989c2ff164","unresolved":false,"context_lines":[{"line_number":703,"context_line":"        # Causing validation to fail short-circuits the rest of the method"},{"line_number":704,"context_line":"        mock_validate.return_value \u003d ironic_utils.get_test_validation("},{"line_number":705,"context_line":"                                                                 power\u003dFalse,"},{"line_number":706,"context_line":"                                                                 deploy\u003dFalse)"},{"line_number":707,"context_line":"        mock_get.return_value \u003d node"},{"line_number":708,"context_line":"        mock_flavor.return_value \u003d fake_flavor"},{"line_number":709,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_934910d3","line":706,"in_reply_to":"1ae5cdf2_7392c458","updated":"2014-05-30 17:32:34.000000000","message":"Done","commit_id":"43161c5f0d20e8644868eb475b113332df194d93"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4dc5b3759d5cf2adad87ba7d68be8da18ed9839b","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        mock_get.return_value \u003d node"},{"line_number":708,"context_line":"        mock_flavor.return_value \u003d fake_flavor"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        with mock.patch.object(instance, \u0027save\u0027) as mock_inst_save:"},{"line_number":711,"context_line":"            self.assertRaises(exception.ValidationError, self.driver.spawn,"},{"line_number":712,"context_line":"                              self.ctx, instance, None, [], None)"},{"line_number":713,"context_line":"            mock_get.assert_called_once_with(node_uuid)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_13ac20a0","line":710,"updated":"2014-05-30 17:27:38.000000000","message":"Won\u0027t\n\n @mock.patch.object(FAKE_CLIENT.node, \u0027save\u0027)\n\nwork instead of this context manager?","commit_id":"43161c5f0d20e8644868eb475b113332df194d93"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"925adb241b81a9eb79d10f32be0269989c2ff164","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        mock_get.return_value \u003d node"},{"line_number":708,"context_line":"        mock_flavor.return_value \u003d fake_flavor"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        with mock.patch.object(instance, \u0027save\u0027) as mock_inst_save:"},{"line_number":711,"context_line":"            self.assertRaises(exception.ValidationError, self.driver.spawn,"},{"line_number":712,"context_line":"                              self.ctx, instance, None, [], None)"},{"line_number":713,"context_line":"            mock_get.assert_called_once_with(node_uuid)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_d312b8b3","line":710,"in_reply_to":"1ae5cdf2_13ac20a0","updated":"2014-05-30 17:32:34.000000000","message":"save() is on instance","commit_id":"43161c5f0d20e8644868eb475b113332df194d93"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4dc5b3759d5cf2adad87ba7d68be8da18ed9839b","unresolved":false,"context_lines":[{"line_number":714,"context_line":"            mock_validate.assert_called_once_with(node_uuid)"},{"line_number":715,"context_line":"            mock_flavor.assert_called_once_with(self.ctx,"},{"line_number":716,"context_line":"                                                instance[\u0027instance_type_id\u0027])"},{"line_number":717,"context_line":"            self.assertEqual(instance[\u0027default_ephemeral_device\u0027], \u0027/dev/sda1\u0027)"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    @mock.patch.object(FAKE_CLIENT.node, \u0027update\u0027)"},{"line_number":720,"context_line":"    @mock.patch.object(FAKE_CLIENT.node, \u0027set_provision_state\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_53e78812","line":717,"updated":"2014-05-30 17:27:38.000000000","message":"Order of parameters should be the opposite:\n\n self.assertEqual(\u0027/dev/sda1\u0027, instance[\u0027default_ephemeral_device\u0027])\n\nsee e.g. https://review.openstack.org/#/c/76077/","commit_id":"43161c5f0d20e8644868eb475b113332df194d93"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"925adb241b81a9eb79d10f32be0269989c2ff164","unresolved":false,"context_lines":[{"line_number":714,"context_line":"            mock_validate.assert_called_once_with(node_uuid)"},{"line_number":715,"context_line":"            mock_flavor.assert_called_once_with(self.ctx,"},{"line_number":716,"context_line":"                                                instance[\u0027instance_type_id\u0027])"},{"line_number":717,"context_line":"            self.assertEqual(instance[\u0027default_ephemeral_device\u0027], \u0027/dev/sda1\u0027)"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    @mock.patch.object(FAKE_CLIENT.node, \u0027update\u0027)"},{"line_number":720,"context_line":"    @mock.patch.object(FAKE_CLIENT.node, \u0027set_provision_state\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_f317b4a1","line":717,"in_reply_to":"1ae5cdf2_53e78812","updated":"2014-05-30 17:32:34.000000000","message":"Done","commit_id":"43161c5f0d20e8644868eb475b113332df194d93"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"35138e20437617c71d13f0dca6240c72155e8795","unresolved":false,"context_lines":[{"line_number":702,"context_line":""},{"line_number":703,"context_line":"        # Causing validation to fail short-circuits the rest of the method"},{"line_number":704,"context_line":"        mock_validate.return_value \u003d ironic_utils.get_test_validation("},{"line_number":705,"context_line":"                                         power\u003dFalse, deploy\u003dFalse)"},{"line_number":706,"context_line":"        mock_get.return_value \u003d node"},{"line_number":707,"context_line":"        mock_flavor.return_value \u003d fake_flavor"},{"line_number":708,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_33891cec","line":705,"updated":"2014-05-30 17:34:27.000000000","message":"The indentation is still not 100% correct (should be 4 spaces from the beginning)","commit_id":"adbcb0b3fdbb2149968dad5c8085c6272d534e59"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"a7b160964ae2f8054a16e93556168b2e8f5a0e22","unresolved":false,"context_lines":[{"line_number":702,"context_line":""},{"line_number":703,"context_line":"        # Causing validation to fail short-circuits the rest of the method"},{"line_number":704,"context_line":"        mock_validate.return_value \u003d ironic_utils.get_test_validation("},{"line_number":705,"context_line":"                                         power\u003dFalse, deploy\u003dFalse)"},{"line_number":706,"context_line":"        mock_get.return_value \u003d node"},{"line_number":707,"context_line":"        mock_flavor.return_value \u003d fake_flavor"},{"line_number":708,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_f3c174e5","line":705,"in_reply_to":"1ae5cdf2_33891cec","updated":"2014-05-30 17:37:09.000000000","message":"I count 4 spaces.  :)","commit_id":"adbcb0b3fdbb2149968dad5c8085c6272d534e59"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"53db100a9e201786e0e5ed2448c300009dde8f1f","unresolved":false,"context_lines":[{"line_number":626,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.ctx, node\u003dnode_uuid)"},{"line_number":627,"context_line":"        fake_flavor \u003d { \u0027ephemeral_gb\u0027: 1 }"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        # Causing validation to fail short-circuits the rest of the method"},{"line_number":630,"context_line":"        mock_node.validate.return_value \u003d ironic_utils.get_test_validation("},{"line_number":631,"context_line":"                                              power\u003dFalse, deploy\u003dFalse)"},{"line_number":632,"context_line":"        mock_node.get.return_value \u003d node"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_36862514","line":629,"updated":"2014-06-10 16:14:37.000000000","message":"It\u0027s unclear to me why this needs to be done. The rest of spawn() only interacts with the ironic client, which is already mocked out. I think this code can be removed without any other consequences, no?","commit_id":"7a66020c6e5f7d3070c8937a6c9772033e48ae7e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"a6f61df3dd45836dee0c00b911899503d31ecc7b","unresolved":false,"context_lines":[{"line_number":626,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.ctx, node\u003dnode_uuid)"},{"line_number":627,"context_line":"        fake_flavor \u003d { \u0027ephemeral_gb\u0027: 1 }"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        # Causing validation to fail short-circuits the rest of the method"},{"line_number":630,"context_line":"        mock_node.validate.return_value \u003d ironic_utils.get_test_validation("},{"line_number":631,"context_line":"                                              power\u003dFalse, deploy\u003dFalse)"},{"line_number":632,"context_line":"        mock_node.get.return_value \u003d node"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_00337aab","line":629,"in_reply_to":"1ae5cdf2_36862514","updated":"2014-06-11 13:26:09.000000000","message":"By doing this, we avoid mocking some other things. I\u0027ll post a change with those other things mocked, though, if that\u0027s more clear.","commit_id":"7a66020c6e5f7d3070c8937a6c9772033e48ae7e"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"31d7050a117160bcdf082a457e8435efcc0af9f8","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        mock_cli.return_value \u003d FAKE_CLIENT"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        with mock.patch.object(instance, \u0027save\u0027) as mock_inst_save:"},{"line_number":637,"context_line":"            self.assertRaises(exception.ValidationError, self.driver.spawn,"},{"line_number":638,"context_line":"                              self.ctx, instance, None, [], None)"},{"line_number":639,"context_line":"            mock_node.get.assert_called_once_with(node_uuid)"},{"line_number":640,"context_line":"            mock_node.validate.assert_called_once_with(node_uuid)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_8faa7cd0","line":637,"updated":"2014-06-10 17:13:57.000000000","message":"this appears to be testing that the validation failed","commit_id":"7a66020c6e5f7d3070c8937a6c9772033e48ae7e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"a6f61df3dd45836dee0c00b911899503d31ecc7b","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        mock_cli.return_value \u003d FAKE_CLIENT"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        with mock.patch.object(instance, \u0027save\u0027) as mock_inst_save:"},{"line_number":637,"context_line":"            self.assertRaises(exception.ValidationError, self.driver.spawn,"},{"line_number":638,"context_line":"                              self.ctx, instance, None, [], None)"},{"line_number":639,"context_line":"            mock_node.get.assert_called_once_with(node_uuid)"},{"line_number":640,"context_line":"            mock_node.validate.assert_called_once_with(node_uuid)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_60219e4c","line":637,"in_reply_to":"1ae5cdf2_8faa7cd0","updated":"2014-06-11 13:26:09.000000000","message":"Yep. :) Thus the short-circuit.","commit_id":"7a66020c6e5f7d3070c8937a6c9772033e48ae7e"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"31d7050a117160bcdf082a457e8435efcc0af9f8","unresolved":false,"context_lines":[{"line_number":640,"context_line":"            mock_node.validate.assert_called_once_with(node_uuid)"},{"line_number":641,"context_line":"            mock_flavor.assert_called_once_with(self.ctx,"},{"line_number":642,"context_line":"                                                instance[\u0027instance_type_id\u0027])"},{"line_number":643,"context_line":"            self.assertEqual(\u0027/dev/sda1\u0027, instance[\u0027default_ephemeral_device\u0027])"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    @mock.patch.object(cw.IronicClientWrapper, \u0027_get_client\u0027)"},{"line_number":646,"context_line":"    @mock.patch.object(FAKE_CLIENT, \u0027node\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_cf8ba466","line":643,"updated":"2014-06-10 17:13:57.000000000","message":"it\u0027s unclear where /dev/sda1 is coming from, or what is setting instance[\u0027default_ephemeral_device\u0027] in this test. It\u0027s also unclear why these asserts are inside \"with mock.patch.object(instance, \u0027save\u0027)\" when mock_inst_save is never invoked.","commit_id":"7a66020c6e5f7d3070c8937a6c9772033e48ae7e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"7e464f5ebabac9ab012fd274e8c5b3255294f357","unresolved":false,"context_lines":[{"line_number":640,"context_line":"            mock_node.validate.assert_called_once_with(node_uuid)"},{"line_number":641,"context_line":"            mock_flavor.assert_called_once_with(self.ctx,"},{"line_number":642,"context_line":"                                                instance[\u0027instance_type_id\u0027])"},{"line_number":643,"context_line":"            self.assertEqual(\u0027/dev/sda1\u0027, instance[\u0027default_ephemeral_device\u0027])"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    @mock.patch.object(cw.IronicClientWrapper, \u0027_get_client\u0027)"},{"line_number":646,"context_line":"    @mock.patch.object(FAKE_CLIENT, \u0027node\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_6342883f","line":643,"in_reply_to":"1ae5cdf2_00da9a4b","updated":"2014-06-11 13:38:09.000000000","message":"Forgot to address the mock_inst_save comment...\n\ninstance.save() is called when default_ephemeral_device is set within spawn(). If we don\u0027t mock save() here, the test will fail trying to access the database. We don\u0027t have to invoke mock_inst_save from within the test.","commit_id":"7a66020c6e5f7d3070c8937a6c9772033e48ae7e"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"a6f61df3dd45836dee0c00b911899503d31ecc7b","unresolved":false,"context_lines":[{"line_number":640,"context_line":"            mock_node.validate.assert_called_once_with(node_uuid)"},{"line_number":641,"context_line":"            mock_flavor.assert_called_once_with(self.ctx,"},{"line_number":642,"context_line":"                                                instance[\u0027instance_type_id\u0027])"},{"line_number":643,"context_line":"            self.assertEqual(\u0027/dev/sda1\u0027, instance[\u0027default_ephemeral_device\u0027])"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    @mock.patch.object(cw.IronicClientWrapper, \u0027_get_client\u0027)"},{"line_number":646,"context_line":"    @mock.patch.object(FAKE_CLIENT, \u0027node\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_00da9a4b","line":643,"in_reply_to":"1ae5cdf2_cf8ba466","updated":"2014-06-11 13:26:09.000000000","message":"It\u0027s set when fake_flavor has a non-zero ephemeral_gb size. See its definition above.","commit_id":"7a66020c6e5f7d3070c8937a6c9772033e48ae7e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"edddfd917dc6fa350c948103418fc64230d8ee5b","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        mock_node.set_provision_state.return_value \u003d mock.MagicMock()"},{"line_number":635,"context_line":"        node.provision_state \u003d ironic_states.ACTIVE"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"        with mock.patch.object(instance, \u0027save\u0027) as mock_inst_save:"},{"line_number":638,"context_line":"            self.driver.spawn(self.ctx, instance, None, [], None)"},{"line_number":639,"context_line":"            mock_flavor.assert_called_once_with(self.ctx,"},{"line_number":640,"context_line":"                                                instance[\u0027instance_type_id\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ae5cdf2_d72dd247","line":637,"updated":"2014-06-11 15:11:32.000000000","message":"I\u0027ve got two suggestions here.\n  1. Why not do this as a decorator, eg @mock.patch.object(instance_obj.Instance, \u0027save\u0027)\n  2. check that mock_inst_save gets called\n\nOk, I lied. I thought of something else. I think it might also be useful to add checks (maybe in an existing test) for when ephemeral_gb \u003d\u003d 0:\n  1. instance[\u0027default_ephemeral_device\u0027] is NOT set\n  2. mock_inst_save is NOT called","commit_id":"95ebb6ff5b47e5a53f9b242a19e079397e4c546b"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"c93cb260cdccb34e558531435c9b40159af5f8c2","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        mock_node.set_provision_state.return_value \u003d mock.MagicMock()"},{"line_number":635,"context_line":"        node.provision_state \u003d ironic_states.ACTIVE"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"        with mock.patch.object(instance, \u0027save\u0027) as mock_inst_save:"},{"line_number":638,"context_line":"            self.driver.spawn(self.ctx, instance, None, [], None)"},{"line_number":639,"context_line":"            mock_flavor.assert_called_once_with(self.ctx,"},{"line_number":640,"context_line":"                                                instance[\u0027instance_type_id\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ae5cdf2_128108c3","line":637,"in_reply_to":"1ae5cdf2_d72dd247","updated":"2014-06-11 15:44:28.000000000","message":"Done","commit_id":"95ebb6ff5b47e5a53f9b242a19e079397e4c546b"}],"ironic/nova/virt/ironic/driver.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"5bbaa8f94e1d72cd25aae908c39490eb116a247f","unresolved":false,"context_lines":[{"line_number":401,"context_line":"                                             instance[\u0027instance_type_id\u0027])"},{"line_number":402,"context_line":"        self._add_driver_fields(node, instance, image_meta, flavor)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"        if flavor[\u0027ephemeral_gb\u0027]:"},{"line_number":405,"context_line":"            instance.default_ephemeral_device \u003d \u0027/dev/sda1\u0027"},{"line_number":406,"context_line":"            instance.save()"},{"line_number":407,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_19219f9f","line":404,"updated":"2014-05-30 18:17:51.000000000","message":"Please add an inline comment here explaining the reason for this workaround // linking to the bug its fixing.\n\nthanks.","commit_id":"adbcb0b3fdbb2149968dad5c8085c6272d534e59"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"2bcd7f100709fe2367e1285b7bac593bf84cde19","unresolved":false,"context_lines":[{"line_number":401,"context_line":"                                             instance[\u0027instance_type_id\u0027])"},{"line_number":402,"context_line":"        self._add_driver_fields(node, instance, image_meta, flavor)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"        if flavor[\u0027ephemeral_gb\u0027]:"},{"line_number":405,"context_line":"            instance.default_ephemeral_device \u003d \u0027/dev/sda1\u0027"},{"line_number":406,"context_line":"            instance.save()"},{"line_number":407,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_d9d01756","line":404,"in_reply_to":"1ae5cdf2_19219f9f","updated":"2014-05-30 18:23:53.000000000","message":"Done","commit_id":"adbcb0b3fdbb2149968dad5c8085c6272d534e59"}]}
