)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"bc326ac4087874973bcc47a7526662f9ffde71bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d246a24_fa936a2e","updated":"2025-11-06 15:33:16.000000000","message":"LGTM. One question: I\u0027m not familiar with what consumes this data/API endpoint. Is there any risk in the consumer not expecting JSON?","commit_id":"d27b4157bcf477de52b21b789ac0e4a5a896d422"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"56b7f2514af267743260deefe9f59956f28d2dda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ccc0a9c6_f7672582","in_reply_to":"1b464247_1f101512","updated":"2025-11-06 16:38:07.000000000","message":"Sure, I expected this was the right thing to do given the bug report and the inspector code, but wanted to double-check.","commit_id":"d27b4157bcf477de52b21b789ac0e4a5a896d422"},{"author":{"_account_id":35099,"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","username":"kubajj"},"change_message_id":"ecaf21c8f36691eadab1602a9bcb3e70378d7103","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"60d0dec2_8697531e","in_reply_to":"1d246a24_fa936a2e","updated":"2025-11-06 15:50:26.000000000","message":"I think it\u0027s then opposite. At CERN, we had inspection data in swift and it was JSON. It\u0027s just when I wrote the method in 2023, I didn\u0027t have swift deployed, so this was uncaught.","commit_id":"d27b4157bcf477de52b21b789ac0e4a5a896d422"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"fe8fef90a7baad6e008940d6560b09d960a1b561","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1b464247_1f101512","in_reply_to":"1d246a24_fa936a2e","updated":"2025-11-06 16:26:36.000000000","message":"It\u0027s literally just a dump that goes into swift. So while you\u0027re right the format will change, it\u0027s hard for me to imagine anyone complaining about us turning it into a parseable format.","commit_id":"d27b4157bcf477de52b21b789ac0e4a5a896d422"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b66ebf7ba44897605e5b6f938e4a2daed435aab6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"41d4a728_a3cedf12","updated":"2025-11-10 14:41:17.000000000","message":"LOL, good find","commit_id":"9769ae72daa857340e0a3891dc50354b0c8bb712"},{"author":{"_account_id":35099,"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","username":"kubajj"},"change_message_id":"daa366de18cb96f00413705c5eb524e47a3d73ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aa939fef_7f039e62","updated":"2025-11-10 16:09:59.000000000","message":"recheck Not able to ssh to a node, maybe it was unavailable?","commit_id":"9769ae72daa857340e0a3891dc50354b0c8bb712"}],"ironic/drivers/modules/inspect_utils.py":[{"author":{"_account_id":35099,"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","username":"kubajj"},"change_message_id":"6a4ce50f110fed12d09437b1038a09c1bbb189cc","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import socket"},{"line_number":18,"context_line":"import typing"},{"line_number":19,"context_line":"import urllib"},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_log import log as logging"},{"line_number":23,"context_line":"from oslo_utils import excutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"a332b93a_f0f25f9d","line":20,"in_reply_to":"9b811b9b_7a3ee067","updated":"2025-11-06 17:58:06.000000000","message":"no LLM tools used\nI did run tox before pushing, but it started correcting way too many other files - no clue why, but will try to fix it for next time when I push something to ironic","commit_id":"d27b4157bcf477de52b21b789ac0e4a5a896d422"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"48860f2d5c8dddf98f6fac78e76f257a08e6b10a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import socket"},{"line_number":18,"context_line":"import typing"},{"line_number":19,"context_line":"import urllib"},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_log import log as logging"},{"line_number":23,"context_line":"from oslo_utils import excutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"5372c227_3f357cdb","line":20,"in_reply_to":"a332b93a_f0f25f9d","updated":"2025-11-10 21:46:08.000000000","message":"Ensure everything is  \"added\" to git first and it helps.","commit_id":"d27b4157bcf477de52b21b789ac0e4a5a896d422"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"fe8fef90a7baad6e008940d6560b09d960a1b561","unresolved":true,"context_lines":[{"line_number":17,"context_line":"import socket"},{"line_number":18,"context_line":"import typing"},{"line_number":19,"context_line":"import urllib"},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_log import log as logging"},{"line_number":23,"context_line":"from oslo_utils import excutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"9b811b9b_7a3ee067","line":20,"in_reply_to":"bc1884a1_a862ec88","updated":"2025-11-06 16:26:36.000000000","message":"\u003e pep8: H306: imports not in alphabetical order (urllib, json)\n\nThe pep8 error here is a thing I often see when using LLM guided coding tools. If you used those here, that\u0027s 100% OK but needs to be tagged Generated-By or Assisted-By as noted here: https://openinfra.org/legal/ai-policy\n\nIf not, consider using pre-commit (https://docs.openstack.org/ironic/latest/contributor/dev-quickstart.html#git-hooks) to prevent these errors in the future.","commit_id":"d27b4157bcf477de52b21b789ac0e4a5a896d422"}]}