)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"50f33bb37424ac57a93273615c96229625debe9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7258fa46_325a4332","updated":"2025-11-11 21:31:13.000000000","message":"Broadly speaking, I like what I see here. +1 for now because I\u0027m starting to get a migraine.","commit_id":"ae80d094a54e58fcaa91e93838f689b44cd78f97"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"152ab3fe4395990daec58b49e29584fbe32471b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8fb9f767_32a2c9f2","updated":"2025-12-05 20:17:47.000000000","message":"-1 for this: I\u0027m assuming this is configurable in the sense that if no conductor supports bootc deploy_interface, it won\u0027t work -- but shouldn\u0027t we key the behavior so that we won\u0027t attempt to deploy using an interface that\u0027s not available?\n\n\n\nAlso I\u0027m concerned that we maybe should take a more generic approach to this? This seems very much tied to OCI and bootc, specifically, when I think we have a larger problemset of \"pick a proper boot_interface based on image metadata\", e.g. using  ramdisk boot_interface based on metadata from image service and the like. I just wonder if this is a scalpel change when maybe we need to model it more explicitly in the image service as a generic concept.","commit_id":"2a4adc76f8a8f4170ca6d14f7ace8180440834b6"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"52fa0960954dfa8cbfa0178dab78e2a4d7d8b274","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"936a8cbc_655b74fb","updated":"2026-01-10 20:57:17.000000000","message":"recheck metal3-integration","commit_id":"2a4adc76f8a8f4170ca6d14f7ace8180440834b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bdf8474335f93e8ea17ac5e67cea39a6da57b794","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"59300863_1fb640d0","updated":"2025-11-25 23:06:50.000000000","message":"recheck metal3-integration build failure","commit_id":"2a4adc76f8a8f4170ca6d14f7ace8180440834b6"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"17139f608bea187ca8bdabb6ed5619af8ca0dee8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9f922a35_1490afa7","in_reply_to":"8fb9f767_32a2c9f2","updated":"2025-12-05 20:19:47.000000000","message":"This was posted before I read the next change. D\u0027oh. Using an exception to indicate to do the swap is *exactly* what I was trying to think of.\n\nStill think we need a guardrail -- here or in the next patch -- to ensure we don\u0027t attempt deployment with a deploy_interface not currently available in the conductor group.","commit_id":"2a4adc76f8a8f4170ca6d14f7ace8180440834b6"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"52fa0960954dfa8cbfa0178dab78e2a4d7d8b274","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c93256ee_6bae2815","in_reply_to":"9f922a35_1490afa7","updated":"2026-01-10 20:57:17.000000000","message":"The next change calls driver_factory.get_interface. I\u0027m not certain but I assume that will raise an exception if the interface is not enabled.","commit_id":"2a4adc76f8a8f4170ca6d14f7ace8180440834b6"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"edb49ffc6c350479f5d410a5c502137a8e265e53","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7f6b5671_bfaa5a1f","in_reply_to":"c93256ee_6bae2815","updated":"2026-01-21 23:50:57.000000000","message":"I was thinking more that we might wanna go \"boom\" at startup if we have:\n- auto deploy_interface enabled for a conductor \n- configured with a deploy_interface not enabled on that conductor","commit_id":"2a4adc76f8a8f4170ca6d14f7ace8180440834b6"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d3676727f5c5af6cbc928c8a916ad55d17967821","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3e74ed87_ec81e715","updated":"2026-01-22 16:14:08.000000000","message":"Moved my -1 to the right patch.","commit_id":"1b49125a689e40188291a45bdd620064f1af2cb3"}],"ironic/common/image_service.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"80a2bebe61e7c7ecd52ba72fba4fd97e53f16405","unresolved":true,"context_lines":[{"line_number":717,"context_line":"                # NOTE(stevebaker) The disktype is used to"},{"line_number":718,"context_line":"                # designate whether the image URL is a bootc image"},{"line_number":719,"context_line":"                # stored in a container registry"},{"line_number":720,"context_line":"                disktype \u003d \u0027bootc\u0027"},{"line_number":721,"context_line":"            return {"},{"line_number":722,"context_line":"                # Return an OCI url in case Ironic is doing the download"},{"line_number":723,"context_line":"                \u0027oci_image_manifest_url\u0027: image_href,"}],"source_content_type":"text/x-python","patch_set":1,"id":"792d1a8b_abb51cfd","line":720,"updated":"2025-11-11 21:50:09.000000000","message":"I want to draw attention to my choice of using disktype/image_disk_format for denoting a bootc image. It is not really a disk image format unless you squint, but adding a whole new image info attribute seems overkill","commit_id":"ae80d094a54e58fcaa91e93838f689b44cd78f97"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"29252c67182a495277cadc55b0cd1f0b3a3f3d3b","unresolved":true,"context_lines":[{"line_number":717,"context_line":"                # NOTE(stevebaker) The disktype is used to"},{"line_number":718,"context_line":"                # designate whether the image URL is a bootc image"},{"line_number":719,"context_line":"                # stored in a container registry"},{"line_number":720,"context_line":"                disktype \u003d \u0027bootc\u0027"},{"line_number":721,"context_line":"            return {"},{"line_number":722,"context_line":"                # Return an OCI url in case Ironic is doing the download"},{"line_number":723,"context_line":"                \u0027oci_image_manifest_url\u0027: image_href,"}],"source_content_type":"text/x-python","patch_set":1,"id":"85454a92_235011dc","line":720,"in_reply_to":"792d1a8b_abb51cfd","updated":"2025-11-25 23:06:30.000000000","message":"I noticed that upfront and went to \"autosquint\" mode. Truthfully, I\u0027m in concurrence, we don\u0027t need a new artifact. The only risk we really runinto with this possibly saying \"hey, this is a bootc\" because it is a container, and then the container contents lacks the needful to do it.","commit_id":"ae80d094a54e58fcaa91e93838f689b44cd78f97"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"29252c67182a495277cadc55b0cd1f0b3a3f3d3b","unresolved":true,"context_lines":[{"line_number":614,"context_line":"        # Check if config has empty mediaType (ORAS artifact format)"},{"line_number":615,"context_line":"        config \u003d manifest.get(\u0027config\u0027, {})"},{"line_number":616,"context_line":"        config_media_type \u003d config.get(\u0027mediaType\u0027)"},{"line_number":617,"context_line":"        return config_media_type \u003d\u003d \u0027application/vnd.oci.empty.v1+json\u0027"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def identify_specific_image(self, image_href, image_download_source\u003dNone,"},{"line_number":620,"context_line":"                                cpu_arch\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"71da9392_ef3acb36","line":617,"range":{"start_line":617,"start_character":7,"end_line":617,"end_character":71},"updated":"2025-11-25 23:06:30.000000000","message":"It might be good to note, that when it is empty, we know it is an artifact, otherwise it looks like a container because it would be layer definitions.","commit_id":"2a4adc76f8a8f4170ca6d14f7ace8180440834b6"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"c07f2f23c1155530386bfeac4207b689a39a1f1b","unresolved":true,"context_lines":[{"line_number":1531,"context_line":"            # Indicate that the container image is a bootc image so that"},{"line_number":1532,"context_line":"            # the deploy agent can be swapped for the image writing tasks"},{"line_number":1533,"context_line":"            di_info[\u0027container_image_type\u0027] \u003d \u0027bootc\u0027"},{"line_number":1534,"context_line":"            node.driver_internal_info \u003d di_info"},{"line_number":1535,"context_line":"    if not is_glance_image:"},{"line_number":1536,"context_line":"        if (image_source.startswith(\u0027file://\u0027)"},{"line_number":1537,"context_line":"                or image_download_source \u003d\u003d \u0027local\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf4adbf4_0f02c344","line":1534,"updated":"2025-11-13 02:21:20.000000000","message":"Oh none of this change is required. I\u0027ll remove it from the next revision","commit_id":"2c188d16d60df1c3dcb2094e4d61bd7a8bbebfc7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"5e50e45297fc929a4c1a3efdee6c8ad191c2e183","unresolved":false,"context_lines":[{"line_number":1531,"context_line":"            # Indicate that the container image is a bootc image so that"},{"line_number":1532,"context_line":"            # the deploy agent can be swapped for the image writing tasks"},{"line_number":1533,"context_line":"            di_info[\u0027container_image_type\u0027] \u003d \u0027bootc\u0027"},{"line_number":1534,"context_line":"            node.driver_internal_info \u003d di_info"},{"line_number":1535,"context_line":"    if not is_glance_image:"},{"line_number":1536,"context_line":"        if (image_source.startswith(\u0027file://\u0027)"},{"line_number":1537,"context_line":"                or image_download_source \u003d\u003d \u0027local\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"feea1046_4146ad41","line":1534,"in_reply_to":"bf4adbf4_0f02c344","updated":"2025-11-24 23:47:31.000000000","message":"Done","commit_id":"2c188d16d60df1c3dcb2094e4d61bd7a8bbebfc7"}]}