)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31080,"name":"Nicolas Belouin","email":"nicolas.belouin@suse.com","username":"diconico07"},"change_message_id":"057f14788470441ea494810de3b4b09afb75ba95","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The combined Ironic service was incorrectly passing the no_fork"},{"line_number":10,"context_line":"parameter to ServiceLauncher, which never supported it."},{"line_number":11,"context_line":"oslo.service 4.3.0 silently ignored unknown parameters,"},{"line_number":12,"context_line":"but 4.4.0+ introduced stricter validation and raises TypeError."},{"line_number":13,"context_line":"The ``no_fork`` parameter has been removed to"},{"line_number":14,"context_line":"restore compatibility."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"61ea539e_a518e24e","line":11,"updated":"2025-11-20 15:38:33.000000000","message":"Actually, it was a wrong mapping of ServiceLauncher to ProcessLauncher (that do support that argument). See: https://opendev.org/openstack/oslo.service/commit/0dfdf810acdf9aec6dc4fb8339a171535fe8bbc1\n\nI wonder if we should expect side effects from this","commit_id":"174f2533cb36cb2ec2832b8d1a1144b77cb163b1"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"35fab1d2630397a456278f2699e9b8e7cc8e62c3","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The combined Ironic service was incorrectly passing the no_fork"},{"line_number":10,"context_line":"parameter to ServiceLauncher, which never supported it."},{"line_number":11,"context_line":"oslo.service 4.3.0 silently ignored unknown parameters,"},{"line_number":12,"context_line":"but 4.4.0+ introduced stricter validation and raises TypeError."},{"line_number":13,"context_line":"The ``no_fork`` parameter has been removed to"},{"line_number":14,"context_line":"restore compatibility."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"de23401f_b48b6abb","line":11,"in_reply_to":"61ea539e_a518e24e","updated":"2025-11-20 16:13:40.000000000","message":"ah well, that\u0027s even worse, I\u0027ll update commit msg and reno","commit_id":"174f2533cb36cb2ec2832b8d1a1144b77cb163b1"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"79ef6ac48a57418aa87f3b839f70dfe4bf5f7e11","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The combined Ironic service was incorrectly passing the no_fork"},{"line_number":10,"context_line":"parameter to ServiceLauncher, which never supported it."},{"line_number":11,"context_line":"oslo.service 4.3.0 silently ignored unknown parameters,"},{"line_number":12,"context_line":"but 4.4.0+ introduced stricter validation and raises TypeError."},{"line_number":13,"context_line":"The ``no_fork`` parameter has been removed to"},{"line_number":14,"context_line":"restore compatibility."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"725dc6fb_c51b3c35","line":11,"in_reply_to":"b176b3c0_553f8110","updated":"2025-11-21 09:43:52.000000000","message":"thanks to you for pointing that out! :)","commit_id":"174f2533cb36cb2ec2832b8d1a1144b77cb163b1"},{"author":{"_account_id":31080,"name":"Nicolas Belouin","email":"nicolas.belouin@suse.com","username":"diconico07"},"change_message_id":"46ea1c30e22b2fdb3c909d0f035032bd680193bd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The combined Ironic service was incorrectly passing the no_fork"},{"line_number":10,"context_line":"parameter to ServiceLauncher, which never supported it."},{"line_number":11,"context_line":"oslo.service 4.3.0 silently ignored unknown parameters,"},{"line_number":12,"context_line":"but 4.4.0+ introduced stricter validation and raises TypeError."},{"line_number":13,"context_line":"The ``no_fork`` parameter has been removed to"},{"line_number":14,"context_line":"restore compatibility."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b176b3c0_553f8110","line":11,"in_reply_to":"de23401f_b48b6abb","updated":"2025-11-21 09:09:51.000000000","message":"Thanks.","commit_id":"174f2533cb36cb2ec2832b8d1a1144b77cb163b1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2ea50384027e94470563c6c55c702e3b03b37daa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d136f7b5_81e4b4fa","updated":"2025-11-20 13:23:04.000000000","message":"we should backport this even if oslo.service is older in other branches as the no_fork option was silently ignored","commit_id":"e7b930350300cd137564f68716880884af174641"}]}