)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f87a1aa1fcafc47bfaf16f9d2782c28a515202cc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"08331d4f_faaf2979","updated":"2025-12-02 16:36:23.000000000","message":"-1 to highlight comments from Dmitry, which should be addressed before this merges","commit_id":"694769f37b020caef16a58ff42829d314c8bb5a8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a896297c5f5b87d0dd0b8c9275ec211051c27209","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f8d734e3_33c130df","updated":"2025-12-04 18:53:33.000000000","message":"Approving. The -1 was just to highlight additional reviewer visibility but that reviewer has commented since then so I think we are good at this point.","commit_id":"694769f37b020caef16a58ff42829d314c8bb5a8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6d38637cb2e2ee3f027cf0221edcad93a2fd2a97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8fe78209_1d07d0c6","updated":"2025-11-24 18:58:43.000000000","message":"LGTM","commit_id":"694769f37b020caef16a58ff42829d314c8bb5a8"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"7c120bc36436d672d674a16c0ba60590f364f8fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a51c78c6_7c0d740e","updated":"2025-11-24 21:57:13.000000000","message":"recheck metal3 had a dnf error","commit_id":"694769f37b020caef16a58ff42829d314c8bb5a8"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"f3e09b998a2cf89793ca6b9fdf4675439803d799","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c32d6887_9db9604f","in_reply_to":"08331d4f_faaf2979","updated":"2025-12-02 17:50:40.000000000","message":"Done","commit_id":"694769f37b020caef16a58ff42829d314c8bb5a8"}],"ironic/drivers/modules/image_cache.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2a2d36bb3a4988309c500c769ec23add1a60c5e7","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                           disable_validation\u003dself._disable_validation,"},{"line_number":235,"context_line":"                           image_auth_data\u003dimage_auth_data)"},{"line_number":236,"context_line":"            except OSError as exc:"},{"line_number":237,"context_line":"                msg \u003d (_(\"Could not download image %(img_href)s to temp file \""},{"line_number":238,"context_line":"                         \"%(tmp_path)s, error: %(exc)s\") %"},{"line_number":239,"context_line":"                       {\u0027img_href\u0027: href, \u0027tmp_path\u0027: tmp_path, \u0027exc\u0027: exc})"},{"line_number":240,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"24d5ba6f_36c3bec4","line":237,"updated":"2025-11-26 18:11:13.000000000","message":"I wonder in which cases we actually get OSError here. It\u0027s not the download itself, but there are plenty of calls to os.* stuff deep inside _fetch..","commit_id":"694769f37b020caef16a58ff42829d314c8bb5a8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2a2d36bb3a4988309c500c769ec23add1a60c5e7","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            except OSError as exc:"},{"line_number":255,"context_line":"                msg \u003d (_(\"Could not link image %(img_href)s from %(src_path)s \""},{"line_number":256,"context_line":"                         \"to %(dst_path)s, error: %(exc)s\") %"},{"line_number":257,"context_line":"                       {\u0027img_href\u0027: href, \u0027src_path\u0027: master_path,"},{"line_number":258,"context_line":"                        \u0027dst_path\u0027: dest_path, \u0027exc\u0027: exc})"},{"line_number":259,"context_line":"                LOG.error(msg)"},{"line_number":260,"context_line":"                raise exception.ImageDownloadFailed(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3d012786_a5a5f7bf","line":257,"updated":"2025-11-26 18:11:13.000000000","message":"src_path is tmp_path, not master_path","commit_id":"694769f37b020caef16a58ff42829d314c8bb5a8"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"f3e09b998a2cf89793ca6b9fdf4675439803d799","unresolved":true,"context_lines":[{"line_number":254,"context_line":"            except OSError as exc:"},{"line_number":255,"context_line":"                msg \u003d (_(\"Could not link image %(img_href)s from %(src_path)s \""},{"line_number":256,"context_line":"                         \"to %(dst_path)s, error: %(exc)s\") %"},{"line_number":257,"context_line":"                       {\u0027img_href\u0027: href, \u0027src_path\u0027: master_path,"},{"line_number":258,"context_line":"                        \u0027dst_path\u0027: dest_path, \u0027exc\u0027: exc})"},{"line_number":259,"context_line":"                LOG.error(msg)"},{"line_number":260,"context_line":"                raise exception.ImageDownloadFailed(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ded26a0f_2bf5c5e8","line":257,"in_reply_to":"3d012786_a5a5f7bf","updated":"2025-12-02 17:50:40.000000000","message":"But it\u0027s not.\n\nYou added previously two calls to os.link() and the message is literally unchanged from your original message. There\u0027s no code change. Just an indention change. This is still the identical behavior and message to what you committed previously.","commit_id":"694769f37b020caef16a58ff42829d314c8bb5a8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5a905a9e88e1e1267ae90d8c3c481c8274179836","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            except OSError as exc:"},{"line_number":255,"context_line":"                msg \u003d (_(\"Could not link image %(img_href)s from %(src_path)s \""},{"line_number":256,"context_line":"                         \"to %(dst_path)s, error: %(exc)s\") %"},{"line_number":257,"context_line":"                       {\u0027img_href\u0027: href, \u0027src_path\u0027: master_path,"},{"line_number":258,"context_line":"                        \u0027dst_path\u0027: dest_path, \u0027exc\u0027: exc})"},{"line_number":259,"context_line":"                LOG.error(msg)"},{"line_number":260,"context_line":"                raise exception.ImageDownloadFailed(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b5f03b81_ef37c388","line":257,"in_reply_to":"ded26a0f_2bf5c5e8","updated":"2025-12-02 17:54:38.000000000","message":"Right, so it was not quite perfect before, my bad","commit_id":"694769f37b020caef16a58ff42829d314c8bb5a8"}]}