)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4b3cbad6fb2b05e223fa287b3c9d9d1be3aaf4b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"464bf375_0e6baf2c","updated":"2025-12-18 14:45:29.000000000","message":"Seems like this is also release note worthy...","commit_id":"fe2048a6d03989e9cd56ff72c3cb1e0171195b73"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"62e27f9249f0cc3d7d483ed139d6c6aa8cf940f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"52018c0d_0c60bb4a","updated":"2026-01-06 10:40:14.000000000","message":"recheck metal3-integration","commit_id":"7ed08e0b960d31ba2cad3ceb9442e17de201ca0b"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"76525c0473603c16c7b1017f18109c0bbca9cb27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bc988ac4_5a0f00c5","updated":"2026-01-20 20:24:12.000000000","message":"recheck","commit_id":"2306d90f8c6f597a0b4563219e34a8c74951b285"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"a18e7990d0275d67e9a2c3116495efd286c17b4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"70fa8bba_13868366","updated":"2026-01-20 17:39:54.000000000","message":"recheck tests are fixed","commit_id":"2306d90f8c6f597a0b4563219e34a8c74951b285"}],"ironic/drivers/modules/redfish/firmware.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4b3cbad6fb2b05e223fa287b3c9d9d1be3aaf4b7","unresolved":true,"context_lines":[{"line_number":888,"context_line":"                    node.set_driver_internal_info(\u0027redfish_fw_updates\u0027,"},{"line_number":889,"context_line":"                                                  settings)"},{"line_number":890,"context_line":"                    node.save()"},{"line_number":891,"context_line":"                    manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":892,"context_line":"                    return"},{"line_number":893,"context_line":"                else:"},{"line_number":894,"context_line":"                    # Reboot was already triggered when task started,"}],"source_content_type":"text/x-python","patch_set":2,"id":"75fe1963_8dc6b16e","line":891,"updated":"2025-12-18 14:45:29.000000000","message":"At a minimum, we need to add a unit test to capture this alternate path and verify we don\u0027t break it. i.e. verify REBOOT is called and that _continue_updates is not called if bios_reboot_triggered sends us down this path.","commit_id":"fe2048a6d03989e9cd56ff72c3cb1e0171195b73"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"817ec443efbdf7d8a2b0579ab6a625a301b225d9","unresolved":false,"context_lines":[{"line_number":888,"context_line":"                    node.set_driver_internal_info(\u0027redfish_fw_updates\u0027,"},{"line_number":889,"context_line":"                                                  settings)"},{"line_number":890,"context_line":"                    node.save()"},{"line_number":891,"context_line":"                    manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":892,"context_line":"                    return"},{"line_number":893,"context_line":"                else:"},{"line_number":894,"context_line":"                    # Reboot was already triggered when task started,"}],"source_content_type":"text/x-python","patch_set":2,"id":"91423bbf_304530c6","line":891,"in_reply_to":"75fe1963_8dc6b16e","updated":"2025-12-19 01:00:31.000000000","message":"Done","commit_id":"fe2048a6d03989e9cd56ff72c3cb1e0171195b73"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4b3cbad6fb2b05e223fa287b3c9d9d1be3aaf4b7","unresolved":true,"context_lines":[{"line_number":889,"context_line":"                                                  settings)"},{"line_number":890,"context_line":"                    node.save()"},{"line_number":891,"context_line":"                    manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":892,"context_line":"                    return"},{"line_number":893,"context_line":"                else:"},{"line_number":894,"context_line":"                    # Reboot was already triggered when task started,"},{"line_number":895,"context_line":"                    # just continue with next update"}],"source_content_type":"text/x-python","patch_set":2,"id":"17b2be74_0881ee64","line":892,"updated":"2025-12-18 14:45:29.000000000","message":"Will this return prevent this method from ever being called again and _continue_updates from being called? Given that there is a reboot in the middle, curious.","commit_id":"fe2048a6d03989e9cd56ff72c3cb1e0171195b73"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"817ec443efbdf7d8a2b0579ab6a625a301b225d9","unresolved":false,"context_lines":[{"line_number":889,"context_line":"                                                  settings)"},{"line_number":890,"context_line":"                    node.save()"},{"line_number":891,"context_line":"                    manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":892,"context_line":"                    return"},{"line_number":893,"context_line":"                else:"},{"line_number":894,"context_line":"                    # Reboot was already triggered when task started,"},{"line_number":895,"context_line":"                    # just continue with next update"}],"source_content_type":"text/x-python","patch_set":2,"id":"08d80605_0643fc73","line":892,"in_reply_to":"17b2be74_0881ee64","updated":"2025-12-19 01:00:31.000000000","message":"so, my understanding is that the return will exit the current execution of the periodic task, but since we have information about the bios_reboot_triggered we will use the information when the periodic task calls the method again in the next pool, and would execute the else block and call continue_updates","commit_id":"fe2048a6d03989e9cd56ff72c3cb1e0171195b73"}]}