)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d28c7d693ff9ae5d2d214728582adbee29fcbcc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c44f82ba_91706d93","updated":"2025-12-18 14:49:41.000000000","message":"At a minimum, unit tests and a release note are required.","commit_id":"4647ec69100fc82f05605afa598b159e154cee4f"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"7faa450a4de9f987704c8f357e8ae3228aab75ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"23aea4e9_a3a45f14","updated":"2025-12-17 07:17:21.000000000","message":"I recognize this may not be ready for reviews yet (even though I just reviewed it :D), so, I\u0027m withholding my vote.\n\nnit: This could use a unit test and an LP bug for reference.","commit_id":"4647ec69100fc82f05605afa598b159e154cee4f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"8b1597b44bfa50165035271a2dea6f34ba249d3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0de8ccbf_e074220a","updated":"2025-12-16 12:54:33.000000000","message":"recheck failure","commit_id":"4647ec69100fc82f05605afa598b159e154cee4f"}],"ironic/drivers/modules/redfish/power.py":[{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"7faa450a4de9f987704c8f357e8ae3228aab75ce","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    :raises: RedfishError on an error from the Sushy library"},{"line_number":78,"context_line":"    \"\"\""},{"line_number":79,"context_line":"    # Retry delays for transient BMC errors"},{"line_number":80,"context_line":"    retry_delays \u003d [5, 10, 15, 20]"},{"line_number":81,"context_line":"    last_exception \u003d None"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    for attempt in range(len(retry_delays)+1):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bd6b2f6b_0d5c7f16","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":34},"updated":"2025-12-17 07:17:21.000000000","message":"extra +50seconds potential delay for all 500 errors, for all vendors. It should be vendor-scoped, configurable, or limited to a single retry given the issue, as noted, is transient errors \"immediately\" after firmware updates","commit_id":"4647ec69100fc82f05605afa598b159e154cee4f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d28c7d693ff9ae5d2d214728582adbee29fcbcc7","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    :raises: RedfishError on an error from the Sushy library"},{"line_number":78,"context_line":"    \"\"\""},{"line_number":79,"context_line":"    # Retry delays for transient BMC errors"},{"line_number":80,"context_line":"    retry_delays \u003d [5, 10, 15, 20]"},{"line_number":81,"context_line":"    last_exception \u003d None"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    for attempt in range(len(retry_delays)+1):"}],"source_content_type":"text/x-python","patch_set":1,"id":"cd60eaf4_422470c8","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":34},"in_reply_to":"bd6b2f6b_0d5c7f16","updated":"2025-12-18 14:49:41.000000000","message":".... Yeah, that worries me, but I agree with cid. I *really* don\u0027t like holding sleep times statically.\n\nI could see it being reasonable like \"oh, the bmc stopped responding and now we\u0027re getting 500s\" and then dialing back heavily. We don\u0027t really have the framework for that yet, but I\u0027m super hesitant about this approach.\n\nThe other concerning item is we\u0027re holding a lock the entire time. That is fine, but all other actions for the host will halt during this.","commit_id":"4647ec69100fc82f05605afa598b159e154cee4f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"6dd55f61f95f7f741bd72fdd622d27bd9bf32201","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    :raises: RedfishError on an error from the Sushy library"},{"line_number":78,"context_line":"    \"\"\""},{"line_number":79,"context_line":"    # Retry delays for transient BMC errors"},{"line_number":80,"context_line":"    retry_delays \u003d [5, 10, 15, 20]"},{"line_number":81,"context_line":"    last_exception \u003d None"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    for attempt in range(len(retry_delays)+1):"}],"source_content_type":"text/x-python","patch_set":1,"id":"089ef0ea_04121439","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":34},"in_reply_to":"cd60eaf4_422470c8","updated":"2025-12-19 19:26:00.000000000","message":"Thank you Julia and CID!\nWe are testing different approaches downstream first and will update the patch, maybe it won\u0027t be necessary the change here in power.py","commit_id":"4647ec69100fc82f05605afa598b159e154cee4f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d28c7d693ff9ae5d2d214728582adbee29fcbcc7","unresolved":true,"context_lines":[{"line_number":94,"context_line":"                        {\u0027node\u0027: task.node.uuid, \u0027delay\u0027: delay,"},{"line_number":95,"context_line":"                         \u0027attempt\u0027: attempt + 1, \u0027total\u0027: len(retry_delays),"},{"line_number":96,"context_line":"                         \u0027error\u0027: e})"},{"line_number":97,"context_line":"                time.sleep(delay)"},{"line_number":98,"context_line":"                continue"},{"line_number":99,"context_line":"            last_exception \u003d e"},{"line_number":100,"context_line":"            break"}],"source_content_type":"text/x-python","patch_set":1,"id":"2eb9d058_ffa92338","line":97,"updated":"2025-12-18 14:49:41.000000000","message":"This is causing the urge to spend time on the deferred tasks work.","commit_id":"4647ec69100fc82f05605afa598b159e154cee4f"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"7faa450a4de9f987704c8f357e8ae3228aab75ce","unresolved":true,"context_lines":[{"line_number":96,"context_line":"                         \u0027error\u0027: e})"},{"line_number":97,"context_line":"                time.sleep(delay)"},{"line_number":98,"context_line":"                continue"},{"line_number":99,"context_line":"            last_exception \u003d e"},{"line_number":100,"context_line":"            break"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    if last_exception:"},{"line_number":103,"context_line":"        raise last_exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"44e66db0_b3052111","line":100,"range":{"start_line":99,"start_character":12,"end_line":100,"end_character":17},"updated":"2025-12-17 07:17:21.000000000","message":"I don\u0027t see why we cannot `raise` here; and `RedfishError` too, to match the docstring.","commit_id":"4647ec69100fc82f05605afa598b159e154cee4f"}]}