)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"17a226ce7ad76d58b009ac24bf426397e9c84aeb","unresolved":false,"context_lines":[{"line_number":399,"context_line":"            new_state \u003d task.driver.deploy.deploy(task)"},{"line_number":400,"context_line":"        except Exception as e:"},{"line_number":401,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":402,"context_line":"                LOG.warning(_(\u0027Error in deploy of node %(node): %(err)\u0027),"},{"line_number":403,"context_line":"                            {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e})"},{"line_number":404,"context_line":"                node.last_error \u003d _(\"Failed to deploy. Error: %s\") % e"},{"line_number":405,"context_line":"                node.provision_state \u003d states.DEPLOYFAIL"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_2c5df1e9","line":402,"updated":"2014-06-03 04:23:11.000000000","message":"%(node)s and %(err)s","commit_id":"3c7a7364a3bb2f09ff1d860022245d10cb6971a1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c4dfd22bead3daeec31ee4245f898bfa3ab67028","unresolved":false,"context_lines":[{"line_number":399,"context_line":"            new_state \u003d task.driver.deploy.deploy(task)"},{"line_number":400,"context_line":"        except Exception as e:"},{"line_number":401,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":402,"context_line":"                LOG.warning(_(\u0027Error in deploy of node %(node): %(err)\u0027),"},{"line_number":403,"context_line":"                            {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e})"},{"line_number":404,"context_line":"                node.last_error \u003d _(\"Failed to deploy. Error: %s\") % e"},{"line_number":405,"context_line":"                node.provision_state \u003d states.DEPLOYFAIL"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_c8be30d4","line":402,"in_reply_to":"1ae5cdf2_2c5df1e9","updated":"2014-06-03 09:18:39.000000000","message":"Isn\u0027t this log an Error instead of a Warning? The way I see it is that the client tried to deploy a node and the operation was aborted because of an error, I would use a warning for cases like: \"Something went wrong with the operation but we are going to continue\" like in some cases where there\u0027s a fallback in place or a retry if something went wrong but the operation continues.\n\nI usually look at the logs as:\n\nINFO for success.\n\nERROR for failures that only affects that operation.\n\nWARNING for failures that will be automatic retried or fallback somehow.\n\nCRITICAL for errors that compromise the whole service.\n\nDEBUG for the rest.","commit_id":"3c7a7364a3bb2f09ff1d860022245d10cb6971a1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c4dfd22bead3daeec31ee4245f898bfa3ab67028","unresolved":false,"context_lines":[{"line_number":467,"context_line":"        except Exception as e:"},{"line_number":468,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":469,"context_line":"                LOG.warning(_(\u0027Error in tear_down of node %(node): %(err)\u0027),"},{"line_number":470,"context_line":"                            {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e})"},{"line_number":471,"context_line":"                node.last_error \u003d _(\"Failed to tear down. Error: %s\") % e"},{"line_number":472,"context_line":"                node.provision_state \u003d states.ERROR"},{"line_number":473,"context_line":"                node.target_provision_state \u003d states.NOSTATE"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_a87ac4ee","line":470,"updated":"2014-06-03 09:18:39.000000000","message":"ditto","commit_id":"3c7a7364a3bb2f09ff1d860022245d10cb6971a1"}]}