)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b015acdc676496688835b1f788d66905f3a45963","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Doug Goldstein \u003ccardoe@cardoe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-01-13 12:03:10 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"feat: skip invalid mac addr interfaces in redfish inspect add speed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Refactor the redfish interfaces inspection by moving it to its own"},{"line_number":10,"context_line":"function, but preserving the behavior of not having an interfaces key in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"53f87ed3_caa1c123","line":7,"updated":"2026-01-29 15:03:16.000000000","message":"fyi, its more a fix, than anything else ;)","commit_id":"3220a0cc6617dfa026ff3febc0bdd4a227320759"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c792d836cd7df937d6f23934562c65dbf9c5968a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"18b1c19e_44b0d2fe","updated":"2026-01-15 22:36:42.000000000","message":"Please add a release note.","commit_id":"3220a0cc6617dfa026ff3febc0bdd4a227320759"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"3b92ed792e91733dc4a2f6afdcb745511ae10c47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d9de5cd3_52c60c09","in_reply_to":"18b1c19e_44b0d2fe","updated":"2026-01-23 02:22:05.000000000","message":"Done","commit_id":"3220a0cc6617dfa026ff3febc0bdd4a227320759"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"3b92ed792e91733dc4a2f6afdcb745511ae10c47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"58f91fa4_8a3d2ef5","updated":"2026-01-23 02:22:05.000000000","message":"Added a release note. No other changes.","commit_id":"91448d4de9ab62dddb03a8f0cc17b4122cf930f0"},{"author":{"_account_id":35099,"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","username":"kubajj"},"change_message_id":"cbd1e1874923d3c658b1d357627483a67c848d10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9ef79b6b_2d57fce7","updated":"2026-01-23 13:29:08.000000000","message":"LGTM","commit_id":"91448d4de9ab62dddb03a8f0cc17b4122cf930f0"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"8816abaeb880efbd48ad0cfa9fdb51a505bd32ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1e6e6ce0_654b7e1a","updated":"2026-01-23 14:53:03.000000000","message":"Thanks for the change, Doug. Generally LGTM, couple small comments","commit_id":"91448d4de9ab62dddb03a8f0cc17b4122cf930f0"}],"ironic/drivers/modules/redfish/inspect.py":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"8816abaeb880efbd48ad0cfa9fdb51a505bd32ef","unresolved":true,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        for eth in system.ethernet_interfaces.get_members():"},{"line_number":317,"context_line":"            if not netutils.is_valid_mac(eth.mac_address):"},{"line_number":318,"context_line":"                LOG.warning(_(\"Ignoring NIC address \u0027%(address)s\u0027 for \""},{"line_number":319,"context_line":"                              \"interface %(inf)s on node %(node)s because it \""},{"line_number":320,"context_line":"                              \"is not a valid MAC\"),"},{"line_number":321,"context_line":"                            {\u0027address\u0027: eth.mac_address,"},{"line_number":322,"context_line":"                             \u0027inf\u0027: eth.identity,"},{"line_number":323,"context_line":"                             \u0027node\u0027: task.node.uuid})"},{"line_number":324,"context_line":"                continue"},{"line_number":325,"context_line":"            intf \u003d {"},{"line_number":326,"context_line":"                \u0027mac_address\u0027: eth.mac_address,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3be03fa5_4458f1a7","line":323,"range":{"start_line":318,"start_character":16,"end_line":323,"end_character":53},"updated":"2026-01-23 14:53:03.000000000","message":"nit: _() doesn\u0027t seem common in this part of code, but I would only consider changing this in case you end up making other changes","commit_id":"91448d4de9ab62dddb03a8f0cc17b4122cf930f0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04d810837eedc059d9056fe7fb992d4ce3d8d423","unresolved":true,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        for eth in system.ethernet_interfaces.get_members():"},{"line_number":317,"context_line":"            if not netutils.is_valid_mac(eth.mac_address):"},{"line_number":318,"context_line":"                LOG.warning(_(\"Ignoring NIC address \u0027%(address)s\u0027 for \""},{"line_number":319,"context_line":"                              \"interface %(inf)s on node %(node)s because it \""},{"line_number":320,"context_line":"                              \"is not a valid MAC\"),"},{"line_number":321,"context_line":"                            {\u0027address\u0027: eth.mac_address,"},{"line_number":322,"context_line":"                             \u0027inf\u0027: eth.identity,"},{"line_number":323,"context_line":"                             \u0027node\u0027: task.node.uuid})"},{"line_number":324,"context_line":"                continue"},{"line_number":325,"context_line":"            intf \u003d {"},{"line_number":326,"context_line":"                \u0027mac_address\u0027: eth.mac_address,"}],"source_content_type":"text/x-python","patch_set":2,"id":"274a22eb_455539fd","line":323,"range":{"start_line":318,"start_character":16,"end_line":323,"end_character":53},"in_reply_to":"3be03fa5_4458f1a7","updated":"2026-01-27 16:52:55.000000000","message":"We don\u0027t translate warnings, so yeah","commit_id":"91448d4de9ab62dddb03a8f0cc17b4122cf930f0"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"8816abaeb880efbd48ad0cfa9fdb51a505bd32ef","unresolved":true,"context_lines":[{"line_number":328,"context_line":"            }"},{"line_number":329,"context_line":"            try:"},{"line_number":330,"context_line":"                intf[\u0027speed_mbps\u0027] \u003d int(eth.speed_mbps)"},{"line_number":331,"context_line":"            except Exception:"},{"line_number":332,"context_line":"                pass"},{"line_number":333,"context_line":"            ret.append(intf)"},{"line_number":334,"context_line":"        return ret"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffecfa8_fe3e7347","line":331,"range":{"start_line":331,"start_character":12,"end_line":331,"end_character":29},"updated":"2026-01-23 14:53:03.000000000","message":"nit: is it worth considering matching for specific/relevant exceptions?","commit_id":"91448d4de9ab62dddb03a8f0cc17b4122cf930f0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04d810837eedc059d9056fe7fb992d4ce3d8d423","unresolved":true,"context_lines":[{"line_number":328,"context_line":"            }"},{"line_number":329,"context_line":"            try:"},{"line_number":330,"context_line":"                intf[\u0027speed_mbps\u0027] \u003d int(eth.speed_mbps)"},{"line_number":331,"context_line":"            except Exception:"},{"line_number":332,"context_line":"                pass"},{"line_number":333,"context_line":"            ret.append(intf)"},{"line_number":334,"context_line":"        return ret"}],"source_content_type":"text/x-python","patch_set":2,"id":"8053ba3a_7a4d6595","line":331,"range":{"start_line":331,"start_character":12,"end_line":331,"end_character":29},"in_reply_to":"7ffecfa8_fe3e7347","updated":"2026-01-27 16:52:55.000000000","message":"I\u0027d also prefer it, but it\u0027s not critical for such trivial code","commit_id":"91448d4de9ab62dddb03a8f0cc17b4122cf930f0"}],"ironic/tests/unit/drivers/modules/redfish/test_inspect.py":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"8816abaeb880efbd48ad0cfa9fdb51a505bd32ef","unresolved":true,"context_lines":[{"line_number":197,"context_line":"    @mock.patch.object(redfish_utils, \u0027get_system\u0027, autospec\u003dTrue)"},{"line_number":198,"context_line":"    @mock.patch.object(inspect_utils, \u0027create_ports_if_not_exist\u0027,"},{"line_number":199,"context_line":"                       autospec\u003dTrue)"},{"line_number":200,"context_line":"    def test_inspect_hardware_ok(self, mock_create_ports_if_not_exist,"},{"line_number":201,"context_line":"                                 mock_get_system,"},{"line_number":202,"context_line":"                                 mock_get_enabled_macs):"},{"line_number":203,"context_line":"        expected_properties \u003d {"},{"line_number":204,"context_line":"            \u0027capabilities\u0027: \u0027boot_mode:uefi\u0027,"},{"line_number":205,"context_line":"            \u0027cpu_arch\u0027: \u0027x86_64\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"d5d532f4_f31973f7","line":202,"range":{"start_line":200,"start_character":0,"end_line":202,"end_character":56},"updated":"2026-01-23 14:53:03.000000000","message":"suggestion: is it worth testing for scenarios where:\n1) one of the MACs is invalid\n2) if mbps info is not provided?","commit_id":"91448d4de9ab62dddb03a8f0cc17b4122cf930f0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04d810837eedc059d9056fe7fb992d4ce3d8d423","unresolved":true,"context_lines":[{"line_number":197,"context_line":"    @mock.patch.object(redfish_utils, \u0027get_system\u0027, autospec\u003dTrue)"},{"line_number":198,"context_line":"    @mock.patch.object(inspect_utils, \u0027create_ports_if_not_exist\u0027,"},{"line_number":199,"context_line":"                       autospec\u003dTrue)"},{"line_number":200,"context_line":"    def test_inspect_hardware_ok(self, mock_create_ports_if_not_exist,"},{"line_number":201,"context_line":"                                 mock_get_system,"},{"line_number":202,"context_line":"                                 mock_get_enabled_macs):"},{"line_number":203,"context_line":"        expected_properties \u003d {"},{"line_number":204,"context_line":"            \u0027capabilities\u0027: \u0027boot_mode:uefi\u0027,"},{"line_number":205,"context_line":"            \u0027cpu_arch\u0027: \u0027x86_64\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9507a0af_0c52c477","line":202,"range":{"start_line":200,"start_character":0,"end_line":202,"end_character":56},"in_reply_to":"d5d532f4_f31973f7","updated":"2026-01-27 16:52:55.000000000","message":"I\u0027d definitely prefer a test for an invalid MAC","commit_id":"91448d4de9ab62dddb03a8f0cc17b4122cf930f0"}],"releasenotes/notes/redfish-inspect-invalid-mac-speed-bd0f7802cf18bd5d.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04d810837eedc059d9056fe7fb992d4ce3d8d423","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Update the ``redfish`` inspection interface to not include network interfaces"},{"line_number":5,"context_line":"    with invalid MACs. This brings the behavior inline with the ``agent``"},{"line_number":6,"context_line":"    inspection interface. Add the port speed if possible in the same format"},{"line_number":7,"context_line":"    as the ``agent`` interface to the ``redfish`` interface as well."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"810829cc_e04cf101","line":4,"updated":"2026-01-27 16:52:55.000000000","message":"nit: \"Updates\"\n\nbonus for splitting the note into two (for speed and for MACs)","commit_id":"91448d4de9ab62dddb03a8f0cc17b4122cf930f0"}]}