)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0ffb826e1ab7b023da4eeca916a505bac08ca0dd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"instance with preserve_ephemeral set to true. The reworked logic will"},{"line_number":11,"context_line":"no longer wipe the current partitions when rebuilding an instance with"},{"line_number":12,"context_line":"preserve_ephemeral set."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I15fc0d6323698eaa4c30b8aaa7fb740f51c035bc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ae5cdf2_f7afe97a","line":13,"updated":"2014-06-05 15:33:43.000000000","message":"Is there a Bug for this?","commit_id":"cd4e722029623f713894a9e5b2cb025a61cd2c49"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"1bfa89a1a7ad19ea3932d43d82bc1411232a9427","unresolved":false,"context_lines":[{"line_number":10,"context_line":"instance with preserve_ephemeral set to true. The reworked logic will"},{"line_number":11,"context_line":"no longer wipe the current partitions when rebuilding an instance with"},{"line_number":12,"context_line":"preserve_ephemeral set."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I15fc0d6323698eaa4c30b8aaa7fb740f51c035bc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ae5cdf2_68577826","line":13,"in_reply_to":"1ae5cdf2_f7afe97a","updated":"2014-06-05 16:56:01.000000000","message":"Done","commit_id":"cd4e722029623f713894a9e5b2cb025a61cd2c49"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0ffb826e1ab7b023da4eeca916a505bac08ca0dd","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"def make_partitions(dev, root_mb, swap_mb, ephemeral_mb, commit\u003dTrue):"},{"line_number":83,"context_line":"    \"\"\"Create a partition table for the supplied device, based on root, swap,"},{"line_number":84,"context_line":"       and ephemeral partition sizes. By default, the partition table will be"},{"line_number":85,"context_line":"       written to disk, but this can be overwritten if commit\u003dFalse, in which"},{"line_number":86,"context_line":"       case the table structure will be returned but not written do the disk."}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_17f615f9","line":83,"updated":"2014-06-05 15:33:43.000000000","message":"I\u0027m curious as to why you\u0027re using \u0027partition table\u0027 vs \u0027partition\u0027.\n\nI checked the code in disk_partitioner.DiskPartitioner.commit() to make sure I understand, and it looks like it creates the partitions including a new MBR (cuz disk_label\u003d\u0027msdos\u0027) partition table.","commit_id":"cd4e722029623f713894a9e5b2cb025a61cd2c49"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"1bfa89a1a7ad19ea3932d43d82bc1411232a9427","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"def make_partitions(dev, root_mb, swap_mb, ephemeral_mb, commit\u003dTrue):"},{"line_number":83,"context_line":"    \"\"\"Create a partition table for the supplied device, based on root, swap,"},{"line_number":84,"context_line":"       and ephemeral partition sizes. By default, the partition table will be"},{"line_number":85,"context_line":"       written to disk, but this can be overwritten if commit\u003dFalse, in which"},{"line_number":86,"context_line":"       case the table structure will be returned but not written do the disk."}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_288c90d9","line":83,"in_reply_to":"1ae5cdf2_17f615f9","updated":"2014-06-05 16:56:01.000000000","message":"Done","commit_id":"cd4e722029623f713894a9e5b2cb025a61cd2c49"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0ffb826e1ab7b023da4eeca916a505bac08ca0dd","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    \"\"\"Create a partition table for the supplied device, based on root, swap,"},{"line_number":84,"context_line":"       and ephemeral partition sizes. By default, the partition table will be"},{"line_number":85,"context_line":"       written to disk, but this can be overwritten if commit\u003dFalse, in which"},{"line_number":86,"context_line":"       case the table structure will be returned but not written do the disk."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    :param root_mb: Size of the root partition in mebibytes (MiB)."},{"line_number":89,"context_line":"    :param swap_mb: Size of the swap partition in mebibytes (MiB). If 0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_812e67a3","line":86,"updated":"2014-06-05 15:33:43.000000000","message":"nit: \u0027do\u0027 -\u003e \u0027to\u0027","commit_id":"cd4e722029623f713894a9e5b2cb025a61cd2c49"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"1bfa89a1a7ad19ea3932d43d82bc1411232a9427","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    \"\"\"Create a partition table for the supplied device, based on root, swap,"},{"line_number":84,"context_line":"       and ephemeral partition sizes. By default, the partition table will be"},{"line_number":85,"context_line":"       written to disk, but this can be overwritten if commit\u003dFalse, in which"},{"line_number":86,"context_line":"       case the table structure will be returned but not written do the disk."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    :param root_mb: Size of the root partition in mebibytes (MiB)."},{"line_number":89,"context_line":"    :param swap_mb: Size of the swap partition in mebibytes (MiB). If 0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_689218f7","line":86,"in_reply_to":"1ae5cdf2_812e67a3","updated":"2014-06-05 16:56:01.000000000","message":"Done","commit_id":"cd4e722029623f713894a9e5b2cb025a61cd2c49"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0ffb826e1ab7b023da4eeca916a505bac08ca0dd","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    # the only way for preserve_ephemeral to be set to true is if we are"},{"line_number":217,"context_line":"    # rebuilding an instance with --preserve_ephemeral."},{"line_number":218,"context_line":"    if preserve_ephemeral:"},{"line_number":219,"context_line":"        # calling make_partitions with commit False so just part_dict is"},{"line_number":220,"context_line":"        # returned and nothing is written to the disk."},{"line_number":221,"context_line":"        part_dict \u003d make_partitions(dev, root_mb, swap_mb, ephemeral_mb,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_f781a9fb","line":218,"updated":"2014-06-05 15:33:43.000000000","message":"I don\u0027t know if this is any better, so mentioning and leaving up to you.\n\nYou could replace all this with (+ appropriate comments):\n    part_dict \u003d make_partitions(dev, root_mb, ..., commit\u003dnot preserve_ephemeral)","commit_id":"cd4e722029623f713894a9e5b2cb025a61cd2c49"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"1bfa89a1a7ad19ea3932d43d82bc1411232a9427","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    # the only way for preserve_ephemeral to be set to true is if we are"},{"line_number":217,"context_line":"    # rebuilding an instance with --preserve_ephemeral."},{"line_number":218,"context_line":"    if preserve_ephemeral:"},{"line_number":219,"context_line":"        # calling make_partitions with commit False so just part_dict is"},{"line_number":220,"context_line":"        # returned and nothing is written to the disk."},{"line_number":221,"context_line":"        part_dict \u003d make_partitions(dev, root_mb, swap_mb, ephemeral_mb,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_887be4bc","line":218,"in_reply_to":"1ae5cdf2_f781a9fb","updated":"2014-06-05 16:56:01.000000000","message":"Unless others comment, I find the if block more readable then \"commit\u003dnot preserve_ephemeral\"","commit_id":"cd4e722029623f713894a9e5b2cb025a61cd2c49"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bfbef31685b9658cf44538b64a99494bca46119a","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"def make_partitions(dev, root_mb, swap_mb, ephemeral_mb, commit\u003dTrue):"},{"line_number":83,"context_line":"    \"\"\"Create a partitions for the supplied device, based on root, swap,"},{"line_number":84,"context_line":"       and ephemeral partition sizes. By default, the partition table will be"},{"line_number":85,"context_line":"       written to disk, but this can be overwritten if commit\u003dFalse, in which"},{"line_number":86,"context_line":"       case the table structure will be returned but not written to the disk."}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_d00e6e8b","line":83,"updated":"2014-06-05 18:35:01.000000000","message":"\"Create a\" -\u003e \"Creates\"","commit_id":"bc96348615be732df68a5c77017e15697678b0a9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bfbef31685b9658cf44538b64a99494bca46119a","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"def make_partitions(dev, root_mb, swap_mb, ephemeral_mb, commit\u003dTrue):"},{"line_number":83,"context_line":"    \"\"\"Create a partitions for the supplied device, based on root, swap,"},{"line_number":84,"context_line":"       and ephemeral partition sizes. By default, the partition table will be"},{"line_number":85,"context_line":"       written to disk, but this can be overwritten if commit\u003dFalse, in which"},{"line_number":86,"context_line":"       case the table structure will be returned but not written to the disk."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_d0858ecf","line":84,"updated":"2014-06-05 18:35:01.000000000","message":"\"partition table\" -\u003e \"partitions (and partition table)\" or just \"partitions\"?","commit_id":"bc96348615be732df68a5c77017e15697678b0a9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bfbef31685b9658cf44538b64a99494bca46119a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    \"\"\"Create a partitions for the supplied device, based on root, swap,"},{"line_number":84,"context_line":"       and ephemeral partition sizes. By default, the partition table will be"},{"line_number":85,"context_line":"       written to disk, but this can be overwritten if commit\u003dFalse, in which"},{"line_number":86,"context_line":"       case the table structure will be returned but not written to the disk."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    :param root_mb: Size of the root partition in mebibytes (MiB)."},{"line_number":89,"context_line":"    :param swap_mb: Size of the swap partition in mebibytes (MiB). If 0,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_100a9625","line":86,"updated":"2014-06-05 18:35:01.000000000","message":"\"table structure\" -\u003e ?? dunno, \"partition information\" or \"partition paths\"?\n\n\"not written\" -\u003e \"the partitions won\u0027t be written to disk\".","commit_id":"bc96348615be732df68a5c77017e15697678b0a9"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"006cdef45d3e19bef4e40ff484f005c09af0384c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"       and ephemeral partition sizes. By default, the partitions will be"},{"line_number":85,"context_line":"       written to disk, but this can be overwritten if commit\u003dFalse, in which"},{"line_number":86,"context_line":"       case the partition information will be returned but not written to the"},{"line_number":87,"context_line":"       disk."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    :param root_mb: Size of the root partition in mebibytes (MiB)."},{"line_number":90,"context_line":"    :param swap_mb: Size of the swap partition in mebibytes (MiB). If 0,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_0e1dc073","line":87,"updated":"2014-06-09 17:52:40.000000000","message":"This is no longer a validly formatted docstring: http://legacy.python.org/dev/peps/pep-0257/#multi-line-docstrings \"The summary line may be used by automatic indexing tools; it is important that it fits on one line and is separated from the rest of the docstring by a blank line. \"\n\nKeep the original one line summary, it is still valid and correct.\n\nIn fact, the new prose up the top is entirely redundant with the commit parameter docs below, so just make those a little more verbose and you\u0027re done.","commit_id":"0ffaf192ea531ea2f21ca048e1e78544bbad43c7"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"006cdef45d3e19bef4e40ff484f005c09af0384c","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                                    commit\u003dFalse)"},{"line_number":224,"context_line":"    else:"},{"line_number":225,"context_line":"        # Create partitions on the disk"},{"line_number":226,"context_line":"        part_dict \u003d make_partitions(dev, root_mb, swap_mb, ephemeral_mb)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    ephemeral_part \u003d part_dict.get(\u0027ephemeral\u0027)"},{"line_number":229,"context_line":"    swap_part \u003d part_dict.get(\u0027swap\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_490ee235","line":226,"updated":"2014-06-09 17:52:40.000000000","message":"This has redundant code that will skew; I think it be better like this:\n\n commit\u003dnot preserve_ephemeral\n part_dict \u003d make_partitions(\n         dev, root_mb, swap_mb, ephemeral_mb, commit\u003dcommit)","commit_id":"0ffaf192ea531ea2f21ca048e1e78544bbad43c7"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"f88e1f35d200d3ae7bad25d155d5a6b4bc010a45","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    :param ephemeral_mb: Size of the ephemeral partition in mebibytes (MiB)."},{"line_number":89,"context_line":"        If 0, no ephemeral partition will be created."},{"line_number":90,"context_line":"    :param commit: True/False. Default for this setting is True. If False"},{"line_number":91,"context_line":"        partitions wille not be written to disk."},{"line_number":92,"context_line":"    :returns: A dictionary containing the partition type as Key and partition"},{"line_number":93,"context_line":"        path as Value for the partitions created by this method."},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_59e779e4","line":91,"updated":"2014-06-10 07:19:06.000000000","message":"Sorry, typo here. \u0027wille\u0027","commit_id":"6ec554e680c8e238bbcfa13c643c9caa42214f8b"}]}