)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"08b4d3faec0195653c6865185bb220c0e4a1b0eb","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PLDM channel not initialized after BMC update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The PLDM/MCTP communication channel used for NIC firmware updates doesn\u0027t"},{"line_number":10,"context_line":"become available until after a host reboot following BMC firmware updates."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Now we check if more firmware components are pending after BMC update."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b848c061_a367efca","line":9,"range":{"start_line":9,"start_character":45,"end_line":9,"end_character":49},"updated":"2026-03-21 14:41:51.000000000","message":"nit: s/device/","commit_id":"a1ace538649e34238c219ea28a40ac874698402b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"036b22f7c4de6e2616f169c55d7b22707b26f61f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PLDM channel not initialized after BMC update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The PLDM/MCTP communication channel used for NIC firmware updates doesn\u0027t"},{"line_number":10,"context_line":"become available until after a host reboot following BMC firmware updates."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Now we check if more firmware components are pending after BMC update."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"89f271ab_a533bd9a","line":9,"range":{"start_line":9,"start_character":45,"end_line":9,"end_character":49},"in_reply_to":"b848c061_a367efca","updated":"2026-03-23 00:00:36.000000000","message":"Done","commit_id":"a1ace538649e34238c219ea28a40ac874698402b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"08b4d3faec0195653c6865185bb220c0e4a1b0eb","unresolved":true,"context_lines":[{"line_number":7,"context_line":"PLDM channel not initialized after BMC update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The PLDM/MCTP communication channel used for NIC firmware updates doesn\u0027t"},{"line_number":10,"context_line":"become available until after a host reboot following BMC firmware updates."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Now we check if more firmware components are pending after BMC update."},{"line_number":13,"context_line":"If yes, triggers a host reboot before continuing to the next component,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1d780256_57e22444","line":10,"updated":"2026-03-21 14:41:51.000000000","message":"The PLDM channel is also what is used for some device discovery as well, basically meaning if a BMC software update is done without the host reboot, the bmc is going to be braindead if it looses configuration at all in the upgrade.","commit_id":"a1ace538649e34238c219ea28a40ac874698402b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"036b22f7c4de6e2616f169c55d7b22707b26f61f","unresolved":true,"context_lines":[{"line_number":7,"context_line":"PLDM channel not initialized after BMC update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The PLDM/MCTP communication channel used for NIC firmware updates doesn\u0027t"},{"line_number":10,"context_line":"become available until after a host reboot following BMC firmware updates."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Now we check if more firmware components are pending after BMC update."},{"line_number":13,"context_line":"If yes, triggers a host reboot before continuing to the next component,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"31722909_a71dd183","line":10,"in_reply_to":"1d780256_57e22444","updated":"2026-03-23 00:00:36.000000000","message":"Acknowledged","commit_id":"a1ace538649e34238c219ea28a40ac874698402b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3507bcd4143252fc809546a06e5504859824df84","unresolved":false,"context_lines":[{"line_number":7,"context_line":"PLDM channel not initialized after BMC update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The PLDM/MCTP communication channel used for NIC firmware updates doesn\u0027t"},{"line_number":10,"context_line":"become available until after a host reboot following BMC firmware updates."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Now we check if more firmware components are pending after BMC update."},{"line_number":13,"context_line":"If yes, triggers a host reboot before continuing to the next component,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"c799e625_69bb3880","line":10,"in_reply_to":"31722909_a71dd183","updated":"2026-04-01 01:57:45.000000000","message":"Done","commit_id":"a1ace538649e34238c219ea28a40ac874698402b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"96d3ddda0eadc4533dbb01a754a50520b36339a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c9e21597_1383f0ea","updated":"2026-02-16 20:14:47.000000000","message":"I\u0027d appreciate a bit more insight, I think I kind of get what is going on, but we need to be a little more verbose on commenting, and also likely move the lock upward since we are likely dealing with the lock too late that we create a race condition.","commit_id":"00280a9c4ab9aa1df4542bfdc3c4c9479407ce0b"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"14391d97e34562be3801e54f4b60afebbfdc2446","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6c80f610_d7ebbb9f","updated":"2026-03-23 18:42:31.000000000","message":"I can\u0027t really comment on whether this is the right way to solve the underlying bug/issue. However, the change appears correct based on the commit message.","commit_id":"024789682fa4b6c2aabfbe7b20659a0c6553a0cf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6a251364e9c61d1674562f8a692e3974cfb77c23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"92a330c8_07cb2aa0","updated":"2026-04-01 19:48:47.000000000","message":"Slight concern because I think we\u0027re introducing a bug here around locks, it wouldn\u0027t be abig deal if we were not changing the node though, but just ends up getting confusion.","commit_id":"09dbd4ce6637c221df088fdd01f6ac95ef983e60"}],"ironic/drivers/modules/redfish/firmware.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"96d3ddda0eadc4533dbb01a754a50520b36339a8","unresolved":true,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        :param task: a TaskManager instance"},{"line_number":450,"context_line":"        :param update_service: the sushy firmware update service"},{"line_number":451,"context_line":"        :param settings: firmware update settings"},{"line_number":452,"context_line":"        :param current_update: the current firmware update being processed"},{"line_number":453,"context_line":"        \"\"\""},{"line_number":454,"context_line":"        node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":2,"id":"600eaa30_5d177418","line":451,"updated":"2026-02-16 20:14:47.000000000","message":"How does the update settings result here, is it the list of pending updates?","commit_id":"00280a9c4ab9aa1df4542bfdc3c4c9479407ce0b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1b34ce16ad7a6e23e25d2f69c21555d2b847415a","unresolved":false,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        :param task: a TaskManager instance"},{"line_number":450,"context_line":"        :param update_service: the sushy firmware update service"},{"line_number":451,"context_line":"        :param settings: firmware update settings"},{"line_number":452,"context_line":"        :param current_update: the current firmware update being processed"},{"line_number":453,"context_line":"        \"\"\""},{"line_number":454,"context_line":"        node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f81b55a_780f4999","line":451,"in_reply_to":"600eaa30_5d177418","updated":"2026-03-12 02:35:18.000000000","message":"The list of pending updates","commit_id":"00280a9c4ab9aa1df4542bfdc3c4c9479407ce0b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"96d3ddda0eadc4533dbb01a754a50520b36339a8","unresolved":true,"context_lines":[{"line_number":471,"context_line":"                 \u0027new\u0027: current_version})"},{"line_number":472,"context_line":"            node.del_driver_internal_info(BMC_FW_VERSION_BEFORE_UPDATE)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"            # Check if more components are pending after the BMC update"},{"line_number":475,"context_line":"            if len(settings) \u003e 1:"},{"line_number":476,"context_line":"                # More components to update - trigger reboot before continuing"},{"line_number":477,"context_line":"                #  Some hardware can only execute NIC firmware updates after"}],"source_content_type":"text/x-python","patch_set":2,"id":"0116237b_9cf02267","line":474,"updated":"2026-02-16 20:14:47.000000000","message":"So is the issue here that some devices are still pending, because they haven\u0027t gotten their updates or the BMC hasn\u0027t cycled through to them to (because pldm and bit banging on the i2c bus), and thus they still show pending as representative of settings having more than one entry?","commit_id":"00280a9c4ab9aa1df4542bfdc3c4c9479407ce0b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1b34ce16ad7a6e23e25d2f69c21555d2b847415a","unresolved":true,"context_lines":[{"line_number":471,"context_line":"                 \u0027new\u0027: current_version})"},{"line_number":472,"context_line":"            node.del_driver_internal_info(BMC_FW_VERSION_BEFORE_UPDATE)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"            # Check if more components are pending after the BMC update"},{"line_number":475,"context_line":"            if len(settings) \u003e 1:"},{"line_number":476,"context_line":"                # More components to update - trigger reboot before continuing"},{"line_number":477,"context_line":"                #  Some hardware can only execute NIC firmware updates after"}],"source_content_type":"text/x-python","patch_set":2,"id":"b32bd90f_67bfc9fa","line":474,"in_reply_to":"0116237b_9cf02267","updated":"2026-03-12 02:35:18.000000000","message":"It\u0027s to check if we have more compoents to update.","commit_id":"00280a9c4ab9aa1df4542bfdc3c4c9479407ce0b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3507bcd4143252fc809546a06e5504859824df84","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                 \u0027new\u0027: current_version})"},{"line_number":472,"context_line":"            node.del_driver_internal_info(BMC_FW_VERSION_BEFORE_UPDATE)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"            # Check if more components are pending after the BMC update"},{"line_number":475,"context_line":"            if len(settings) \u003e 1:"},{"line_number":476,"context_line":"                # More components to update - trigger reboot before continuing"},{"line_number":477,"context_line":"                #  Some hardware can only execute NIC firmware updates after"}],"source_content_type":"text/x-python","patch_set":2,"id":"8b79be7a_39f80677","line":474,"in_reply_to":"b32bd90f_67bfc9fa","updated":"2026-04-01 01:57:45.000000000","message":"Done","commit_id":"00280a9c4ab9aa1df4542bfdc3c4c9479407ce0b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"96d3ddda0eadc4533dbb01a754a50520b36339a8","unresolved":true,"context_lines":[{"line_number":475,"context_line":"            if len(settings) \u003e 1:"},{"line_number":476,"context_line":"                # More components to update - trigger reboot before continuing"},{"line_number":477,"context_line":"                #  Some hardware can only execute NIC firmware updates after"},{"line_number":478,"context_line":"                # the host reboots following the BMC firmware update."},{"line_number":479,"context_line":"                LOG.info(\u0027BMC firmware update complete for node %(node)s. \u0027"},{"line_number":480,"context_line":"                         \u0027More components pending - triggering reboot before \u0027"},{"line_number":481,"context_line":"                         \u0027continuing to next component.\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"42c5bc76_e2acd073","line":478,"updated":"2026-02-16 20:14:47.000000000","message":"move the lock up here.","commit_id":"00280a9c4ab9aa1df4542bfdc3c4c9479407ce0b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1b34ce16ad7a6e23e25d2f69c21555d2b847415a","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            if len(settings) \u003e 1:"},{"line_number":476,"context_line":"                # More components to update - trigger reboot before continuing"},{"line_number":477,"context_line":"                #  Some hardware can only execute NIC firmware updates after"},{"line_number":478,"context_line":"                # the host reboots following the BMC firmware update."},{"line_number":479,"context_line":"                LOG.info(\u0027BMC firmware update complete for node %(node)s. \u0027"},{"line_number":480,"context_line":"                         \u0027More components pending - triggering reboot before \u0027"},{"line_number":481,"context_line":"                         \u0027continuing to next component.\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"d363e572_02f3dba3","line":478,"in_reply_to":"42c5bc76_e2acd073","updated":"2026-03-12 02:35:18.000000000","message":"Acknowledged","commit_id":"00280a9c4ab9aa1df4542bfdc3c4c9479407ce0b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"96d3ddda0eadc4533dbb01a754a50520b36339a8","unresolved":true,"context_lines":[{"line_number":485,"context_line":"                node.set_driver_internal_info(\u0027redfish_fw_updates\u0027, settings)"},{"line_number":486,"context_line":"                node.save()"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"                task.upgrade_lock()"},{"line_number":489,"context_line":"                manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":490,"context_line":"                return"},{"line_number":491,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff7b60dd_f14a5af7","line":488,"updated":"2026-02-16 20:14:47.000000000","message":"We need to upgrade the lock prior to trying to change the node.","commit_id":"00280a9c4ab9aa1df4542bfdc3c4c9479407ce0b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1b34ce16ad7a6e23e25d2f69c21555d2b847415a","unresolved":false,"context_lines":[{"line_number":485,"context_line":"                node.set_driver_internal_info(\u0027redfish_fw_updates\u0027, settings)"},{"line_number":486,"context_line":"                node.save()"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"                task.upgrade_lock()"},{"line_number":489,"context_line":"                manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":490,"context_line":"                return"},{"line_number":491,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"b2a559ea_45ac8841","line":488,"in_reply_to":"ff7b60dd_f14a5af7","updated":"2026-03-12 02:35:18.000000000","message":"Acknowledged","commit_id":"00280a9c4ab9aa1df4542bfdc3c4c9479407ce0b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"96d3ddda0eadc4533dbb01a754a50520b36339a8","unresolved":true,"context_lines":[{"line_number":487,"context_line":""},{"line_number":488,"context_line":"                task.upgrade_lock()"},{"line_number":489,"context_line":"                manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":490,"context_line":"                return"},{"line_number":491,"context_line":"            else:"},{"line_number":492,"context_line":"                # Last component - no reboot needed"},{"line_number":493,"context_line":"                # Servicing/Cleaning will trigger one."}],"source_content_type":"text/x-python","patch_set":2,"id":"0810fef9_732f7737","line":490,"updated":"2026-02-16 20:14:47.000000000","message":"I\u0027d appreciate a few more comments here because this seems to be a much different path here. Like, how do we end up wrapping up the sequence then?","commit_id":"00280a9c4ab9aa1df4542bfdc3c4c9479407ce0b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1b34ce16ad7a6e23e25d2f69c21555d2b847415a","unresolved":true,"context_lines":[{"line_number":487,"context_line":""},{"line_number":488,"context_line":"                task.upgrade_lock()"},{"line_number":489,"context_line":"                manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":490,"context_line":"                return"},{"line_number":491,"context_line":"            else:"},{"line_number":492,"context_line":"                # Last component - no reboot needed"},{"line_number":493,"context_line":"                # Servicing/Cleaning will trigger one."}],"source_content_type":"text/x-python","patch_set":2,"id":"aaed0991_ab326609","line":490,"in_reply_to":"0810fef9_732f7737","updated":"2026-03-12 02:35:18.000000000","message":"I will add more details.","commit_id":"00280a9c4ab9aa1df4542bfdc3c4c9479407ce0b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3507bcd4143252fc809546a06e5504859824df84","unresolved":false,"context_lines":[{"line_number":487,"context_line":""},{"line_number":488,"context_line":"                task.upgrade_lock()"},{"line_number":489,"context_line":"                manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":490,"context_line":"                return"},{"line_number":491,"context_line":"            else:"},{"line_number":492,"context_line":"                # Last component - no reboot needed"},{"line_number":493,"context_line":"                # Servicing/Cleaning will trigger one."}],"source_content_type":"text/x-python","patch_set":2,"id":"93f6e40f_df57781b","line":490,"in_reply_to":"aaed0991_ab326609","updated":"2026-04-01 01:57:45.000000000","message":"Done","commit_id":"00280a9c4ab9aa1df4542bfdc3c4c9479407ce0b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6a251364e9c61d1674562f8a692e3974cfb77c23","unresolved":true,"context_lines":[{"line_number":500,"context_line":"                # Last component - no reboot needed"},{"line_number":501,"context_line":"                # Servicing/Cleaning will trigger one."},{"line_number":502,"context_line":"                LOG.info(\u0027BMC firmware update complete for node %(node)s \u0027"},{"line_number":503,"context_line":"                         \u0027(last component)\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":504,"context_line":"                node.save()"},{"line_number":505,"context_line":"                self._continue_updates(task, update_service, settings)"},{"line_number":506,"context_line":"            return"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        # Check if we\u0027ve been checking for too long"}],"source_content_type":"text/x-python","patch_set":6,"id":"7ba925ea_b2964569","line":505,"range":{"start_line":503,"start_character":0,"end_line":505,"end_character":70},"updated":"2026-04-01 19:48:47.000000000","message":"Err, we need to upgrade the lock before trying to save the node otherwise we\u0027re possibly making changes without an exclusive db lock. Seems like the right thing to do is move the lock to the beginning of the method. Thoughts?","commit_id":"09dbd4ce6637c221df088fdd01f6ac95ef983e60"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2da536e2f1004cf7c7749d2cd0573cc18378bbee","unresolved":false,"context_lines":[{"line_number":500,"context_line":"                # Last component - no reboot needed"},{"line_number":501,"context_line":"                # Servicing/Cleaning will trigger one."},{"line_number":502,"context_line":"                LOG.info(\u0027BMC firmware update complete for node %(node)s \u0027"},{"line_number":503,"context_line":"                         \u0027(last component)\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":504,"context_line":"                node.save()"},{"line_number":505,"context_line":"                self._continue_updates(task, update_service, settings)"},{"line_number":506,"context_line":"            return"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        # Check if we\u0027ve been checking for too long"}],"source_content_type":"text/x-python","patch_set":6,"id":"7e4d0d0e_54d4ce54","line":505,"range":{"start_line":503,"start_character":0,"end_line":505,"end_character":70},"in_reply_to":"7ba925ea_b2964569","updated":"2026-04-01 22:03:55.000000000","message":"You are absolutely right, going to update the patch later today.","commit_id":"09dbd4ce6637c221df088fdd01f6ac95ef983e60"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"b734703a0dc659f31c921085980a612f6622d74a","unresolved":true,"context_lines":[{"line_number":472,"context_line":"                and current_version !\u003d version_before):"},{"line_number":473,"context_line":"            LOG.info("},{"line_number":474,"context_line":"                \u0027BMC firmware version for node %(node)s changed from \u0027"},{"line_number":475,"context_line":"                \u0027%(old)s to %(new)s. Update complete. Continuing without \u0027"},{"line_number":476,"context_line":"                \u0027reboot.\u0027,"},{"line_number":477,"context_line":"                {\u0027node\u0027: node.uuid, \u0027old\u0027: version_before,"},{"line_number":478,"context_line":"                 \u0027new\u0027: current_version})"}],"source_content_type":"text/x-python","patch_set":7,"id":"353785bc_68f94989","line":475,"updated":"2026-04-02 16:34:05.000000000","message":"Perhaps we should drop the log statement \u0027Continuing without reboot\u0027 here, and add it to L507","commit_id":"40253d717b9b3581c931b072cb2085b5de72bd36"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c7f17d5283927811ebb264a79fa532457febecb5","unresolved":false,"context_lines":[{"line_number":472,"context_line":"                and current_version !\u003d version_before):"},{"line_number":473,"context_line":"            LOG.info("},{"line_number":474,"context_line":"                \u0027BMC firmware version for node %(node)s changed from \u0027"},{"line_number":475,"context_line":"                \u0027%(old)s to %(new)s. Update complete. Continuing without \u0027"},{"line_number":476,"context_line":"                \u0027reboot.\u0027,"},{"line_number":477,"context_line":"                {\u0027node\u0027: node.uuid, \u0027old\u0027: version_before,"},{"line_number":478,"context_line":"                 \u0027new\u0027: current_version})"}],"source_content_type":"text/x-python","patch_set":7,"id":"8e6aa6a8_f0a58a97","line":475,"in_reply_to":"353785bc_68f94989","updated":"2026-04-02 17:55:44.000000000","message":"I will move this LOG to the else block \u003d)","commit_id":"40253d717b9b3581c931b072cb2085b5de72bd36"}]}