)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"91262833e0ca4823fe0d917b70e557881d746010","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"426c79c5_85fb707e","updated":"2026-02-18 14:12:06.000000000","message":"@me@clifhouck.com this is just a backport from a change on master, that was already approved and merged. I guess we can keep discussing if you have any questions, doubts or concerns, or maybe even propose an follow up on master, but blocking this does not make a lot of sense.","commit_id":"69bf9ab79f14184f2a17a4f3e4dd8824e8328cdd"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"3506bc0a74b75df6f465a60bafd2eda5938aeeed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c6edd32d_5755c954","updated":"2026-02-18 17:53:53.000000000","message":"I apologize, I didn\u0027t realize this was a backport. I do find the logic hard to follow and inconsistent as it stands though.","commit_id":"69bf9ab79f14184f2a17a4f3e4dd8824e8328cdd"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"00381a8b03f5f134cfc6c05e6f9aef940f89f73a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"de8f6aef_258bbb92","updated":"2026-02-17 17:30:38.000000000","message":"I\u0027m a little confused by this change given the existing code.","commit_id":"69bf9ab79f14184f2a17a4f3e4dd8824e8328cdd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"96360d0c9dd0fdc6eb0150f7f7f15000b9d5136d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9fa3a78a_47e16f76","updated":"2026-02-24 18:57:42.000000000","message":"Lets fix review feedback on this on master instead. Since this is a stable backport.","commit_id":"69bf9ab79f14184f2a17a4f3e4dd8824e8328cdd"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b519973bfd53169552b62dc2c356b286946294bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0a0d195f_b574a202","updated":"2026-02-23 09:28:44.000000000","message":"recheck","commit_id":"69bf9ab79f14184f2a17a4f3e4dd8824e8328cdd"}],"ironic/drivers/modules/redfish/management.py":[{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"00381a8b03f5f134cfc6c05e6f9aef940f89f73a","unresolved":true,"context_lines":[{"line_number":177,"context_line":"                       VENDORS_REQUIRING_FULL_BOOT_REQUEST)"},{"line_number":178,"context_line":"    )"},{"line_number":179,"context_line":"    if vendor and vendor.lower() \u003d\u003d \u0027supermicro\u0027:"},{"line_number":180,"context_line":"        enabled \u003d BOOT_DEVICE_PERSISTENT_MAP_REV[persistent]"},{"line_number":181,"context_line":"        LOG.debug(\u0027Setting BootSourceOverrideEnable to %(enable)s \u0027"},{"line_number":182,"context_line":"                  \u0027on Supermicro BMC, node %(node)s\u0027,"},{"line_number":183,"context_line":"                  {\u0027enable\u0027: enabled, \u0027node\u0027: task.node.uuid})"}],"source_content_type":"text/x-python","patch_set":1,"id":"251afc5e_7deefd19","line":180,"updated":"2026-02-17 17:30:38.000000000","message":"In this if block only `enabled` is set, and `desired_enabled` is not. Is that ok?","commit_id":"69bf9ab79f14184f2a17a4f3e4dd8824e8328cdd"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"00381a8b03f5f134cfc6c05e6f9aef940f89f73a","unresolved":true,"context_lines":[{"line_number":182,"context_line":"                  \u0027on Supermicro BMC, node %(node)s\u0027,"},{"line_number":183,"context_line":"                  {\u0027enable\u0027: enabled, \u0027node\u0027: task.node.uuid})"},{"line_number":184,"context_line":"    else:"},{"line_number":185,"context_line":"        desired_enabled \u003d BOOT_DEVICE_PERSISTENT_MAP_REV[persistent]"},{"line_number":186,"context_line":"        current_enabled \u003d system.boot.get(\u0027enabled\u0027)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # NOTE(etingof): this can be racy, esp if BMC is not RESTful"},{"line_number":189,"context_line":"        enabled \u003d (desired_enabled"},{"line_number":190,"context_line":"                   if desired_enabled !\u003d current_enabled else None)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    # Logging callback for retry attempts (closure captures task)"},{"line_number":193,"context_line":"    def _log_post_boot_retry(retry_state):"}],"source_content_type":"text/x-python","patch_set":1,"id":"eb79cfef_be281912","line":190,"range":{"start_line":185,"start_character":0,"end_line":190,"end_character":67},"updated":"2026-02-17 17:30:38.000000000","message":"I\u0027m a bit confused by this. You\u0027re setting `enabled` based off of `desired_enabled` here, but using `desired_enabled` below. Why?","commit_id":"69bf9ab79f14184f2a17a4f3e4dd8824e8328cdd"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"00381a8b03f5f134cfc6c05e6f9aef940f89f73a","unresolved":true,"context_lines":[{"line_number":230,"context_line":"            system.set_system_boot_options("},{"line_number":231,"context_line":"                device,"},{"line_number":232,"context_line":"                mode\u003ddesired_mode,"},{"line_number":233,"context_line":"                enabled\u003ddesired_enabled,"},{"line_number":234,"context_line":"                http_boot_uri\u003dhttp_boot_url"},{"line_number":235,"context_line":"            )"},{"line_number":236,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"0f38cbe3_a734dc37","line":233,"range":{"start_line":233,"start_character":0,"end_line":233,"end_character":2},"updated":"2026-02-17 17:30:38.000000000","message":"In above code, `desired_enabled` is not always set (when vendor is supermicro). Is that OK/intended?","commit_id":"69bf9ab79f14184f2a17a4f3e4dd8824e8328cdd"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"00381a8b03f5f134cfc6c05e6f9aef940f89f73a","unresolved":true,"context_lines":[{"line_number":236,"context_line":"        else:"},{"line_number":237,"context_line":"            LOG.debug(\u0027Sending minimal Redfish boot device change for \u0027"},{"line_number":238,"context_line":"                      \u0027node %(node)s\u0027, {\u0027node\u0027: task.node.uuid})"},{"line_number":239,"context_line":"            system.set_system_boot_options(device, enabled\u003denabled,"},{"line_number":240,"context_line":"                                           http_boot_uri\u003dhttp_boot_url)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"f0887adb_32e33e68","line":239,"updated":"2026-02-17 17:30:38.000000000","message":"Should this also be using `desired_enabled`? Seems like we should also log the sent enabled if it makes sense to do so.","commit_id":"69bf9ab79f14184f2a17a4f3e4dd8824e8328cdd"}]}