)]}'
{"id":"openstack%2Fironic~976751","triplet_id":"openstack%2Fironic~bugfix%2F34.0~Ia2a92392ec494e79f7644c97190c635a954a0220","project":"openstack/ironic","branch":"bugfix/34.0","attention_set":{},"removed_from_attention_set":{"23851":{"account":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"last_update":"2026-02-24 20:05:39.000000000","reason":"Change was submitted"}},"hashtags":["ironic-week-prio"],"change_id":"Ia2a92392ec494e79f7644c97190c635a954a0220","subject":"Fix Redfish boot device setting for full boot request vendors","status":"MERGED","created":"2026-02-13 15:46:40.000000000","updated":"2026-02-24 20:06:56.000000000","submitted":"2026-02-24 20:05:39.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":9,"unresolved_comment_count":4,"has_review_started":true,"submission_id":"976751","cherry_pick_of_change":976237,"cherry_pick_of_patch_set":3,"meta_rev_id":"cf19f89bc3f21546533a135f7b664270d1046d06","_number":976751,"virtual_id_number":976751,"owner":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-02-24 20:05:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":0,"date":"2026-02-18 17:53:53.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},{"value":2,"date":"2026-02-24 18:57:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":0,"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},{"value":1,"date":"2026-02-24 18:57:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":38824,"name":"Léonard Suslian","display_name":"Léonard Suslian","email":"leonard@suslian.engineer","username":"synthe102"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-13 15:46:40.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":38824,"name":"Léonard Suslian","display_name":"Léonard Suslian","email":"leonard@suslian.engineer","username":"synthe102"},"state":"CC"},{"updated":"2026-02-13 16:23:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-02-17 17:30:38.000000000","updated_by":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"reviewer":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"state":"REVIEWER"},{"updated":"2026-02-24 18:57:42.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"}],"messages":[{"id":"25df0587c2b87e939d10f1e0636073e19b1310d9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2026-02-13 15:46:40.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"ce054d8a840bb7f3b23f74cf9130e76ed127a9fc","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2026-02-13 15:48:44.000000000","message":"Hashtag added: ironic-week-prio","accounts_in_message":[],"_revision_number":1},{"id":"dbe4d48055006821db32bdcddc2c38ac72996a67","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-02-13 16:23:11.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/25d868e408a54b2fbdecc3abeed09535\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7c71f3dbb70041668076b492593663f5 : SUCCESS in 11m 52s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/90c68fc76cfc478b91f0e25e0803295e : SUCCESS in 6m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d3271f83a5e940b5bdd645f8bb7084fd : SUCCESS in 19m 26s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/cb1e0ad477934e0ba384f318781c90f5 : SUCCESS in 29m 15s\n- ironic-tox-unit-mysql-migrations https://zuul.opendev.org/t/openstack/build/85ca5f7075364560972fe2c1df559279 : SUCCESS in 4m 33s\n- ironic-tox-unit-with-driver-libs https://zuul.opendev.org/t/openstack/build/142d10ea4d904c56a0a20dab80e4d850 : SUCCESS in 12m 51s\n- ironic-cross-sushy https://zuul.opendev.org/t/openstack/build/eb2033deecea4113a240a22796641a5a : SUCCESS in 9m 44s (non-voting)\n- metal3-integration https://zuul.opendev.org/t/openstack/build/eb8d180dd71b4efeb351f54e2053b02d : FAILURE in 24m 10s\n- metal3-ironic-standalone-operator-functional https://zuul.opendev.org/t/openstack/build/a8a30323162e471fa2f5bb091d2c8ac0 : FAILURE in 8m 49s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"00381a8b03f5f134cfc6c05e6f9aef940f89f73a","author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"date":"2026-02-17 17:30:38.000000000","message":"Patch Set 1: Code-Review-1\n\n(5 comments)","accounts_in_message":[],"_revision_number":1},{"id":"91262833e0ca4823fe0d917b70e557881d746010","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2026-02-18 14:12:06.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3506bc0a74b75df6f465a60bafd2eda5938aeeed","author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"date":"2026-02-18 17:53:53.000000000","message":"Patch Set 1: -Code-Review\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b519973bfd53169552b62dc2c356b286946294bc","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2026-02-23 09:28:44.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"516289431bf027e5ea37aa0a946efe7c5808de41","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-02-23 09:56:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a72ac19d06644b4fbf16d7b3698d98ab\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4308815e87e34c1a8e5b59d9e0774331 : SUCCESS in 13m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5210fa97872c4d109db83ba3725c748c : SUCCESS in 5m 31s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6fb1979e6ebe4932a719649de9189f9e : SUCCESS in 9m 22s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5701f274ead5462a9529245b7763ca93 : SUCCESS in 22m 34s\n- ironic-tox-unit-mysql-migrations https://zuul.opendev.org/t/openstack/build/ae71ba5826084d88b0b90ff66ae72c49 : SUCCESS in 3m 45s\n- ironic-tox-unit-with-driver-libs https://zuul.opendev.org/t/openstack/build/99d8ef5032974452950767cb2262be54 : SUCCESS in 9m 04s\n- ironic-cross-sushy https://zuul.opendev.org/t/openstack/build/cebcc188b6264e159134e6a1b5f79011 : SUCCESS in 8m 12s (non-voting)\n- metal3-ironic-standalone-operator-functional https://zuul.opendev.org/t/openstack/build/ea060ef91ef247e2a815d42a51fd1dc5 : FAILURE in 10m 06s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"96360d0c9dd0fdc6eb0150f7f7f15000b9d5136d","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2026-02-24 18:57:42.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"633dd2da3f44196a83dd0be570957a618161ebfb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-02-24 18:57:59.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"09fbaa47603344312837fbd4197fdb869f64b77f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-02-24 20:05:39.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d558f7dc6c1f4aaaa1ee2d8969fc0323\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d154ff1643b245c78949b18c64f88cc1 : SUCCESS in 3m 47s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fafcfbde70c34e5eb83d6548d48eee58 : SUCCESS in 8m 31s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/40c95e37719e48d3929df767269e18b8 : SUCCESS in 13m 12s\n- ironic-tox-unit-mysql-migrations https://zuul.opendev.org/t/openstack/build/3a0c2e91b4b344bb85b4119ecd395d73 : SUCCESS in 5m 07s\n- ironic-tox-unit-with-driver-libs https://zuul.opendev.org/t/openstack/build/733a914849da4847aad88ac8c043251e : SUCCESS in 8m 17s","accounts_in_message":[],"_revision_number":1},{"id":"ca3ee6096bae08f06debde3298a48fa1fc57dfc5","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-02-24 20:05:39.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"cf19f89bc3f21546533a135f7b664270d1046d06","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-02-24 20:06:56.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/005462b32c674a598c8e2439ed6af4bd\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/63c54646cac648059aa1bb1cfe496712 : SUCCESS in 1m 05s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/995706a68a054eb992b47c90f0eab6c8 : SUCCESS in 55s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"69bf9ab79f14184f2a17a4f3e4dd8824e8328cdd","revisions":{"69bf9ab79f14184f2a17a4f3e4dd8824e8328cdd":{"kind":"REWORK","_number":1,"created":"2026-02-13 15:46:40.000000000","uploader":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"ref":"refs/changes/51/976751/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic","ref":"refs/changes/51/976751/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic refs/changes/51/976751/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic refs/changes/51/976751/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic refs/changes/51/976751/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic refs/changes/51/976751/1"}}},"commit":{"parents":[{"commit":"79669b5de7396d105e17cbb5e0941facf6f9fcf7","subject":"Update .gitreview for bugfix/34.0","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic/commit/79669b5de7396d105e17cbb5e0941facf6f9fcf7"}]}],"author":{"name":"synthe102","email":"leonard@suslian.engineer","date":"2026-02-10 12:30:20.000000000","tz":60},"committer":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2026-02-13 15:46:40.000000000","tz":0},"subject":"Fix Redfish boot device setting for full boot request vendors","message":"Fix Redfish boot device setting for full boot request vendors\n\nThe _set_boot_device method was incorrectly using \u0027enabled\u0027 instead of\n\u0027desired_enabled\u0027 when setting boot options for vendors that require\nfull boot parameter requests. This caused issues because \u0027enabled\u0027 can\nbe None (when current and desired states match), but vendors requiring\nfull boot requests need explicit values for all parameters.\n\nThis fix ensures that vendors in VENDORS_REQUIRING_FULL_BOOT_REQUEST\nalways receive the explicit desired_enabled value, which is necessary\nfor proper boot device configuration on these systems.\n\nCloses-Bug: #2141405\n\nChange-Id: Ia2a92392ec494e79f7644c97190c635a954a0220\nSigned-off-by: synthe102 \u003cleonard@suslian.engineer\u003e\n(cherry picked from commit 79959b5b746b06fa0dafb5e8d35fe993ec87ea73)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic/commit/69bf9ab79f14184f2a17a4f3e4dd8824e8328cdd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic/commit/69bf9ab79f14184f2a17a4f3e4dd8824e8328cdd"}]},"branch":"refs/heads/bugfix/34.0"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}