)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"689ffdd97905ef96c318479eb4468eb2e7cc108a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8390eea7_5d323b9c","updated":"2026-03-18 17:47:04.000000000","message":"recheck","commit_id":"d43d14552df50e4da48a93accfc43a14f2769fd6"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"0ec1a6ba34729ce66f88fc99c56cbe9c4339d48b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"38833e16_4b178d35","updated":"2026-05-05 16:52:11.000000000","message":"I will be abandoning this change at any moment in the future, since the root patch has now merged https://review.opendev.org/c/openstack/oslo.service/+/981849","commit_id":"28cf20c134c25c2f02132d8da1c89e50e54b1a17"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"e2a8b1c53bd6ef9253e3f5722feb1f4217c08131","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9df63d66_1940fd75","updated":"2026-04-27 15:17:06.000000000","message":"Overall the change looks good, but I\u0027m putting a -1 to request an additional unit test to verify assumptions laid out in the comments of `BaseConductorManager.__{get,set}_state()`.","commit_id":"28cf20c134c25c2f02132d8da1c89e50e54b1a17"}],"ironic/common/rpc_service.py":[{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"e2a8b1c53bd6ef9253e3f5722feb1f4217c08131","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":"        state \u003d self.__dict__.copy()"},{"line_number":64,"context_line":"        # ThreadGroup from oslo.service.Service contains threads/locks"},{"line_number":65,"context_line":"        state.pop(\u0027tg\u0027, None)"},{"line_number":66,"context_line":"        return state"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def __setstate__(self, state):"}],"source_content_type":"text/x-python","patch_set":2,"id":"87c3d097_13b399ee","line":65,"updated":"2026-04-27 15:17:06.000000000","message":"Should we raise an issue for this in oslo_service and patch it there instead of here?","commit_id":"28cf20c134c25c2f02132d8da1c89e50e54b1a17"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"2f2d2b1e2e0bec2e10c49ccc14aff15906bc2a77","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":"        state \u003d self.__dict__.copy()"},{"line_number":64,"context_line":"        # ThreadGroup from oslo.service.Service contains threads/locks"},{"line_number":65,"context_line":"        state.pop(\u0027tg\u0027, None)"},{"line_number":66,"context_line":"        return state"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def __setstate__(self, state):"}],"source_content_type":"text/x-python","patch_set":2,"id":"eff9421b_892e2c62","line":65,"in_reply_to":"87c3d097_13b399ee","updated":"2026-05-04 16:07:58.000000000","message":"https://review.opendev.org/c/openstack/oslo.service/+/981849","commit_id":"28cf20c134c25c2f02132d8da1c89e50e54b1a17"}],"ironic/conductor/base_manager.py":[{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"e2a8b1c53bd6ef9253e3f5722feb1f4217c08131","unresolved":true,"context_lines":[{"line_number":82,"context_line":"            state[\u0027_keepalive_evt\u0027] \u003d (evt.is_set() if hasattr(evt, \u0027is_set\u0027)"},{"line_number":83,"context_line":"                                       else bool(evt))"},{"line_number":84,"context_line":"        # Thread pool executors and periodic tasks are recreated in"},{"line_number":85,"context_line":"        # init_host()"},{"line_number":86,"context_line":"        for attr in (\u0027_executor\u0027, \u0027_reserved_executor\u0027,"},{"line_number":87,"context_line":"                     \u0027_periodic_tasks\u0027, \u0027_periodic_tasks_worker\u0027):"},{"line_number":88,"context_line":"            state.pop(attr, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9011c2ab_39eba6d9","line":85,"updated":"2026-04-27 15:17:06.000000000","message":"While I went through and verified these comments manually, I think it\u0027s worth writing a unit test to verify these assumptions hold true. This goes for any comment that claims something is done in `prepare_host/init_host`.\n\nThe test would look something like:\n- `ConductorManager` is brought up through `prepare_host`, `init_host`.\n- Have it go through pickle -\u003e unpickle.\n- Re-bring-up `ConductorManager` through `prepare_host`, `init_host`.\n- Verify assumptions about what should be set are true.\n\nMaybe you can slim it down some, or maybe there\u0027s a unit test that already covers this. I haven\u0027t checked thoroughly.","commit_id":"28cf20c134c25c2f02132d8da1c89e50e54b1a17"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"2f2d2b1e2e0bec2e10c49ccc14aff15906bc2a77","unresolved":true,"context_lines":[{"line_number":82,"context_line":"            state[\u0027_keepalive_evt\u0027] \u003d (evt.is_set() if hasattr(evt, \u0027is_set\u0027)"},{"line_number":83,"context_line":"                                       else bool(evt))"},{"line_number":84,"context_line":"        # Thread pool executors and periodic tasks are recreated in"},{"line_number":85,"context_line":"        # init_host()"},{"line_number":86,"context_line":"        for attr in (\u0027_executor\u0027, \u0027_reserved_executor\u0027,"},{"line_number":87,"context_line":"                     \u0027_periodic_tasks\u0027, \u0027_periodic_tasks_worker\u0027):"},{"line_number":88,"context_line":"            state.pop(attr, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5efe5bf8_8a0e2c64","line":85,"in_reply_to":"9011c2ab_39eba6d9","updated":"2026-05-04 16:07:58.000000000","message":"Wilco, likely in the master branch.","commit_id":"28cf20c134c25c2f02132d8da1c89e50e54b1a17"}]}