)]}'
{"ironic/db/sqlalchemy/api.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"8230ae0b8da4f76ae15b88716396d4516f6de500","unresolved":true,"context_lines":[{"line_number":33,"context_line":"from oslo_utils import timeutils"},{"line_number":34,"context_line":"from oslo_utils import uuidutils"},{"line_number":35,"context_line":"from osprofiler import sqlalchemy as osp_sqlalchemy"},{"line_number":36,"context_line":"import osprofiler.opts"},{"line_number":37,"context_line":"import sqlalchemy as sa"},{"line_number":38,"context_line":"from sqlalchemy import or_"},{"line_number":39,"context_line":"from sqlalchemy.exc import NoResultFound, MultipleResultsFound"}],"source_content_type":"text/x-python","patch_set":1,"id":"0a586fa9_89d5c880","line":36,"updated":"2026-02-25 17:01:05.000000000","message":"I think this needs a comment or something about why this is being imported. I\u0027ll also be surprised if this passes pep8 given it\u0027s not directly referenced.","commit_id":"dc70aaa6e5b554827f851b96ec0e904589ef2d21"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"1d17ba1ddad85e8e586e833513c51e45c5c54954","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from oslo_utils import timeutils"},{"line_number":34,"context_line":"from oslo_utils import uuidutils"},{"line_number":35,"context_line":"from osprofiler import sqlalchemy as osp_sqlalchemy"},{"line_number":36,"context_line":"import osprofiler.opts"},{"line_number":37,"context_line":"import sqlalchemy as sa"},{"line_number":38,"context_line":"from sqlalchemy import or_"},{"line_number":39,"context_line":"from sqlalchemy.exc import NoResultFound, MultipleResultsFound"}],"source_content_type":"text/x-python","patch_set":1,"id":"45cebe12_a1370af0","line":36,"in_reply_to":"0a586fa9_89d5c880","updated":"2026-02-25 19:20:53.000000000","message":"Done","commit_id":"dc70aaa6e5b554827f851b96ec0e904589ef2d21"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5c3ea183348bb5f1e82f705a4cef520a2fe6ba37","unresolved":true,"context_lines":[{"line_number":35,"context_line":"from osprofiler import sqlalchemy as osp_sqlalchemy"},{"line_number":36,"context_line":"# NOTE(clif): If osprofiler.opts is not imported, then accessing CONF.profiler"},{"line_number":37,"context_line":"# can fail below. This import prevents that behavior."},{"line_number":38,"context_line":"import osprofiler.opts # noqa"},{"line_number":39,"context_line":"import sqlalchemy as sa"},{"line_number":40,"context_line":"from sqlalchemy import or_"},{"line_number":41,"context_line":"from sqlalchemy.exc import NoResultFound, MultipleResultsFound"}],"source_content_type":"text/x-python","patch_set":4,"id":"9178550a_98d3cfa8","line":38,"updated":"2026-02-27 09:10:59.000000000","message":"can\u0027t we use an explicit registration call in ironic/common/config.py instead of having a \"ghost\" import ?","commit_id":"7f418f9da215cdc4508e7c77aab4498092daa193"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"f1c2562e809b6809726555b8ae5b9987a47b02de","unresolved":true,"context_lines":[{"line_number":35,"context_line":"from osprofiler import sqlalchemy as osp_sqlalchemy"},{"line_number":36,"context_line":"# NOTE(clif): If osprofiler.opts is not imported, then accessing CONF.profiler"},{"line_number":37,"context_line":"# can fail below. This import prevents that behavior."},{"line_number":38,"context_line":"import osprofiler.opts # noqa"},{"line_number":39,"context_line":"import sqlalchemy as sa"},{"line_number":40,"context_line":"from sqlalchemy import or_"},{"line_number":41,"context_line":"from sqlalchemy.exc import NoResultFound, MultipleResultsFound"}],"source_content_type":"text/x-python","patch_set":4,"id":"20ba6ff0_e739f76f","line":38,"in_reply_to":"9178550a_98d3cfa8","updated":"2026-02-27 17:17:29.000000000","message":"I tried a slightly different way by setting defaults in `ironic/conf/__init__.py` for osprofiler.","commit_id":"7f418f9da215cdc4508e7c77aab4498092daa193"}]}