)]}'
{"ironic/drivers/base.py":[{"author":{"_account_id":11702,"name":"Ellen Hui","email":"ellenfkh@gmail.com","username":"ellenfkh"},"change_message_id":"902a2535dea7560de626f202863ab19ade1affb9","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        This method validates whether the \u0027driver_info\u0027 property of the"},{"line_number":104,"context_line":"        task\u0027s node contains the required information for this driver to"},{"line_number":105,"context_line":"        deploy images to the node. If invalid, raises an exception; otherwise"},{"line_number":106,"context_line":"        returns nothing."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":109,"context_line":"        :param node: a single Node to validate."}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_e61838d5","line":106,"updated":"2014-06-04 22:28:53.000000000","message":"It might be slightly more clear to say \"otherwise returns None\" instead of \"otherwise returns nothing\", just to be completely explicit.","commit_id":"dcf4cd6ca3d5ce03f23a06a867ceccc17344e87c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3761215738e133ccf6a4595ab8b01b88612139a9","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        This method validates whether the \u0027driver_info\u0027 property of the"},{"line_number":104,"context_line":"        task\u0027s node contains the required information for this driver to"},{"line_number":105,"context_line":"        deploy images to the node. If invalid, raises an exception; otherwise"},{"line_number":106,"context_line":"        returns nothing."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":109,"context_line":"        :param node: a single Node to validate."}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_8cda3315","line":106,"in_reply_to":"1ae5cdf2_667508ca","updated":"2014-06-05 00:09:08.000000000","message":"Done! Thx for the feedback.","commit_id":"dcf4cd6ca3d5ce03f23a06a867ceccc17344e87c"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"52b2ff9b75be59087cae34b846f5b763d093f340","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        This method validates whether the \u0027driver_info\u0027 property of the"},{"line_number":104,"context_line":"        task\u0027s node contains the required information for this driver to"},{"line_number":105,"context_line":"        deploy images to the node. If invalid, raises an exception; otherwise"},{"line_number":106,"context_line":"        returns nothing."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":109,"context_line":"        :param node: a single Node to validate."}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_667508ca","line":106,"in_reply_to":"1ae5cdf2_e61838d5","updated":"2014-06-04 22:39:43.000000000","message":"Totally agree.","commit_id":"dcf4cd6ca3d5ce03f23a06a867ceccc17344e87c"}],"ironic/drivers/modules/seamicro.py":[{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"3dbcb567fcf4bbe559e92f5648898dd7f4b15c40","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def validate(self, task, **kwargs):"},{"line_number":388,"context_line":"        method \u003d kwargs[\u0027method\u0027]"},{"line_number":389,"context_line":"        if method in VENDOR_PASSTHRU_METHODS:"},{"line_number":390,"context_line":"            return"},{"line_number":391,"context_line":"        else:"},{"line_number":392,"context_line":"            raise exception.InvalidParameterValue(_("}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_91aebf2c","line":389,"updated":"2014-06-05 09:47:26.000000000","message":"if there was a reason to put a new version up I\u0027d suggest:\n\nif method not in VENDOR_PASSTHRU_METHODS:\n    raise exception.InvalidParameterValue(_(\n\t\"Unsupported method (%s) passed to SeaMicro driver.\") \n        % method)\n\nbut that\u0027s not enough reason to hold this review up :)","commit_id":"2338dd903439d00fd1cd405ea38cc7b6720ab2c3"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b7f2390fdbd4466eee552303c7860206abbe9c8f","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def validate(self, task, **kwargs):"},{"line_number":388,"context_line":"        method \u003d kwargs[\u0027method\u0027]"},{"line_number":389,"context_line":"        if method in VENDOR_PASSTHRU_METHODS:"},{"line_number":390,"context_line":"            return"},{"line_number":391,"context_line":"        else:"},{"line_number":392,"context_line":"            raise exception.InvalidParameterValue(_("}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_5e75c830","line":389,"in_reply_to":"1ae5cdf2_91aebf2c","updated":"2014-06-09 09:29:13.000000000","message":"+1","commit_id":"2338dd903439d00fd1cd405ea38cc7b6720ab2c3"}]}